github/deprecated-helm-charts
1
0
Fork 0
mirror of https://github.com/helm/charts.git synced 2026-08-23 22:37:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add versioning policies to review guidelines (#11207)

Browse Source 
Fixes #5657 

Signed-off-by: Scott Rigby <scott@r6by.com>
This commit is contained in:
Scott Rigby
2019-02-10 22:52:00 -08:00
committed by Kubernetes Prow Robot
parent d701bf9068
commit 6a9d3752a8
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
REVIEW_GUIDELINES.md
+11
View File
@@ -16,6 +16,17 @@ Note, if a reviewer who is not an approver in an OWNERS file leaves a comment of
Chart releases must be immutable. Any change to a chart warrants a chart version bump even if it is only changes to the documentation.
## Versioning
The chart `version` should follow [semver](https://semver.org/).
Stable charts should start at `1.0.0` (for maintainability don't create new PRs for stable charts only to meet this criteria, but when reviewing PRs take the opportunity to ensure that this is met).
Any breaking (backwards incompatible) changes to a chart should:
1. Bump the MAJOR version
2. In the README, under a section called "Upgrading", describe the manual steps necessary to upgrade to the new (specified) MAJOR version
## Chart Metadata
The `Chart.yaml` should be as complete as possible. The following fields are mandatory: