Fix default values for tolerations, nodeSelector and resources. (#8849)

In several places, the empty default for tolerations was an object
where it should have been an array, for nodeSelectors the opposite,
should be an object but was specified in an array, and for one
case of resources, the empty object was just missing.

Updated these all to what they should be, which has eliminated
errors like the following when running:

```
2018/10/27 00:46:18 warning: cannot overwrite table with non table for tolerations (map[])
2018/10/27 00:46:18 warning: destination for nodeSelector is a table. Ignoring non-table value []
2018/10/27 00:46:18 warning: destination for nodeSelector is a table. Ignoring non-table value []
2018/10/27 00:46:18 warning: destination for resources is a table. Ignoring non-table value <nil>
2018/10/27 00:46:18 warning: cannot overwrite table with non table for tolerations (map[])
2018/10/27 00:46:18 warning: destination for nodeSelector is a table. Ignoring non-table value []
```

Signed-off-by: Joe Hohertz <joe@viafoura.com>
This commit is contained in:
Joe Hohertz
2018-10-29 11:47:40 -07:00
committed by k8s-ci-robot
parent 24699be824
commit f77b473719
4 changed files with 16 additions and 16 deletions
+1 -1
View File
@@ -9,7 +9,7 @@ name: prometheus-operator
sources:
- https://github.com/coreos/prometheus-operator
- https://coreos.com/operators/prometheus
version: 0.1.7
version: 0.1.8
appVersion: "0.24.0"
home: https://github.com/coreos/prometheus-operator
keywords:
+3 -3
View File
@@ -75,8 +75,8 @@ The following tables lists the configurable parameters of the prometheus-operato
| `prometheusOperator.kubeletService.namespace` | Namespace to deploy kubelet service | `true` |
| `prometheusOperator.serviceMonitor.selfMonitor` | Enable monitoring of prometheus operator | `true` |
| `prometheusOperator.resources` | Resource limits for prometheus operator | `{}` |
| `prometheusOperator.nodeSelector` | Prometheus operator node selector https://kubernetes.io/docs/user-guide/node-selection/ | `[]` |
| `prometheusOperator.tolerations` | Tolerations for use with node taints https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/ | `{}` |
| `prometheusOperator.nodeSelector` | Prometheus operator node selector https://kubernetes.io/docs/user-guide/node-selection/ | `{}` |
| `prometheusOperator.tolerations` | Tolerations for use with node taints https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/ | `[]` |
| `prometheusOperator.affinity` | Assign the prometheus operator to run on specific nodes https://kubernetes.io/docs/concepts/configuration/assign-pod-node/ | `{}` |
| `prometheusOperator.image.repository` | Repository for prometheus operator image | `quay.io/coreos/prometheus-operator` |
| `prometheusOperator.image.tag` | Tag for prometheus operator image | `v0.24.0` |
@@ -125,7 +125,7 @@ The following tables lists the configurable parameters of the prometheus-operato
| `prometheus.prometheusSpec.ruleNamespaceSelector` | Namespaces to be selected for PrometheusRules discovery. If unspecified, only the same namespace as the Prometheus object is in is used. | `{}` |
| `prometheus.prometheusSpec.alertingEndpoints` | Alertmanagers to which alerts will be sent https://github.com/coreos/prometheus-operator/blob/master/Documentation/api.md#alertmanagerendpoints Default configuration will connect to the alertmanager deployed as part of this release | `[]` |
| `prometheus.prometheusSpec.resources` | Define resources requests and limits for single Pods. | `{}` |
| `prometheus.prometheusSpec.nodeSelector` | Define which Nodes the Pods are scheduled on. | `[]` |
| `prometheus.prometheusSpec.nodeSelector` | Define which Nodes the Pods are scheduled on. | `{}` |
| `prometheus.prometheusSpec.secrets` | Secrets is a list of Secrets in the same namespace as the Prometheus object, which shall be mounted into the Prometheus Pods. The Secrets are mounted into /etc/prometheus/secrets/<secret-name>. Secrets changes after initial creation of a Prometheus object are not reflected in the running Pods. To change the secrets mounted into the Prometheus Pods, the object must be deleted and recreated with the new list of secrets. | `[]` |
|`prometheus.prometheusSpec.podAntiAffinity` | Pod anti-affinity can prevent the scheduler from placing Prometheus replicas on the same node. The default value "soft" means that the scheduler should *prefer* to not schedule two replica pods onto the same node but no guarantee is provided. The value "hard" means that the scheduler is *required* to not schedule two replica pods onto the same node. The value "" will disable pod anti-affinity so that no anti-affinity rules will be configured. | `""` |
| `prometheus.prometheusSpec.tolerations` | If specified, the pod's tolerations. | `[]` |
@@ -196,12 +196,12 @@ alertmanager:
## Define which Nodes the Pods are scheduled on.
## ref: https://kubernetes.io/docs/user-guide/node-selection/
##
nodeSelector: []
nodeSelector: {}
## Define resources requests and limits for single Pods.
## ref: https://kubernetes.io/docs/user-guide/compute-resources/
##
resources:
resources: {}
# requests:
# memory: 400Mi
@@ -476,12 +476,12 @@ prometheusOperator:
## Define which Nodes the Pods are scheduled on.
## ref: https://kubernetes.io/docs/user-guide/node-selection/
##
nodeSelector: []
nodeSelector: {}
## Tolerations for use with node taints
## ref: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
##
tolerations: {}
tolerations: []
# - key: "key"
# operator: "Equal"
# value: "value"
@@ -608,7 +608,7 @@ prometheus:
## Tolerations for use with node taints
## ref: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
##
tolerations: {}
tolerations: []
# - key: "key"
# operator: "Equal"
# value: "value"
@@ -636,7 +636,7 @@ prometheus:
## Define which Nodes the Pods are scheduled on.
## ref: https://kubernetes.io/docs/user-guide/node-selection/
##
nodeSelector: []
nodeSelector: {}
## Secrets is a list of Secrets in the same namespace as the Prometheus object, which shall be mounted into the Prometheus Pods.
## The Secrets are mounted into /etc/prometheus/secrets/. Secrets changes after initial creation of a Prometheus object are not
+6 -6
View File
@@ -200,12 +200,12 @@ alertmanager:
## Define which Nodes the Pods are scheduled on.
## ref: https://kubernetes.io/docs/user-guide/node-selection/
##
nodeSelector: []
nodeSelector: {}
## Define resources requests and limits for single Pods.
## ref: https://kubernetes.io/docs/user-guide/compute-resources/
##
resources:
resources: {}
# requests:
# memory: 400Mi
@@ -480,12 +480,12 @@ prometheusOperator:
## Define which Nodes the Pods are scheduled on.
## ref: https://kubernetes.io/docs/user-guide/node-selection/
##
nodeSelector: []
nodeSelector: {}
## Tolerations for use with node taints
## ref: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
##
tolerations: {}
tolerations: []
# - key: "key"
# operator: "Equal"
# value: "value"
@@ -612,7 +612,7 @@ prometheus:
## Tolerations for use with node taints
## ref: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
##
tolerations: {}
tolerations: []
# - key: "key"
# operator: "Equal"
# value: "value"
@@ -640,7 +640,7 @@ prometheus:
## Define which Nodes the Pods are scheduled on.
## ref: https://kubernetes.io/docs/user-guide/node-selection/
##
nodeSelector: []
nodeSelector: {}
## Secrets is a list of Secrets in the same namespace as the Prometheus object, which shall be mounted into the Prometheus Pods.
## The Secrets are mounted into /etc/prometheus/secrets/. Secrets changes after initial creation of a Prometheus object are not