[stable/gocd] Deprecate agent.env.agentAutoRegisterEnvironemnts in favour of agent.env.agentAutoRegisterEnvironments (#9420) (#10402)

* [stable/gocd] Deprecate agent.env.agentAutoRegisterEnvironemnts in favour of agent.env.agentAutoRegisterEnvironments (#9420)

Signed-off-by: Varsha Varadarajan <varshasvaradarajan@gmail.com>

* [stable/gocd] Update changelog, update deprecation message

Signed-off-by: Varsha Varadarajan <varshasvaradarajan@gmail.com>
This commit is contained in:
Varsha Varadarajan
2019-01-08 12:41:19 -08:00
committed by Kubernetes Prow Robot
parent 6b6355ae73
commit e6bb60fcc6
6 changed files with 22 additions and 3 deletions
+7
View File
@@ -1,3 +1,10 @@
### 1.6.2
* [fe985d7](https://github.com/kubernetes/charts/commit/fe985d7):
- Deprecate agent.env.agentAutoRegisterEnvironemnts in favour of agent.env.agentAutoRegisterEnvironments.
*Please note that the deprecated property will be removed in GoCD 19.3.0 (that is, when Chart.appVersion is 19.3.0). Users are encouraged to use the new property `agent.env.agentAutoRegisterEnvironments`.*
### 1.6.1
* [28d5416](https://github.com/kubernetes/charts/commit/28d5416):
+1 -1
View File
@@ -1,6 +1,6 @@
name: gocd
home: https://www.gocd.org/
version: 1.6.1
version: 1.6.2
appVersion: 18.12.0
description: GoCD is an open-source continuous delivery server to model and visualize complex workflows with ease.
icon: https://gocd.github.io/assets/images/go-icon-black-192x192.png
+1 -1
View File
@@ -171,7 +171,7 @@ $ kubectl create secret generic gocd-server-ssh \
| `agent.env.goServerUrl` | GoCD Server Url. If nil, discovers the GoCD server service if its available on the Kubernetes cluster | `nil` |
| `agent.env.agentAutoRegisterKey` | GoCD Agent autoregister key | `nil` |
| `agent.env.agentAutoRegisterResources` | Comma separated list of GoCD Agent resources | `nil` |
| `agent.env.agentAutoRegisterEnvironemnts` | Comma separated list of GoCD Agent environments | `nil` |
| `agent.env.agentAutoRegisterEnvironments` | Comma separated list of GoCD Agent environments | `nil` |
| `agent.env.agentAutoRegisterHostname` | GoCD Agent hostname | `nil` |
| `agent.env.goAgentBootstrapperArgs` | GoCD Agent Bootstrapper Args. It can be used to [Configure end-to-end transport security](https://docs.gocd.org/current/installation/ssl_tls/end_to_end_transport_security.html) | `nil` |
| `agent.env.goAgentBootstrapperJvmArgs` | GoCD Agent Bootstrapper JVM Args. | `nil` |
+6
View File
@@ -61,3 +61,9 @@
WARNING: Persistence is disabled. You will lose all data at the time of pod termination!
################################################################################################
{{ end }}
{{- if .Values.agent.env.agentAutoRegisterEnvironemnts -}}
6. Deprecations
The property `agent.env.agentAutoRegisterEnvironemnts` is deprecated in favor of `agent.env.agentAutoRegisterEnvironments`.
Please note that the deprecated property will be removed in GoCD 19.3.0 (that is, when Chart.appVersion is 19.3.0). Users are encouraged to use the new property `agent.env.agentAutoRegisterEnvironments`.
{{ end }}
@@ -73,7 +73,10 @@ spec:
- name: AGENT_AUTO_REGISTER_RESOURCES
value: {{ .Values.agent.env.agentAutoRegisterResources }}
{{- end }}
{{- if .Values.agent.env.agentAutoRegisterEnvironemnts }}
{{- if .Values.agent.env.agentAutoRegisterEnvironments }}
- name: AGENT_AUTO_REGISTER_ENVIRONMENTS
value: {{ .Values.agent.env.agentAutoRegisterEnvironments }}
{{- else if .Values.agent.env.agentAutoRegisterEnvironemnts }}
- name: AGENT_AUTO_REGISTER_ENVIRONMENTS
value: {{ .Values.agent.env.agentAutoRegisterEnvironemnts }}
{{- end }}
+3
View File
@@ -217,7 +217,10 @@ agent:
# agent.env.agentAutoRegisterResources is the GoCD Agent auto-register resources
agentAutoRegisterResources:
# agent.env.agentAutoRegisterEnvironments is the GoCD Agent auto-register Environments
# deprecated because of a typo. Use agent.env.agentAutoRegisterEnvironments instead
agentAutoRegisterEnvironemnts:
# agent.env.agentAutoRegisterEnvironments is the GoCD Agent auto-register Environments
agentAutoRegisterEnvironments:
# agent.env.agentAutoRegisterHostname is the GoCD Agent auto-register hostname
agentAutoRegisterHostname:
# agent.env.goAgentSystemProperties is the GoCD Agent system properties