Replace hardcoded port 10254 with variable. This allows to run multiple (#18555)

controllers without port conflicts

Signed-off-by: Andrea Defraia <andrea.defraia@idemia.com>

stable/nginx-ingress/Chart.yaml

@@ -1,6 +1,6 @@
 apiVersion: v1
 name: nginx-ingress
-version: 1.24.5
+version: 1.24.6
 appVersion: 0.26.1
 home: https://github.com/kubernetes/ingress-nginx
 description: An nginx Ingress controller that uses ConfigMap to store the nginx configuration.

stable/nginx-ingress/templates/controller-daemonset.yaml

@@ -140,7 +140,7 @@ spec:
           {{- end }}
           {{- if .Values.controller.metrics.enabled }}
             - name: metrics
-              containerPort: 10254
+              containerPort: {{ .Values.controller.metrics.port }}
               protocol: TCP
           {{- end }}
           {{- if .Values.controller.admissionWebhooks.enabled }}

stable/nginx-ingress/templates/controller-deployment.yaml

@@ -136,7 +136,7 @@ spec:
           {{- end }}
           {{- if .Values.controller.metrics.enabled }}
             - name: metrics
-              containerPort: 10254
+              containerPort: {{ .Values.controller.metrics.port }}
               protocol: TCP
           {{- end }}
           {{- if .Values.controller.admissionWebhooks.enabled }}

stable/nginx-ingress/values.yaml

@@ -338,6 +338,8 @@ controller:
       nodeSelector: {}
 
   metrics:
+    port: 10254
+    # if this port is changed, change healthz-port: in extraArgs: accordingly
     enabled: false
 
     service: