github/deprecated-helm-charts
1
0
Fork 0
mirror of https://github.com/helm/charts.git synced 2026-08-23 22:37:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

[stable/external-dns] Remove Google key validation (#15299)

Browse Source 
When installing the chart in Google Cloud Platform the service account
can be fetched from metadata service. This commit removes validation
function which fails helm install when service account key or secret
are not explicitly configured.

Fixes #15298

Signed-off-by: Stanislav Blokhin <stanislav.blokhin@tomologic.com>
This commit is contained in:
Stanislav B
2019-07-08 08:08:36 -07:00
committed by Kubernetes Prow Robot
parent 399c74aca0
commit e52b818525
2 changed files with 1 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stable/external-dns/Chart.yaml
+1 -1
View File
@@ -1,6 +1,6 @@
apiVersion: v1
name: external-dns
version: 2.1.0
version: 2.1.1
appVersion: 0.5.15
description: ExternalDNS is a Kubernetes addon that configures public DNS servers with information about exposed Kubernetes services to make them discoverable.
keywords:
stable/external-dns/templates/_helpers.tpl
-14
View File
@@ -128,7 +128,6 @@ Compile all warnings into a single message, and call fail.
{{- $messages := append $messages (include "external-dns.validateValues.provider" .) -}}
{{- $messages := append $messages (include "external-dns.validateValues.sources" .) -}}
{{- $messages := append $messages (include "external-dns.validateValues.aws" .) -}}
{{- $messages := append $messages (include "external-dns.validateValues.google" .) -}}
{{- $messages := append $messages (include "external-dns.validateValues.infoblox.gridHost" .) -}}
{{- $messages := append $messages (include "external-dns.validateValues.infoblox.wapiPassword" .) -}}
{{- $messages := without $messages "" -}}
@@ -178,19 +177,6 @@ external-dns: aws.assumeRoleArn
{{- end -}}
{{- end -}}
{{/*
Validate values of External DNS:
- must provide a service account key when provider is "google"
*/}}
{{- define "external-dns.validateValues.google" -}}
{{- if and (eq .Values.provider "google") (not .Values.google.serviceAccountSecret) (not .Values.google.serviceAccountKey) -}}
external-dns: google.serviceAccountKey google.serviceAccountSecret
You must provide the service account key when provider="google".
Please set the service account key (--set google.serviceAccountKey="xxxx")
or reuse an existing secret (--set google.serviceAccountSecret="xxxx")
{{- end -}}
{{- end -}}
{{/*
Validate values of External DNS:
- must provide the Grid Manager host when provider is "infoblox"