[stable/external-dns] fix extraEnv (#15900)

Signed-off-by: Bagrat Lazaryan <bagratte@live.com>

stable/external-dns/Chart.yaml

@@ -1,6 +1,6 @@
 apiVersion: v1
 name: external-dns
-version: 2.4.0
+version: 2.4.1
 appVersion: 0.5.15
 description: ExternalDNS is a Kubernetes addon that configures public DNS servers with information about exposed Kubernetes services to make them discoverable.
 keywords:

stable/external-dns/templates/deployment.yaml

@@ -254,17 +254,8 @@ spec:
               key: pdns_api_key
         {{- end }}
         # Extra environment variables
-        {{- $root := . -}}
-        {{- range .Values.extraEnv }}
-        - name: {{ .name }}
-          valueFrom:
-            {{- if .valueFrom }}
-{{ toYaml .valueFrom | indent 12 }}
-            {{- else }}
-            secretKeyRef:
-              name: {{ template "external-dns.fullname" $root }}
-              key: {{ .name }}
-            {{- end }}
+        {{- if .Values.extraEnv }}
+        {{ toYaml .Values.extraEnv | nindent 8 }}
         {{- end }}
         ports:
         - name: http

stable/external-dns/templates/secret.yaml

@@ -33,7 +33,4 @@ data:
   {{- if .Values.pdns.apiKey }}
   pdns_api_key: {{ .Values.pdns.apiKey | b64enc | quote }}
   {{- end }}
-  {{- range $key, $value := .Values.extraEnv }}
-  {{ $key }}: {{ $value | b64enc | quote }}
-  {{- end }}
 {{- end }}

stable/external-dns/values-production.yaml

@@ -209,9 +209,17 @@ istioIngressGateways: []
 ## Extra Arguments to passed to external-dns
 ##
 extraArgs: {}
-## Extra env. variable to set on external-dns container
+## Extra env. variable to set on external-dns container.
 ##
-extraEnv: {}
+## extraEnv:
+## - name: VARNAME1
+##   value: value1
+## - name: VARNAME2
+##   valueFrom:
+##     secretKeyRef:
+##       name: existing-secret
+##       key: varname2-key
+extraEnv: []
 
 ## Replica count
 ##

stable/external-dns/values.yaml

@@ -209,9 +209,17 @@ istioIngressGateways: []
 ## Extra Arguments to passed to external-dns
 ##
 extraArgs: {}
-## Extra env. variable to set on external-dns container
+## Extra env. variable to set on external-dns container.
 ##
-extraEnv: {}
+## extraEnv:
+## - name: VARNAME1
+##   value: value1
+## - name: VARNAME2
+##   valueFrom:
+##     secretKeyRef:
+##       name: existing-secret
+##       key: varname2-key
+extraEnv: []
 
 ## Replica count
 ##