github/deprecated-helm-charts
1
0
Fork 0
mirror of https://github.com/helm/charts.git synced 2026-08-23 22:37:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

[stable/dokuwiki] bump major version (#18691)

Browse Source 
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec.

In https://github.com/helm/charts/pull/17294 the `apiVersion` of the deployment resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage.

This major version bump signifies this change.

Signed-off-by: Sameer Naik <sameersbn@vmware.com>
This commit is contained in:
Sameer Naik
2019-11-11 07:43:42 -08:00
committed by Kubernetes Prow Robot
parent 17e7dcbb5b
commit c780e7e3bb
4 changed files with 21 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
stable/dokuwiki/Chart.yaml
+1 -1
View File
@@ -1,6 +1,6 @@
apiVersion: v1
name: dokuwiki
version: 5.2.12
version: 6.0.0
appVersion: 0.20180422.201901061035
description: DokuWiki is a standards-compliant, simple to use wiki optimized for creating
documentation. It is targeted at developer teams, workgroups, and small companies.
stable/dokuwiki/README.md
+8
View File
@@ -149,6 +149,14 @@ See the [Parameters](#parameters) section to configure the PVC or to disable per
## Upgrading
### To 6.0.0
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec.
In https://github.com/helm/charts/pull/17294 the `apiVersion` of the deployment resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage.
This major version signifies this change.
### To 3.0.0
Backwards compatibility is not guaranteed unless you modify the labels used on the chart's deployments.
stable/dokuwiki/templates/_helpers.tpl
+11
View File
@@ -145,3 +145,14 @@ but Helm 2.9 and 2.10 does not support it, so we need to implement this if-else
{{- end -}}
{{- end -}}
{{- end -}}
{{/*
Return the appropriate apiVersion for deployment.
*/}}
{{- define "dokuwiki.deployment.apiVersion" -}}
{{- if semverCompare "<1.14-0" .Capabilities.KubeVersion.GitVersion -}}
{{- print "extensions/v1beta1" -}}
{{- else -}}
{{- print "apps/v1" -}}
{{- end -}}
{{- end -}}
stable/dokuwiki/templates/deployment.yaml
+1 -1
View File
@@ -1,4 +1,4 @@
apiVersion: apps/v1
apiVersion: {{ template "dokuwiki.deployment.apiVersion" . }}
kind: Deployment
metadata:
name: {{ template "dokuwiki.fullname" . }}