Fixes regression of functionality that allows for extra volumes and mounts regardless of whether persistence and ssh is enabled (#10541)

* Fixes the regression of the functionality that allows volumes and volume mounts regardless of whether persistence or ssh are enabled.

Signed-off-by: Sheroy Marker <smarker@thoughtworks.com>

* Updates the changelog.

Signed-off-by: Sheroy Marker <smarker@thoughtworks.com>

stable/gocd/CHANGELOG.md

@@ -1,3 +1,8 @@
+### 1.6.3
+
+* [bca4092f](https://github.com/kubernetes/charts/commit/bca4092f):
+  - Fixes regression of functionality that allows for extra volumes and mounts regardless of whether persistence and ssh is enabled
+
 ### 1.6.2
 
 * [fe985d7](https://github.com/kubernetes/charts/commit/fe985d7):

stable/gocd/Chart.yaml

@@ -1,6 +1,6 @@
 name: gocd
 home: https://www.gocd.org/
-version: 1.6.2
+version: 1.6.3
 appVersion: 18.12.0
 description: GoCD is an open-source continuous delivery server to model and visualize complex workflows with ease.
 icon: https://gocd.github.io/assets/images/go-icon-black-192x192.png

stable/gocd/templates/gocd-agent-deployment.yaml

@@ -27,7 +27,7 @@ spec:
         component: agent
     spec:
       serviceAccountName: {{ template "gocd.agentServiceAccountName" . }}
-      {{- if or .Values.agent.persistence.enabled .Values.agent.security.ssh.enabled }}
+      {{- if or .Values.agent.persistence.enabled (or .Values.agent.security.ssh.enabled .Values.agent.persistence.extraVolumes) }}
       volumes:
       {{- end }}
       {{- if .Values.agent.persistence.enabled }}