[stable/concourse] Make values.yaml more consistent; uncomments fields (#11296)

The `values.yaml` for `stable/concourse` didn't look much consistent,
having some values with totally different commenting formats compared
to others.

This commit also improves the documentation around some of those values
that are not very easy to infer what they're all about.

By making the values uncommented we can leverage tools that parse yaml
files to make sure we have all variables documented.

He we also remove an unused debug values file and fix few values check.

With the use of default values under `values.yaml` as opposed to
commented fields, few values (like default `storageClass`) needed to be
updated, as well as adding few checks.

Also, Previously we allowed the creation of objects that wouldn't pass
`kubeval`'s validation. Now `kubeval` is ok with all of our objects.

Signed-off-by: Ciro S. Costa <cscosta@pivotal.io>

stable/concourse/Chart.yaml

@@ -1,5 +1,5 @@
 name: concourse
-version: 3.7.4
+version: 3.7.5
 appVersion: 4.2.2
 description: Concourse is a simple and scalable CI system.
 icon: https://avatars1.githubusercontent.com/u/7809479

stable/concourse/more-config.yaml

@@ -1,8 +0,0 @@
-web:
-  additionalVolumes:
-  - name: team-authorized-keys
-    configMap:
-      name: hush-house-team-authorized-keys
-  additionalVolumeMounts:
-  - name: team-authorized-keys
-    mountPath: /team-authorized-keys/

stable/concourse/templates/NOTES.txt

@@ -35,19 +35,21 @@
   {{- end }}
 * If this is your first time using Concourse, follow the tutorials at https://concourse-ci.org/tutorials.html
 
+{{- if .Values.concourse.worker.baggageclaim.driver }}
 {{- if contains "naive" .Values.concourse.worker.baggageclaim.driver }}
 
 *******************
 ******WARNING******
 *******************
 
-You are using the "naive" baggage claim driver, which is also the default value for this chart. 
+You are using the "naive" baggage claim driver, which is also the default value for this chart.
 
-This is the default for compatibility reasons, but is very space inefficient, and should be changed to either "btrfs" (recommended) or "overlay" depending on that filesystem's support in the Linux kernel your cluster is using. 
+This is the default for compatibility reasons, but is very space inefficient, and should be changed to either "btrfs" (recommended) or "overlay" depending on that filesystem's support in the Linux kernel your cluster is using.
 
 Please see https://github.com/concourse/concourse/issues/1230 and https://github.com/concourse/concourse/issues/1966 for background.
 
 {{- end }}
+{{- end }}
 
 
 

stable/concourse/templates/web-deployment.yaml

@@ -14,16 +14,20 @@ spec:
       labels:
         app: {{ template "concourse.web.fullname" . }}
         release: "{{ .Release.Name }}"
+      {{- if .Values.web.annotations }}
       annotations:
 {{ toYaml .Values.web.annotations | indent 8 }}
+      {{- end }}
     spec:
     {{- with .Values.web.nodeSelector }}
       nodeSelector:
 {{ toYaml . | indent 8 }}
     {{- end }}
       serviceAccountName: {{ if .Values.rbac.create }}{{ template "concourse.web.fullname" . }}{{ else }}{{ .Values.rbac.webServiceAccountName }}{{ end }}
+      {{- if .Values.web.tolerations }}
       tolerations:
 {{ toYaml .Values.web.tolerations | indent 8 }}
+      {{- end }}
       {{- if .Values.imagePullSecrets }}
       imagePullSecrets:
       {{- range .Values.imagePullSecrets }}
@@ -932,10 +936,12 @@ spec:
 {{- if .Values.web.additionalVolumeMounts }}
 {{ toYaml .Values.web.additionalVolumeMounts | indent 12 }}
 {{- end }}
+      {{- if .Values.web.additionalAffinities }}
       affinity:
 {{- if .Values.web.additionalAffinities }}
 {{ toYaml .Values.web.additionalAffinities | indent 8 }}
 {{- end }}
+      {{- end }}
       volumes:
 {{- if .Values.web.additionalVolumes }}
 {{ toYaml .Values.web.additionalVolumes | indent 8 }}

stable/concourse/templates/web-svc.yaml

@@ -10,6 +10,7 @@ metadata:
     {{- range $key, $value := .Values.web.service.labels }}
     {{ $key }}: {{ $value | quote }}
     {{- end }}
+  {{- if or .Values.web.service.annotations .Values.concourse.web.prometheus.enabled }}
   annotations:
     {{- range $key, $value := .Values.web.service.annotations }}
     {{ $key }}: {{ $value | quote }}
@@ -18,6 +19,7 @@ metadata:
     prometheus.io/scrape: "true"
     prometheus.io/port: {{ .Values.concourse.web.prometheus.bindPort | quote }}
     {{- end }}
+  {{- end }}
 spec:
   type: {{ .Values.web.service.type }}
   {{ if .Values.web.service.loadBalancerSourceRanges }}

stable/concourse/templates/worker-statefulset.yaml

@@ -16,18 +16,22 @@ spec:
       labels:
         app: {{ template "concourse.worker.fullname" . }}
         release: "{{ .Release.Name }}"
+      {{- if .Values.worker.annotations }}
       annotations:
-        {{- range $key, $value := .Values.worker.annotations }}
+      {{- range $key, $value := .Values.worker.annotations }}
         {{ $key }}: {{ $value | quote }}
-        {{- end }}
+      {{- end }}
+      {{- end }}
     spec:
     {{- with .Values.worker.nodeSelector }}
       nodeSelector:
 {{ toYaml . | indent 8 }}
     {{- end }}
       serviceAccountName: {{ if .Values.rbac.create }}{{ template "concourse.worker.fullname" . }}{{ else }}{{ .Values.rbac.workerServiceAccountName }}{{ end }}
+      {{- if .Values.worker.tolerations }}
       tolerations:
 {{ toYaml .Values.worker.tolerations | indent 8 }}
+      {{- end }}
       {{- if .Values.imagePullSecrets }}
       imagePullSecrets:
       {{- range .Values.imagePullSecrets }}