Nkrause/amb (#12426)

* Restore default replicas == 3

Signed-off-by: Flynn <flynn@datawire.io>

* Fix some markdown

Signed-off-by: Flynn <flynn@datawire.io>

* Bump chart version, and switch my name to Flynn. :)

Signed-off-by: Flynn <flynn@datawire.io>

* Add icon.

Signed-off-by: Flynn <flynn@datawire.io>

* Sort OWNERS, and add nbkrause (from Datawire)

Signed-off-by: Flynn <flynn@datawire.io>

* Heh. Didn't realize a change to OWNERS required a version bump.

Signed-off-by: Flynn <flynn@datawire.io>

* Bump to Ambassador 0.50.2.

Signed-off-by: Flynn <flynn@datawire.io>

* Bump Ambassador to version 0.50.3.

Signed-off-by: Flynn <flynn@datawire.io>

* Augh. Fix Ambassador versions in values.yaml and README.

Signed-off-by: Flynn <flynn@datawire.io>

* Update chart maintainers per PR comments

Signed-off-by: Flynn <flynn@datawire.io>

* Support SINGLE_NAMESPACE and do not set ambassador.id by default

Signed-off-by: Noah Krause <krausenoah@gmail.com>

* Bump chart version

Signed-off-by: Noah Krause <krausenoah@gmail.com>

* Remove namespace.single from values file since it is no longer configured that way

Signed-off-by: Noah Krause <krausenoah@gmail.com>

* Move `AMBASSADOR_ID` configuration in environment varible in `env`

Signed-off-by: Noah Krause <krausenoah@gmail.com>

* Add message to env in values

Signed-off-by: Noah Krause <krausenoah@gmail.com>

* Update values.yaml

Signed-off-by: Noah Krause <krausenoah@gmail.com>

* Add section to upgrading to chart v2.0.0

Signed-off-by: Noah Krause <krausenoah@gmail.com>
This commit is contained in:
nbkrause
2019-03-21 08:39:37 -07:00
committed by Kubernetes Prow Robot
parent 9d97716476
commit b7f4e8e17a
4 changed files with 17 additions and 12 deletions
+2 -2
View File
@@ -1,8 +1,8 @@
apiVersion: v1
appVersion: 0.50.3
appVersion: 0.51.2
description: A Helm chart for Datawire Ambassador
name: ambassador
version: 1.1.5
version: 2.0.0
icon: https://www.getambassador.io/images/logo.png
home: https://www.getambassador.io/
sources:
+10 -1
View File
@@ -47,7 +47,6 @@ The following tables lists the configurable parameters of the Ambassador chart a
| `adminService.create` | If `true`, create a service for Ambassador's admin UI | `true` |
| `adminService.nodePort` | If explicit NodePort for admin service is required | `true` |
| `adminService.type` | Ambassador's admin service type to be used | `ClusterIP` |
| `ambassador.id` | Set the identifier of the Ambassador instance | `default` |
| `ambassadorConfig` | Config thats mounted to `/ambassador/ambassador-config` | `""` |
| `daemonSet` | If `true`, Create a daemonSet. By default Deployment controller will be created | `false` |
| `env` | Any additional environment variables for ambassador pods | `{}` |
@@ -128,6 +127,16 @@ $ helm upgrade --install --wait my-release -f values.yaml stable/ambassador
# Upgrading
## To 2.0.0
### Ambassador ID
ambassador.id has been removed in favor of setting it via an environment variable in `env`. `AMBASSADOR_ID` defaults to `default` if not set in the environment. This is mainly used for [running multiple Ambassadors](https://www.getambassador.io/reference/running#ambassador_id) in the same cluster.
| Parameter | Env variables |
| --------------- | --------------- |
| `ambassador.id` | `AMBASSADOR_ID` |
## Migrating from `datawire/ambassador` chart (chart version 0.40.0 or 0.50.0)
Chart now runs ambassador as non-root by default, so you might need to update your ambassador module config to match this.
+1 -3
View File
@@ -95,10 +95,8 @@ spec:
- name: STATSD_HOST
value: "localhost"
{{- end }}
- name: AMBASSADOR_ID
value: {{ .Values.ambassador.id | quote }}
- name: AMBASSADOR_NAMESPACE
{{- if .Values.namespace.name }}
{{- if .Values.namespace }}
value: {{ .Values.namespace.name | quote }}
{{ else }}
valueFrom:
+4 -6
View File
@@ -5,11 +5,7 @@
replicaCount: 3
daemonSet: false
ambassador:
id: default
namespace:
single: false
# namespace:
# name: default
# Additional container environment variable
@@ -24,8 +20,10 @@ env:
# AMBASSADOR_DRAIN_TIME: 5
# sets the number of seconds that Ambassador will wait for the old Envoy to clean up and exit on a restart
# AMBASSADOR_SHUTDOWN_TIME: 10
# sets the number of seconds that Ambassador will wait for the old Envoy to clean up and exit on a restart
# tells Ambassador to only use resources in the namespace set by namespace.name
# AMBASSADOR_SINGLE_NAMESPACE: true
# labels Ambassador with an ID to allow for configuring multiple Ambassadors in a cluster
# AMBASSADOR_ID: default
imagePullSecrets: []