[stable/mysqldump] added axdotl to OWNERS / made persistentVolumeReclaimPolicy configurable (#10933)

* added axdotl to maintainers and OWNERS file

Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>

* made persistentVolumeReclaimPolicy configurable

Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>

* fixed mysqldump warning and gsutil rsync argument

Signed-off-by: André Bauer <monotek23@gmail.com>
This commit is contained in:
André Bauer
2019-01-29 07:47:51 -08:00
committed by Kubernetes Prow Robot
parent faddc35217
commit aa680b2605
6 changed files with 12 additions and 5 deletions
+4 -2
View File
@@ -1,8 +1,8 @@
apiVersion: v1
appVersion: 2.2.0
appVersion: 2.3.0
description: A Helm chart to help backup MySQL databases using mysqldump
name: mysqldump
version: 2.2.0
version: 2.3.0
keywords:
- mysql
- mysqldump
@@ -17,3 +17,5 @@ maintainers:
email: username.taken@gmail.com
- name: monotek
email: monotek23@gmail.com
- name: axdotl
email: axel.koehler@kiwigrid.com
+2
View File
@@ -1,6 +1,8 @@
approvers:
- paulczar
- monotek
- axdotl
reviewers:
- paulczar
- monotek
- axdotl
+1
View File
@@ -64,6 +64,7 @@ The following tables lists the configurable parameters of the mysqldump chart an
| persistence.size | size of PVC to create | 8Gi |
| persistence.accessMode | accessMode to use for PVC | ReadWriteOnce |
| persistence.storageClass | storage class to use for PVC | |
| persistence.reclaimPolicy | used PV reclaim policy | "delete" |
| persistence.subPath | subPath for PVC | |
| allDatabases.enabled | backup all databases | true |
| allDatabases.SingleSqlFile | backup all databases to singel file | false |
+3 -3
View File
@@ -54,13 +54,13 @@ data:
MYSQL_DB="{{ .Values.mysql.db }}"
echo "Backing up single db ${MYSQL_DB}"
{{ if .Values.saveToDirectory }}mkdir -p "${BACKUP_DIR}"/"${MYSQL_DB}"{{ end }}
mysqldump ${MYSQL_OPTS} -h ${MYSQL_HOST} -P ${MYSQL_PORT} -u ${MYSQL_USERNAME}{{ if .Values.mysql.password }} -p${MYSQL_PASSWORD}{{ end }} --database ${MYSQL_DB} | gzip > ${BACKUP_DIR}/{{ if .Values.saveToDirectory }}${MYSQL_DB}/{{ end }}${TIMESTAMP}_${MYSQL_DB}.sql.gz
mysqldump ${MYSQL_OPTS} -h ${MYSQL_HOST} -P ${MYSQL_PORT} -u ${MYSQL_USERNAME}{{ if .Values.mysql.password }} -p${MYSQL_PASSWORD}{{ end }} --databases ${MYSQL_DB} | gzip > ${BACKUP_DIR}/{{ if .Values.saveToDirectory }}${MYSQL_DB}/{{ end }}${TIMESTAMP}_${MYSQL_DB}.sql.gz
{{ else if and (.Values.allDatabases.enabled) (eq .Values.allDatabases.singleBackupFile false)}}
for MYSQL_DB in $(mysql -h "${MYSQL_HOST}" -u ${MYSQL_USERNAME}{{ if .Values.mysql.password }} -p${MYSQL_PASSWORD}{{ end }} -B -N -e "SHOW DATABASES;"|egrep -v '^(information|performance)_schema$'); do
echo "Backing up db ${MYSQL_DB}"
{{ if .Values.saveToDirectory }}mkdir -p "${BACKUP_DIR}"/"${MYSQL_DB}"{{ end }}
mysqldump ${MYSQL_OPTS} -h ${MYSQL_HOST} -u ${MYSQL_USERNAME}{{ if .Values.mysql.password }} -p${MYSQL_PASSWORD}{{ end }} --database ${MYSQL_DB} | gzip > ${BACKUP_DIR}/{{ if .Values.saveToDirectory }}${MYSQL_DB}/{{ end }}${TIMESTAMP}_${MYSQL_DB}.sql.gz
mysqldump ${MYSQL_OPTS} -h ${MYSQL_HOST} -u ${MYSQL_USERNAME}{{ if .Values.mysql.password }} -p${MYSQL_PASSWORD}{{ end }} --databases ${MYSQL_DB} | gzip > ${BACKUP_DIR}/{{ if .Values.saveToDirectory }}${MYSQL_DB}/{{ end }}${TIMESTAMP}_${MYSQL_DB}.sql.gz
rc=$?
done
@@ -82,7 +82,7 @@ data:
{{ if .Values.upload.googlestoragebucket.enabled }}
echo "upload files to google storage bucket {{ .Values.upload.googlestoragebucket.bucketname }}"
gcloud auth activate-service-account --key-file /root/gcloud/{{ .Values.upload.googlestoragebucket.secretFileName }}
gsutil -r -m rsync -x '.*\.state' -d ${BACKUP_DIR}/ {{ .Values.upload.googlestoragebucket.bucketname }}
gsutil -m rsync -r -x '.*\.state' -d ${BACKUP_DIR}/ {{ .Values.upload.googlestoragebucket.bucketname }}
rcu=$?
{{ end }}
+1
View File
@@ -21,5 +21,6 @@ spec:
resources:
requests:
storage: {{ .Values.persistence.size }}
persistentVolumeReclaimPolicy: {{ .Values.persistence.reclaimPolicy }}
{{- end -}}
{{- end -}}
+1
View File
@@ -49,6 +49,7 @@ persistence:
enabled: true
size: 8Gi
accessMode: ReadWriteOnce
reclaimPolicy: delete
subPath:
## If defined, storageClassName: <storageClass>
## If set to "-", storageClassName: "", which disables dynamic provisioning