Add MSSQL Master DB persistence (#4701)

* Add MSSQL Master DB persistence

* update version

* enable persistence by default

* following persistence best practise

* formatting

stable/mssql-linux/Chart.yaml

@@ -1,7 +1,7 @@
 apiVersion: v1
 description: SQL Server 2017 Linux Helm Chart
 name: mssql-linux
-version: 0.2.0
+version: 0.3.0
 appVersion: 14.0.3023.8
 home: https://hub.docker.com/r/microsoft/mssql-server-linux/
 icon: https://img-prod-cms-rt-microsoft-com.akamaized.net/cms/api/am/imageFileData/RE1I4Dx

stable/mssql-linux/templates/deployment.yaml

@@ -41,6 +41,10 @@ spec:
               value: "{{ .Values.service.port }}"
             - name: MSSQL_BACKUP_DIR
               value: "/mssql-backup/backup"
+            - name: MSSQL_MASTER_DATA_FILE
+              value: /mssql-data/master/master.mdf
+            - name: MSSQL_MASTER_LOG_FILE
+              value: /mssql-data/master/mastlog.ldf
           ports:
             - name: mssql
               containerPort: {{ .Values.service.port }}
@@ -51,6 +55,8 @@ spec:
               mountPath: /mssql-translog/translog
             - name: backup
               mountPath: /mssql-backup/backup
+            - name: master
+              mountPath: /mssql-data/master
           livenessProbe:
              tcpSocket:
                port: mssql
@@ -101,3 +107,14 @@ spec:
       {{- else }}
         emptyDir: {}
       {{- end }}
+      - name: master
+      {{- if .Values.persistence.enabled }}
+        persistentVolumeClaim:
+          {{- if .Values.persistence.existingMasterClaim }}
+          claimName: {{ .Values.persistence.existingMasterClaim }}
+          {{- else }}
+          claimName: {{ template "mssql.fullname" . }}-master
+          {{- end }}
+      {{- else }}
+        emptyDir: {}
+      {{- end }}

stable/mssql-linux/templates/pvc-master.yaml

@@ -0,0 +1,28 @@
+{{- if and .Values.persistence.enabled (not .Values.persistence.existingMasterClaim) }}
+kind: PersistentVolumeClaim
+apiVersion: v1
+metadata:
+  name: {{ template "mssql.fullname" . }}-master
+  labels:
+    app: {{ template "mssql.fullname" . }}
+    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+    release: "{{ .Release.Name }}"
+    heritage: "{{ .Release.Service }}"
+{{- if .Values.persistence.annotations }}
+  annotations:
+{{ toYaml .Values.persistence.annotations | indent 4 }}
+{{- end }}
+spec:
+  accessModes:
+    - {{ .Values.persistence.masterAccessMode | quote }}
+  resources:
+    requests:
+      storage: {{ .Values.persistence.masterSize | quote }}
+{{- if .Values.persistence.storageClass }}
+{{- if (eq "-" .Values.persistence.storageClass) }}
+  storageClassName: ""
+{{- else }}
+  storageClassName: "{{ .Values.persistence.storageClass }}"
+{{- end }}
+{{- end }}
+{{- end -}}

stable/mssql-linux/values.yaml

@@ -12,17 +12,20 @@ service:
   type: ClusterIP
   port: 1433
 persistence:
-  enabled: false
+  enabled: true
   # existingDataClaim:
   # existingTransactionLogClaim:
   # existingBackupClaim:
-  # storageClass: "-"
+  # existingMasterClaim:
+  storageClass: ""
   dataAccessMode: ReadWriteOnce
   dataSize: 1Gi
   transactionLogAccessMode: ReadWriteOnce
   transactionLogSize: 1Gi
   backupAccessMode: ReadWriteOnce
   backupSize: 1Gi
+  masterAccessMode: ReadWriteOnce
+  masterSize: 1Gi
 livenessprobe:
   initialDelaySeconds: 15
   periodSeconds: 20