[stable/openvpn] Add option to remove dhcp-option DOMAIN (#5404)

* [stable/openvpn] Add option to remove `dhcp-option DOMAIN`

Not all VPN clients support this option, so having the option to remove
it can prevent errors on client connections.

* Update Chart.yaml

stable/openvpn/Chart.yaml

@@ -3,7 +3,7 @@ description: A Helm chart to install an openvpn server inside a kubernetes clust
   generation is also part of the deployment, and this chart will generate client keys
   as needed.
 name: openvpn
-version: 3.1.0
+version: 3.2.0
 appVersion: 1.1.0
 maintainers:
 - name: jfelten

stable/openvpn/README.md

@@ -60,6 +60,7 @@ New certificates are generated with each deployment.  If persistence is enabled
 * openvpn.OVPN_PROTO: tcp - Protocol used by openvpn tcp or udp (default: tcp).
 * openvpn.OVPN_K8S_POD_NETWORK: "10.0.0.0" - Kubernetes pod network (optional).
 * openvpn.OVPN_K8S_POD_SUBNET: "255.0.0.0" - Kubernetes pod network subnet (optional).
+* openvpn.dhcpOptionDomain: true - Push a `dhcp-option DOMAIN` config
 * openvpn.conf: "" - Arbitrary lines appended to the end of the server configuration file
 
 #### Note: As configured the chart will create a route for a large 10.0.0.0/8 network that may cause issues if that is your local network.  If so tweak this value to something more restrictive.  This route is added, because GKE generates pods with IPs in this range.

stable/openvpn/templates/config-openvpn.yaml

@@ -105,7 +105,9 @@ data:
       push "route {{ .Values.openvpn.OVPN_K8S_POD_NETWORK }} {{ .Values.openvpn.OVPN_K8S_POD_SUBNET }}"
 {{ end }}
 
+{{ if .Values.openvpn.dhcpOptionDomain }}
       push "dhcp-option DOMAIN OVPN_K8S_SEARCH"
+{{ end }}
       push "dhcp-option DNS OVPN_K8S_DNS"
 
       {{- if .Values.openvpn.conf }}

stable/openvpn/values.yaml

@@ -48,6 +48,8 @@ openvpn:
   OVPN_K8S_POD_NETWORK: "10.0.0.0"
   # Kubernetes pod network subnet (optional).
   OVPN_K8S_POD_SUBNET: "255.0.0.0"
+  # Push a `dhcp-option DOMAIN` config
+  dhcpOptionDomain: true
   # Arbitrary lines appended to the end of the server configuration file
   # conf: |
   #  max-clients 100