incubator/kube-downscaler - fix a regression about namespaces (#23030)

* Fix a kube-downscaler regression about namespaces

The present fixes a regression where invalid option value 'namespaces' is passed to the tool
and overly generous permissions are granted over namespaces.

Signed-off-by: Danil Mironov <patrungel@gmail.com>

* Delete excessive quotes in arguments

Signed-off-by: Danil Mironov <patrungel@gmail.com>

incubator/kube-downscaler/Chart.yaml

@@ -1,6 +1,6 @@
 name: kube-downscaler
 apiVersion: v1
-version: 0.4.1
+version: 0.4.2
 appVersion: 19.10.1
 description: A Helm chart for kube-downscaler
 home: https://github.com/hjacobs/kube-downscaler

incubator/kube-downscaler/README.md

@@ -61,7 +61,7 @@ The following tables lists the configurable parameters of the kube-downscaler ch
 | `securityContext`         | SecurityContext to apply to the downscaler pod                                                       | `{}`                                      |
 | `rbac.create`             | If true, create & use RBAC resources                                                                 | `true`                                    |
 | `rbac.serviceAccountName` | ServiceAccount downscaler will use (ignored if rbac.create=true)                                     | `default`                                 |
-| `downscaleResources`      | Resources the downscaler is allowed to manage                                                        | `[deployments, statefulsets, namespaces]` |
+| `downscaleResources`      | Resources the downscaler is allowed to manage                                                        | `[deployments, statefulsets]`             |
 | `excludedDeployments`     | Deployments to exclude from the downscaler                                                           | `[]`                                      |
 | `excludedNamespaces`      | Namespaces to exclude from the downscaler                                                            | `[]`                                      |
 | `extraArgs`               | Add extra args to docker command                                                                     | `[]`                                      |

incubator/kube-downscaler/templates/clusterrole.yaml

@@ -13,6 +13,7 @@ rules:
       - ""
     resources:
       - pods
+      - namespaces
     verbs:
       - get
       - watch

incubator/kube-downscaler/templates/deployment.yaml

@@ -40,12 +40,12 @@ spec:
           {{- if .Values.debug.enable }}
           - --debug
           {{- end }}
-          - --include-resources="{{- join "," .Values.downscaleResources }}"
+          - --include-resources={{- join "," .Values.downscaleResources }}
           {{- if .Values.excludedNamespaces }}
-          - --exclude-namespaces="{{- join "," .Values.excludedNamespaces }}"
+          - --exclude-namespaces={{- join "," .Values.excludedNamespaces }}
           {{- end }}
           {{- if .Values.excludedDeployments }}
-          - --exclude-deployments="{{- join "," .Values.excludedDeployments }}"
+          - --exclude-deployments={{- join "," .Values.excludedDeployments }}
           {{- end }}
 {{- with .Values.extraArgs }}
 {{ toYaml . | indent 10 }}

incubator/kube-downscaler/values.yaml

@@ -16,7 +16,6 @@ namespace:
 downscaleResources:
   - deployments
   - statefulsets
-  - namespaces
 
 # List of namespaces to be excluded from the downscaler
 excludedNamespaces: []