[Node-exporter] Add extra flags arguments and rollingUpdate strategy (#5699)

* specify rolling update strategy

* add extra args

* review readme

* bump chart version

stable/prometheus-node-exporter/Chart.yaml

@@ -2,7 +2,7 @@ apiVersion: v1
 appVersion: "0.15.2"
 description: A Helm chart for prometheus node-exporter
 name: prometheus-node-exporter
-version: 0.1.2
+version: 0.2.0
 home: https://github.com/prometheus/node_exporter/
 sources:
 - https://github.com/prometheus/node_exporter/

stable/prometheus-node-exporter/README.md

@@ -41,6 +41,7 @@ The following table lists the configurable parameters of the Node Exporter chart
 | `image.repository`      | Image repository                                                                                                              | `quay.io/prometheus/node-exporter`      |
 | `image.tag`             | Image tag                                                                                                                     | `v0.15.2`                               |
 | `image.pullPolicy`      | Image pull policy                                                                                                             | `IfNotPresent`                          |
+| `extraArgs`             | Additional container arguments                                                                                              | `[]`                                                                     |
 | `resources`             | CPU/Memory resource requests/limits                                                                                           | `{}`                                    |
 | `service.type`          | Service type                                                                                                                  | `ClusterIP`                             |
 | `service.port`          | The service port                                                                                                              | `9100`                                  |

stable/prometheus-node-exporter/templates/daemonset.yaml

@@ -12,6 +12,10 @@ spec:
     matchLabels:
       app: {{ template "prometheus-node-exporter.name" . }}
       release: {{ .Release.Name }}
+  updateStrategy:
+    type: RollingUpdate
+    rollingUpdate:
+      maxUnavailable: 1      
   template:
     metadata:
       labels:
@@ -30,6 +34,9 @@ spec:
             - --path.procfs=/host/proc
             - --path.sysfs=/host/sys
             - --web.listen-address=0.0.0.0:{{ .Values.service.port }}
+{{- if .Values.extraArgs }}
+{{ toYaml .Values.extraArgs | indent 12 }}
+{{- end }}
           ports:
             - name: metrics
               containerPort: {{ .Values.service.targetPort }}

stable/prometheus-node-exporter/values.yaml

@@ -33,3 +33,8 @@ serviceAccount:
 tolerations:
   - effect: NoSchedule
     operator: Exists
+
+## Additional container arguments
+##
+# extraArgs:
+#   - --collector.diskstats.ignored-devices=^(ram|loop|fd|(h|s|v)d[a-z]|nvme\\d+n\\d+p)\\d+$