[stable/mongodb] Refactor image property in values.yaml (#4646)

* [stable/mongodb] Refactor image properties in values.yaml

* Use rolling tag and refactor pullSecrets

* Fix lint issue

* Bump chart version

* Update mongodb to version 3.7.3

* Update Chart.yaml

stable/mongodb/Chart.yaml

@@ -1,6 +1,6 @@
 name: mongodb
-version: 0.4.29
-appVersion: 3.7.1
+version: 1.0.0
+appVersion: 3.7.3
 description: NoSQL document-oriented database that stores JSON-like documents with dynamic schemas, simplifying the integration of data in content-driven applications.
 keywords:
 - mongodb

stable/mongodb/README.md

@@ -45,8 +45,11 @@ The following table lists the configurable parameters of the MongoDB chart and t
 
 |         Parameter                   |             Description                    |                         Default                          |
 |----------------------------         |-------------------------------------       |----------------------------------------------------------|
-| `image`                             | MongoDB image                              | `bitnami/mongodb:{VERSION}`                              |
-| `imagePullPolicy`                   | Image pull policy                          | `Always` if `imageTag` is `latest`, else `IfNotPresent`. |
+| `image.registry`                    | MongoDB image registry                     | `docker.io`                                              |
+| `image.repository`                  | MongoDB Image name                         | `bitnami/mongodb`                                        |
+| `image.tag`                         | MongoDB Image tag                          | `{VERSION}`                                              |
+| `image.pullPolicy`                  | Image pull policy                          | `Always` if `imageTag` is `latest`, else `IfNotPresent`  |
+| `image.pullSecrets`                 | Specify image pull secrets                 | `nil`                                                    |
 | `mongodbRootPassword`               | MongoDB admin password                     | `random alhpanumeric string (10)`                        |
 | `mongodbUsername`                   | MongoDB custom user                        | `nil`                                                    |
 | `mongodbPassword`                   | MongoDB custom user password               | `random alhpanumeric string (10)`                        |

stable/mongodb/templates/deployment.yaml

@@ -16,11 +16,17 @@ spec:
       {{- if .Values.nodeSelector }}
       nodeSelector:
 {{ toYaml .Values.nodeSelector | indent 8 }}
+      {{- end }}
+      {{- if .Values.image.pullSecrets }}
+      imagePullSecrets:
+      {{- range .Values.image.pullSecrets }}
+        - name: {{ . }}
+      {{- end}}
       {{- end }}
       containers:
       - name: {{ template "mongodb.fullname" . }}
-        image: "{{ .Values.image }}"
-        imagePullPolicy: {{ default "" .Values.imagePullPolicy | quote }}
+        image: "{{ .Values.image.registry }}/{{ .Values.image.repository }}:{{ .Values.image.tag }}"
+        imagePullPolicy: {{ .Values.image.pullPolicy | quote }}
         env:
         - name: MONGODB_ROOT_PASSWORD
           valueFrom:

stable/mongodb/values.yaml

@@ -1,13 +1,21 @@
 ## Bitnami MongoDB image version
 ## ref: https://hub.docker.com/r/bitnami/mongodb/tags/
 ##
-image: bitnami/mongodb:3.7.1-r0
-
-## Specify a imagePullPolicy
-## 'Always' if imageTag is 'latest', else set to 'IfNotPresent'
-## ref: http://kubernetes.io/docs/user-guide/images/#pre-pulling-images
-##
-# imagePullPolicy:
+image:
+  registry: docker.io
+  repository: bitnami/mongodb
+  tag: 3.7.3
+  ## Specify a imagePullPolicy
+  ## Defaults to 'Always' if image tag is 'latest', else set to 'IfNotPresent'
+  ## ref: http://kubernetes.io/docs/user-guide/images/#pre-pulling-images
+  ##
+  pullPolicy: IfNotPresent
+  ## Optionally specify an array of imagePullSecrets.
+  ## Secrets must be manually created in the namespace.
+  ## ref: https://kubernetes.io/docs/tasks/configure-pod-container/pull-image-private-registry/
+  ##
+  # pullSecrets:
+  #   - myRegistrKeySecretName
 
 ## MongoDB admin password
 ## ref: https://github.com/bitnami/bitnami-docker-mongodb/blob/master/README.md#setting-the-root-password-on-first-run