[stable/consul] Fix statefulset selector (#5151)

* [stable/consul] Fix statefulset selectors

Selectors need to be explicit and immutable so they can't contain
the chart version

* Add version back to  label but remove  from selector

stable/consul/Chart.yaml

@@ -1,6 +1,6 @@
 name: consul
 home: https://github.com/hashicorp/consul
-version: 1.3.6
+version: 1.4.0
 appVersion: 1.0.0
 description: Highly available and distributed service discovery and key-value store
   designed with support for the modern data center to make distributed systems and

stable/consul/templates/consul-ingress.yaml

@@ -29,4 +29,3 @@ spec:
 {{ toYaml .Values.uiIngress.tls | indent 4 }}
   {{- end -}}
 {{- end }}
-

stable/consul/templates/consul-statefulset.yaml

@@ -12,6 +12,10 @@ spec:
   replicas: {{ default 3 .Values.Replicas }}
   updateStrategy:
     type: RollingUpdate
+  selector:
+    matchLabels:
+      release: {{ .Release.Name | quote }}
+      component: "{{ .Release.Name }}-{{ .Values.Component }}"
   template:
     metadata:
       name: "{{ template "consul.fullname" . }}"

stable/consul/templates/gossip-secret.yaml

@@ -2,6 +2,11 @@ apiVersion: v1
 kind: Secret
 metadata:
   name: {{ template "consul.fullname" . }}-gossip-key
+  labels:
+    heritage: {{ .Release.Service | quote }}
+    release: {{ .Release.Name | quote }}
+    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+    component: "{{ .Release.Name }}-{{ .Values.Component }}"
 type: Opaque
 data:
   {{ if .Values.GossipKey }}

stable/consul/templates/pod-dist-budget.yaml

@@ -3,6 +3,11 @@ apiVersion: policy/v1beta1
 kind: PodDisruptionBudget
 metadata:
   name: "{{ template "consul.fullname" . }}-pdb"
+  labels:
+    heritage: {{ .Release.Service | quote }}
+    release: {{ .Release.Name | quote }}
+    chart: "{{ .Chart.Name }}-{{ .Chart.Version }}"
+    component: "{{ .Release.Name }}-{{ .Values.Component }}"
 spec:
   maxUnavailable: {{ .Values.maxUnavailable }}
   selector: