mirror of
https://github.com/helm/charts.git
synced 2026-08-23 22:37:45 +00:00
Fix blackbox target's metrics labels (#22546)
The metrics labels currently generated does not match what is generated by the setup described here: https://prometheus.io/docs/guides/multi-target-exporter/#querying-multi-target-exporters-with-prometheus and https://github.com/prometheus/blackbox_exporter#prometheus-configuration The previous metricsRelabeling is only valid if the target contains the URLs to check. What we need in the end is: - `__address__` set to the blackbox exporter, and it it already the case as the `selector` matches the blackbox exporter, - `__param_target` set to the target to check, and it is already ensure without relabeling, - `instance` set to the target to check. This patches ensures that the metrics has this labels: ``` probe_success{endpoint="http",instance="http://prometheus.io",job="blackbox-exporter-prometheus-blackbox-exporter",namespace="monitoring",pod="blackbox-exporter-prometheus-blackbox-exporter-84d9b64646-vgqcc",service="blackbox-exporter-prometheus-blackbox-exporter"} 1 ``` Without this patch, we have this (note that we lost the `instance` label): ``` probe_success{endpoint="http",job="blackbox-exporter-prometheus-blackbox-exporter",namespace="monitoring",pod="blackbox-exporter-prometheus-blackbox-exporter-84d9b64646-vgqcc",service="blackbox-exporter-prometheus-blackbox-exporter",target="prometheus-io"} 1 ``` Signed-off-by: Mickaël Canévet <mickael.canevet@gmail.com>
This commit is contained in:
@@ -1,7 +1,7 @@
|
||||
apiVersion: v1
|
||||
description: Prometheus Blackbox Exporter
|
||||
name: prometheus-blackbox-exporter
|
||||
version: 4.1.1
|
||||
version: 4.2.0
|
||||
appVersion: 0.16.0
|
||||
home: https://github.com/prometheus/blackbox_exporter
|
||||
sources:
|
||||
|
||||
@@ -26,10 +26,8 @@ spec:
|
||||
target:
|
||||
- {{ .url }}
|
||||
metricRelabelings:
|
||||
- sourceLabels: [__address__]
|
||||
targetLabel: __param_target
|
||||
- sourceLabels: [__param_target]
|
||||
targetLabel: instance
|
||||
- targetLabel: instance
|
||||
replacement: {{ .url }}
|
||||
- targetLabel: target
|
||||
replacement: {{ .name }}
|
||||
jobLabel: "{{ $.Release.Name }}"
|
||||
@@ -42,4 +40,3 @@ spec:
|
||||
- {{ $.Release.Namespace }}
|
||||
{{- end }}
|
||||
{{- end }}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user