github/capsule
1
0
Fork 0
mirror of https://github.com/projectcapsule/capsule.git synced 2026-08-25 16:07:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: revert dry-run admission tests (#2038)

Browse Source 
* fix: allow administrator operations on tenant namespaces

Signed-off-by: Oliver Baehler <oliver@sudo-i.net>

* fix: allow administrator operations on tenant namespaces

Signed-off-by: Oliver Baehler <oliver@sudo-i.net>

* fix: allow administrator operations on tenant namespaces

Signed-off-by: Oliver Baehler <oliver@sudo-i.net>

* fix: allow administrator operations on tenant namespaces

Signed-off-by: Oliver Baehler <oliver@sudo-i.net>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* fix: revert dry-run

Signed-off-by: Oliver Baehler <oliver@sudo-i.net>

* fix: revert dry-run

Signed-off-by: Oliver Baehler <oliver@sudo-i.net>

* fix: revert dry-run

Signed-off-by: Oliver Baehler <oliver@sudo-i.net>

* feat: implement namespace metadata enforcement

Signed-off-by: Oliver Baehler <oliver@sudo-i.net>

---------

Signed-off-by: Oliver Baehler <oliver@sudo-i.net>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
Oliver Bähler
2026-07-20 13:03:47 +02:00
committed by GitHub
co-authored by Copilot Autofix powered by AI
parent abff646dab
commit 1790189d4e
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/config_namespace_hijacking_test.go
+11 -8
View File
@@ -399,7 +399,7 @@ var _ = Describe("creating several Namespaces for a Tenant", Ordered, Label("con
_, err = cs.CoreV1().Namespaces().UpdateStatus(
context.TODO(),
hijacked,
metav1.UpdateOptions{DryRun: []string{metav1.DryRunAll}},
metav1.UpdateOptions{},
)
if err != nil {
@@ -484,7 +484,7 @@ var _ = Describe("creating several Namespaces for a Tenant", Ordered, Label("con
_, err = cs.CoreV1().Namespaces().Finalize(
context.TODO(),
hijacked,
metav1.UpdateOptions{DryRun: []string{metav1.DryRunAll}},
metav1.UpdateOptions{},
)
if err != nil {
@@ -525,7 +525,7 @@ var _ = Describe("creating several Namespaces for a Tenant", Ordered, Label("con
_, err = cs.CoreV1().Namespaces().Update(
context.TODO(),
current,
metav1.UpdateOptions{DryRun: []string{metav1.DryRunAll}},
metav1.UpdateOptions{},
)
Expect(err).To(HaveOccurred())
@@ -950,7 +950,10 @@ var _ = Describe("creating several Namespaces for a Tenant", Ordered, Label("con
UID: tenant.GetUID(),
}}
_, _ = cs.CoreV1().Namespaces().UpdateStatus(context.TODO(), statusNs, metav1.UpdateOptions{DryRun: []string{metav1.DryRunAll}})
_, err = cs.CoreV1().Namespaces().UpdateStatus(context.TODO(), statusNs, metav1.UpdateOptions{})
Expect(err).To(HaveOccurred())
Expect(apierrors.IsForbidden(err)).To(BeTrue())
Expect(err).To(MatchError(ContainSubstring("namespace can not be patched into a tenant")))
patch := []byte(fmt.Sprintf(
`{"metadata":{"labels":{"%s":"%s"}}}`,
@@ -1219,7 +1222,7 @@ var _ = Describe("creating several Namespaces for a Tenant", Ordered, Label("con
},
}
_, err = cs.CoreV1().Namespaces().UpdateStatus(context.TODO(), statusNs, metav1.UpdateOptions{DryRun: []string{metav1.DryRunAll}})
_, err = cs.CoreV1().Namespaces().UpdateStatus(context.TODO(), statusNs, metav1.UpdateOptions{})
if err != nil {
expectOriginalTenantOwnership(ns.Name, tenant)
@@ -1261,7 +1264,7 @@ var _ = Describe("creating several Namespaces for a Tenant", Ordered, Label("con
statusNs.Labels[meta.TenantLabel] = randomName
_, err = cs.CoreV1().Namespaces().UpdateStatus(context.TODO(), statusNs, metav1.UpdateOptions{DryRun: []string{metav1.DryRunAll}})
_, err = cs.CoreV1().Namespaces().UpdateStatus(context.TODO(), statusNs, metav1.UpdateOptions{})
if err != nil {
expectOriginalTenantOwnership(ns.Name, tenant)
@@ -1312,7 +1315,7 @@ var _ = Describe("creating several Namespaces for a Tenant", Ordered, Label("con
},
}
_, err = cs.CoreV1().Namespaces().UpdateStatus(context.TODO(), statusNs, metav1.UpdateOptions{DryRun: []string{metav1.DryRunAll}})
_, err = cs.CoreV1().Namespaces().UpdateStatus(context.TODO(), statusNs, metav1.UpdateOptions{})
if err != nil {
retrievedNs := getNamespace(ns.Name)
@@ -1361,7 +1364,7 @@ var _ = Describe("creating several Namespaces for a Tenant", Ordered, Label("con
},
}
_, err = cs.CoreV1().Namespaces().UpdateStatus(context.TODO(), statusNs, metav1.UpdateOptions{DryRun: []string{metav1.DryRunAll}})
_, err = cs.CoreV1().Namespaces().UpdateStatus(context.TODO(), statusNs, metav1.UpdateOptions{})
if err != nil {
expectNoTenantOwnership(unmanaged.Name, tenant)