Revert chart labels for seamless upgrades (#903)

* Revert chart labels for seamless upgrades

.github/workflows/push-helm-chart.yaml

@@ -11,6 +11,7 @@ on:
     paths:
       - 'deployments/kubernetes/chart/reloader/**'
       - '.github/workflows/push-helm-chart.yaml'
+      - '.github/workflows/release-helm-chart.yaml'
 
 env:
   HELM_REGISTRY_URL: "https://stakater.github.io/stakater-charts"

.github/workflows/release-helm-chart.yaml

@@ -4,8 +4,6 @@ on:
   push:
     tags:
       - "chart-v*"
-    tags-ignore:
-      - "v*"
 
 permissions:
   contents: write

.github/workflows/release.yaml

@@ -4,8 +4,6 @@ on:
   push:
     tags:
       - "v*"
-    tags-ignore:
-      - "chart-v*"
 
 env:
   DOCKER_FILE_PATH: Dockerfile

.vale.ini

@@ -1,7 +1,7 @@
 StylesPath = styles
 MinAlertLevel = warning
 
-Packages = https://github.com/stakater/vale-package/releases/download/v0.0.60/Stakater.zip
+Packages = https://github.com/stakater/vale-package/releases/download/v0.0.61/Stakater.zip
 Vocab = Stakater
 
 # Only check MarkDown files

deployments/kubernetes/chart/reloader/Chart.yaml

@@ -1,8 +1,8 @@
 apiVersion: v1
 name: reloader
 description: Reloader chart that runs on kubernetes
-version: 2.1.0
-appVersion: v1.4.0
+version: 2.1.2
+appVersion: v1.4.1
 keywords:
   - Reloader
   - kubernetes

deployments/kubernetes/chart/reloader/README.md

@@ -125,25 +125,25 @@ helm uninstall {{RELEASE_NAME}} -n {{NAMESPACE}}
 
 #### 🔄 `reloadOnCreate` Behavior
 **When true:**
-✅ New ConfigMaps/Secrets trigger rolling updates  
-✅ New deployments referencing existing resources reload  
-✅ In HA mode, new leader reloads all tracked workloads  
+✅ New ConfigMaps/Secrets trigger rolling updates
+✅ New deployments referencing existing resources reload
+✅ In HA mode, new leader reloads all tracked workloads
 
 **When false:**
-❌ Updates during leader downtime are missed  
-⏳ Potential 15s delay window (default `LeaseDuration`)  
+❌ Updates during leader downtime are missed
+⏳ Potential 15s delay window (default `LeaseDuration`)
 
 #### 🗑️ `reloadOnDelete` Behavior
 **When true:**
-✅ Deleted resources trigger rolling updates of referencing workloads  
+✅ Deleted resources trigger rolling updates of referencing workloads
 
 **When false:**
-❌ Deletions have no effect on referencing pods  
+❌ Deletions have no effect on referencing pods
 
 #### Default Settings
 ⚠️ All flags default to `false` (must be enabled explicitly):
 - `reloadOnCreate`
-- `reloadOnDelete` 
+- `reloadOnDelete`
 - `syncAfterRestart`
 
 ### Deprecation Notice

deployments/kubernetes/chart/reloader/templates/_helpers.tpl

@@ -28,12 +28,10 @@ Create chart name and version as used by the chart label.
 {{- end }}
 
 {{- define "reloader-labels.chart" -}}
-app.kubernetes.io/name: {{ include "reloader-name" . }}
-helm.sh/chart: {{ include "reloader-chart" . }}
-{{- if .Chart.AppVersion }}
-app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
-{{- end}}
-app.kubernetes.io/instance: {{ .Release.Name | quote }}
+app: {{ template "reloader-fullname" . }}
+chart: "{{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}"
+release: {{ .Release.Name | quote }}
+heritage: {{ .Release.Service | quote }}
 app.kubernetes.io/managed-by: {{ .Release.Service | quote }}
 {{- end -}}
 

deployments/kubernetes/chart/reloader/templates/deployment.yaml

@@ -25,8 +25,8 @@ spec:
   revisionHistoryLimit: {{ .Values.reloader.deployment.revisionHistoryLimit }}
   selector:
     matchLabels:
-      app.kubernetes.io/name: {{ template "reloader-fullname" . }}
-      app.kubernetes.io/instance: {{ .Release.Name | quote }}
+      app: {{ template "reloader-fullname" . }}
+      release: {{ .Release.Name | quote }}
 {{- if .Values.reloader.matchLabels }}
 {{ toYaml .Values.reloader.matchLabels | indent 6 }}
 {{- end }}

deployments/kubernetes/chart/reloader/templates/networkpolicy.yaml

@@ -14,8 +14,8 @@ metadata:
 spec:
   podSelector:
     matchLabels:
-      app.kubernetes.io/name: {{ template "reloader-fullname" . }}
-      app.kubernetes.io/instance: {{ .Release.Name | quote }}
+      app: {{ template "reloader-fullname" . }}
+      release: {{ .Release.Name | quote }}
 {{- if .Values.reloader.matchLabels }}
 {{ toYaml .Values.reloader.matchLabels | indent 6 }}
 {{- end }}

deployments/kubernetes/chart/reloader/templates/poddisruptionbudget.yaml

@@ -13,5 +13,5 @@ spec:
 {{- end }}
   selector:
     matchLabels:
-      app.kubernetes.io/name: {{ template "reloader-fullname" . }}
+      app: {{ template "reloader-fullname" . }}
 {{- end }}

deployments/kubernetes/chart/reloader/values.yaml

@@ -17,7 +17,7 @@ fullnameOverride: ""
 image:
   name: stakater/reloader
   repository: ghcr.io/stakater/reloader
-  tag: v1.4.0
+  tag: v1.4.1
   # digest: sha256:1234567
   pullPolicy: IfNotPresent
 
@@ -106,7 +106,7 @@ reloader:
     labels:
       provider: stakater
       group: com.stakater.platform
-      version: v1.4.0
+      version: v1.4.1
     # Support for extra environment variables.
     env:
       # Open supports Key value pair as environment variables.