PR #1061 renamed the configmap key in kube.ResourceMap from "configMaps"
(camelCase) to "configmaps" (lowercase) to fix controllers not being
able to mark themselves as initialized. However, two callers were not
updated to match the new canonical key:
1. The Helm chart's deployment template still emits
`--resources-to-ignore=configMaps` (camelCase) when
`reloader.ignoreConfigMaps: true` is set.
2. The validation in `GetIgnoredResourcesList` only accepts the legacy
camelCase spelling.
Because `ignoredResourcesList.Contains(k)` uses case-sensitive string
equality, the lookup against the new lowercase ResourceMap key never
matches. The configmaps controller is created and starts watching
ConfigMaps cluster-wide, even though the chart's ClusterRole template
(also gated on `ignoreConfigMaps`) does not grant permission for it.
The resulting pod logs are full of:
configmaps is forbidden: User "system:serviceaccount:reloader:reloader-reloader"
cannot list resource "configmaps" in API group "" at the cluster scope
This change:
- Updates the chart deployment template to emit the canonical lowercase
`configmaps` value.
- Normalizes the input in `GetIgnoredResourcesList`, accepting both
`configMaps` (legacy, for backward compatibility with users who pass
the flag directly) and `configmaps` (canonical), and emitting the
canonical form to the caller.
- Updates the flag help text and adds tests covering both spellings.
Extended Helm chart configuration to allow imagePullSecrets to be defined
either as a list of strings (e.g., `- my-pull-secret`) or as a list of
objects with `name` keys (e.g., `- name: my-pull-secret`).
This improves the compatibility and makes it easier to work with various tools,
which take advantake from the assumption of existence of those labels.
Keep the old labels for selectors for backward compatibility.
Also note there is slight change in behaviour of PDB which might
be backward-incompatible in some rare cases.
Jesse Stephens
Safwan
Faizan AhmadandGitHub
hznor
Muhammad Safwan KarimandGitHub
Michael VögeliandGitHub
Hlib Kalinchuk
Michael Vögeli
renovate[bot]andGitHub
Felix TonnvikandGitHub
Felix-Stakaterandgithub-actions[bot]
Erik Svensson
Pradeep Lakshmi NarasimhaandFelix
Nitin Verma
Jiří Pinkava
Yoga Yu