github/Bose-SoundTouch
1
0
Fork 0
mirror of https://github.com/gesellix/Bose-SoundTouch.git synced 2026-08-19 00:56:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(web): clear DNS port warning when leaving the resolv method

Browse Source 
toggleMigrationMethod()'s XML branch never reset
#dns-port-warning, so switching from resolv back to xml left the
"DNS Discovery is DISABLED" warning visible while the XML method was
selected — where the warning is irrelevant.

Reset the display to "none" in the default (XML) branch alongside
the existing telnet/hosts branches that already do this. The next
iteration's redesign of the Customize panel folds this state into
per-method preconditions and removes the global warning entirely;
this fix keeps the current UI honest until then.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Tobias Gesellchen
2026-05-11 00:37:11 +02:00
co-authored by Claude Opus 4.7
parent b035dd3bf9
commit b7175289c2
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/service/handlers/web/js/script.js
+6
View File
@@ -3076,6 +3076,12 @@ async function toggleMigrationMethod() {
console.error("Failed to check DNS settings", e);
}
} else {
// XML branch (the default fallthrough). The DNS-port warning is
// owned by the resolv branch, but the previous code path forgot
// to reset it here — switching from resolv back to xml left a
// stale "DNS Discovery is DISABLED" warning attached to the XML
// method, where it's irrelevant.
if (dnsWarning) dnsWarning.style.display = "none";
xmlDiffPane.style.display = "block";
plannedXmlPane.style.display = "block";
plannedHostsPane.style.display = "none";