From 7a3dc5c6fa09d2bd17f420f018a1b5adfd45dcc2 Mon Sep 17 00:00:00 2001 From: Thibault VINCENT Date: Sat, 2 May 2026 14:19:46 +0200 Subject: [PATCH] test(server): fix codeql warning on return value --- internal/server/server_test.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/internal/server/server_test.go b/internal/server/server_test.go index 703518f..a8fcf86 100644 --- a/internal/server/server_test.go +++ b/internal/server/server_test.go @@ -2,6 +2,7 @@ package server import ( "context" + "errors" "io" "log/slog" "net/http" @@ -94,5 +95,9 @@ func TestRunGracefulShutdown(t *testing.T) { defer ts.Close() ctx, cancel := context.WithTimeout(context.Background(), 100*time.Millisecond) defer cancel() - _ = Run(ctx, &http.Server{Addr: "127.0.0.1:0", Handler: srv.Handler}, nopLogger()) + // Run must return the ctx error after graceful shutdown, not a + // server-side error (e.g. bind failure). + if err := Run(ctx, &http.Server{Addr: "127.0.0.1:0", Handler: srv.Handler}, nopLogger()); !errors.Is(err, context.DeadlineExceeded) { + t.Fatalf("Run: expected context.DeadlineExceeded, got %v", err) + } }