diff --git a/pipeline/rpc/proto/woodpecker.pb.go b/pipeline/rpc/proto/woodpecker.pb.go index d0563df31..c2483af47 100644 --- a/pipeline/rpc/proto/woodpecker.pb.go +++ b/pipeline/rpc/proto/woodpecker.pb.go @@ -15,8 +15,8 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // versions: -// protoc-gen-go v1.36.9 -// protoc v6.32.0 +// protoc-gen-go v1.36.10 +// protoc v6.31.1 // source: woodpecker.proto package proto diff --git a/pipeline/rpc/proto/woodpecker_grpc.pb.go b/pipeline/rpc/proto/woodpecker_grpc.pb.go index e332e9fe7..4ecfaf474 100644 --- a/pipeline/rpc/proto/woodpecker_grpc.pb.go +++ b/pipeline/rpc/proto/woodpecker_grpc.pb.go @@ -16,7 +16,7 @@ // Code generated by protoc-gen-go-grpc. DO NOT EDIT. // versions: // - protoc-gen-go-grpc v1.5.1 -// - protoc v6.32.0 +// - protoc v6.31.1 // source: woodpecker.proto package proto diff --git a/server/api/repo_parameter.go b/server/api/repo_parameter.go index c728528bc..103dce1e9 100644 --- a/server/api/repo_parameter.go +++ b/server/api/repo_parameter.go @@ -66,10 +66,14 @@ func PostParameter(c *gin.Context) { return } parameter, err := parameterService.ParameterFind(repo, in.Name) + if err != nil { + handleDBError(c, err) + return + } c.JSON(http.StatusOK, parameter) } -// PatchParameter updates an existing parameter by ID +// PatchParameter updates an existing parameter by ID. func PatchParameter(c *gin.Context) { repo := session.Repo(c) paramID, err := strconv.ParseInt(c.Param("parameter"), 10, 64) @@ -119,6 +123,10 @@ func PatchParameter(c *gin.Context) { return } parameter, err := parameterService.ParameterFindByID(repo, paramID) + if err != nil { + handleDBError(c, err) + return + } c.JSON(http.StatusOK, parameter) } diff --git a/server/services/parameter/db.go b/server/services/parameter/db.go index 8f5c4cb25..49c39d9a6 100644 --- a/server/services/parameter/db.go +++ b/server/services/parameter/db.go @@ -36,7 +36,7 @@ func (d *db) ParameterFindByID(repo *model.Repo, id int64) (*model.Parameter, er return d.store.ParameterFindByID(repo, id) } -func (d *db) ParameterFindByNameAndBranch(repo *model.Repo, name string, branch string) (*model.Parameter, error) { +func (d *db) ParameterFindByNameAndBranch(repo *model.Repo, name, branch string) (*model.Parameter, error) { return d.store.ParameterFindByNameAndBranch(repo, name, branch) } diff --git a/server/services/parameter/service.go b/server/services/parameter/service.go index 8fbeeb010..e3c95de0c 100644 --- a/server/services/parameter/service.go +++ b/server/services/parameter/service.go @@ -21,7 +21,7 @@ type Service interface { // Repository parameters ParameterFind(*model.Repo, string) (*model.Parameter, error) ParameterFindByID(*model.Repo, int64) (*model.Parameter, error) - ParameterFindByNameAndBranch(repo *model.Repo, name string, branch string) (*model.Parameter, error) + ParameterFindByNameAndBranch(repo *model.Repo, name, branch string) (*model.Parameter, error) ParameterList(*model.Repo) ([]*model.Parameter, error) ParameterCreate(*model.Repo, *model.Parameter) error ParameterUpdate(*model.Repo, *model.Parameter) error diff --git a/server/store/datastore/parameter.go b/server/store/datastore/parameter.go index 23106ae9a..6f9a9ffdc 100644 --- a/server/store/datastore/parameter.go +++ b/server/store/datastore/parameter.go @@ -28,7 +28,7 @@ func (s storage) ParameterFindByID(repo *model.Repo, id int64) (*model.Parameter return parameter, wrapGet(s.engine.Where("parameter_repo_id = ? AND parameter_id = ?", repo.ID, id).Get(parameter)) } -func (s storage) ParameterFindByNameAndBranch(repo *model.Repo, name string, branch string) (*model.Parameter, error) { +func (s storage) ParameterFindByNameAndBranch(repo *model.Repo, name, branch string) (*model.Parameter, error) { parameter := new(model.Parameter) return parameter, wrapGet(s.engine.Where("parameter_repo_id = ? AND parameter_name = ? AND parameter_branch = ?", repo.ID, name, branch).Get(parameter)) } diff --git a/web/src/components/parameters/ParameterEdit.vue b/web/src/components/parameters/ParameterEdit.vue index 052473657..ff236b899 100644 --- a/web/src/components/parameters/ParameterEdit.vue +++ b/web/src/components/parameters/ParameterEdit.vue @@ -2,26 +2,17 @@
- + @@ -31,7 +22,7 @@