From c7b64e24ab7db7311c9fcff73e61ff2d818972e9 Mon Sep 17 00:00:00 2001
From: smainz <stefan@mainz.ws>
Date: Sun, 21 Jul 2024 11:36:01 +0200
Subject: [PATCH] Make cli plugin log purge recognize steps by name (#3953)

---
 cli/log/log_purge.go | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

diff --git a/cli/log/log_purge.go b/cli/log/log_purge.go
index f9dc536d2..44070289b 100644
--- a/cli/log/log_purge.go
+++ b/cli/log/log_purge.go
@@ -27,7 +27,7 @@ import (
 var logPurgeCmd = &cli.Command{
 	Name:      "purge",
 	Usage:     "purge a log",
-	ArgsUsage: "<repo-id|repo-full-name> <pipeline> [step]",
+	ArgsUsage: "<repo-id|repo-full-name> <pipeline> [step-number|step-name]",
 	Action:    logPurge,
 }
 
@@ -37,34 +37,42 @@ func logPurge(ctx context.Context, c *cli.Command) (err error) {
 		return err
 	}
 	repoIDOrFullName := c.Args().First()
+	if len(repoIDOrFullName) == 0 {
+		return fmt.Errorf("missing required argument repo-id / repo-full-name")
+	}
 	repoID, err := internal.ParseRepo(client, repoIDOrFullName)
 	if err != nil {
-		return err
+		return fmt.Errorf("invalid repo '%s': %w", repoIDOrFullName, err)
 	}
-	number, err := strconv.ParseInt(c.Args().Get(1), 10, 64)
+
+	pipelineArg := c.Args().Get(1)
+	if len(pipelineArg) == 0 {
+		return fmt.Errorf("missing required argument pipeline")
+	}
+	number, err := strconv.ParseInt(pipelineArg, 10, 64)
 	if err != nil {
 		return err
 	}
 
 	stepArg := c.Args().Get(2) //nolint:mnd
-	// TODO: Add lookup by name: stepID, err := internal.ParseStep(client, repoID, stepIDOrName)
 	var stepID int64
 	if len(stepArg) != 0 {
-		stepID, err = strconv.ParseInt(stepArg, 10, 64)
+		stepID, err = internal.ParseStep(client, repoID, number, stepArg)
 		if err != nil {
 			return err
 		}
 	}
 
 	if stepID > 0 {
+		fmt.Printf("Purging logs for pipeline %s#%d step %d\n", repoIDOrFullName, number, stepID)
 		err = client.StepLogsPurge(repoID, number, stepID)
 	} else {
+		fmt.Printf("Purging logs for pipeline %s#%d\n", repoIDOrFullName, number)
 		err = client.LogsPurge(repoID, number)
 	}
 	if err != nil {
 		return err
 	}
 
-	fmt.Printf("Purging logs for pipeline %s#%d\n", repoIDOrFullName, number)
 	return nil
 }