github/woodpecker
1
0
Fork 0
mirror of https://github.com/woodpecker-ci/woodpecker.git synced 2026-04-15 01:41:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Various fixes and improvements (#1643)

Browse Source 
- allow repo names to be case-insensitive
- improve backend error handling on DB get errors (record not found ->
404, else -> 500)
- replace magic numbers of http response codes
- unify the look and feel of cancel / save buttons on forms and view
them in one line

---------

Co-authored-by: Lauris BH <lauris@nix.lv>
This commit is contained in:
qwerty287
2023-03-19 13:52:58 +01:00
committed by GitHub
parent 42a115e19e
commit ade8e6d010
27 changed files with 230 additions and 179 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
web/src/components/admin/settings/AdminAgentsTab.vue
View File

@@ -78,7 +78,7 @@
:label="$t('admin.settings.agents.capacity.capacity')"
docs-url="docs/next/administration/agent-config#woodpecker_max_procs"
>
<span class="text-color-alt">The max amount of parallel pipelines executed by this agent.</span>
<span class="text-color-alt">{{ $t('admin.settings.agents.capacity.desc') }}</span>
<TextField :model-value="selectedAgent.capacity?.toString()" disabled />
</InputField>
@@ -98,11 +98,15 @@
</InputField>
</template>
<Button
:is-loading="isSaving"
type="submit"
:text="isEditingAgent ? $t('admin.settings.agents.save') : $t('admin.settings.agents.add')"
/>
<div class="flex gap-2">
<Button type="button" color="gray" :text="$t('cancel')" @click="selectedAgent = undefined" />
<Button
:is-loading="isSaving"
type="submit"
color="green"
:text="isEditingAgent ? $t('admin.settings.agents.save') : $t('admin.settings.agents.add')"
/>
</div>
</form>
</div>
</Panel>

3
web/src/components/admin/settings/AdminUsersTab.vue
View File

@@ -27,7 +27,8 @@
<IconButton
icon="edit"
:title="$t('admin.settings.users.edit_user')"
class="ml-2 w-8 h-8"
class="w-8 h-8"
:class="{ 'ml-auto': !user.admin, 'ml-2': user.admin }"
@click="editUser(user)"
/>
<IconButton

15
web/src/components/repo/settings/CronTab.vue
View File

@@ -74,12 +74,15 @@
<span v-else class="text-color">{{ $t('repo.settings.crons.not_executed_yet') }}</span>
</div>
<Button
type="submit"
color="green"
:is-loading="isSaving"
:text="isEditingCron ? $t('repo.settings.crons.save') : $t('repo.settings.crons.add')"
/>
<div class="flex gap-2">
<Button type="button" color="gray" :text="$t('cancel')" @click="selectedCron = undefined" />
<Button
type="submit"
color="green"
:is-loading="isSaving"
:text="isEditingCron ? $t('repo.settings.crons.save') : $t('repo.settings.crons.add')"
/>
</div>
</form>
</div>
</Panel>

15
web/src/components/repo/settings/RegistriesTab.vue
View File

@@ -65,12 +65,15 @@
<TextField v-model="selectedRegistry.password" :placeholder="$t('password')" required />
</InputField>
<Button
type="submit"
color="green"
:is-loading="isSaving"
:text="isEditingRegistry ? $t('repo.settings.registries.save') : $t('repo.settings.registries.add')"
/>
<div class="flex gap-2">
<Button type="button" color="gray" :text="$t('cancel')" @click="selectedRegistry = undefined" />
<Button
type="submit"
color="green"
:is-loading="isSaving"
:text="isEditingRegistry ? $t('repo.settings.registries.save') : $t('repo.settings.registries.add')"
/>
</div>
</form>
</div>
</Panel>

2
web/src/components/secrets/SecretEdit.vue
View File

@@ -24,7 +24,7 @@
<CheckboxesField v-model="innerValue.event" :options="secretEventsOptions" />
</InputField>
<div class="flex gap-2 justify-center">
<div class="flex gap-2">
<Button type="button" color="gray" :text="$t('cancel')" @click="$emit('cancel')" />
<Button
type="submit"