From 360ccb48ba4a6683d5d32dfa257ce9f91c6ff0d9 Mon Sep 17 00:00:00 2001 From: qwerty287 <80460567+qwerty287@users.noreply.github.com> Date: Mon, 13 Apr 2026 12:27:03 +0200 Subject: [PATCH] Support dots in image names (#6431) --- server/model/secret.go | 2 +- server/model/secret_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/model/secret.go b/server/model/secret.go index 7ca81ac46..8c9771926 100644 --- a/server/model/secret.go +++ b/server/model/secret.go @@ -86,7 +86,7 @@ var validDockerImageString = regexp.MustCompile( `(:\d+)?` + // optional port `/)?` + // optional hostname + port `([\w\d\-_\.][\w\d\-_\.\/]*/)?` + // optional url prefix - `([\w\d\-_]+)` + // image name + `([\w\d\-_\.]+)` + // image name `(:[\w\d\-_]+)?` + // optional image tag `$`, ) diff --git a/server/model/secret_test.go b/server/model/secret_test.go index d1195f16b..f733b8391 100644 --- a/server/model/secret_test.go +++ b/server/model/secret_test.go @@ -30,7 +30,7 @@ func TestSecretValidate(t *testing.T) { Name: "secretname", Value: "secretvalue", Events: []WebhookEvent{EventPush}, - Images: []string{"docker.io/library/mysql:latest", "alpine:latest", "localregistry.test:8443/mysql:latest", "localregistry.test:8443/library/mysql:latest", "docker.io/library/mysql", "alpine", "localregistry.test:8443/mysql", "localregistry.test:8443/library/mysql"}, + Images: []string{"docker.io/library/mysql:latest", "alpine:latest", "localregistry.test:8443/mysql:latest", "localregistry.test:8443/library/mysql:latest", "docker.io/library/mysql", "alpine", "localregistry.test:8443/mysql", "localregistry.test:8443/library/mysql", "code.thinkaboutit.tech/pandora/woodpecker-config-server.goapp"}, }, err: false, },