From 6d373daea0cb62ca3b895a39c1604eecbda90195 Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Fri, 28 Jul 2023 00:34:22 +0200 Subject: [PATCH] Handle case where there is no latest pipeline for GetBadge (#2042) address error 2 of #2036 --- server/api/badge.go | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/server/api/badge.go b/server/api/badge.go index c7443d9b6..e99bc1535 100644 --- a/server/api/badge.go +++ b/server/api/badge.go @@ -80,7 +80,9 @@ func GetBadge(c *gin.Context) { pipeline, err := _store.GetPipelineLast(repo, branch) if err != nil { - log.Warn().Err(err).Msg("") + if !errors.Is(err, types.RecordNotExist) { + log.Warn().Err(err).Msg("could not get last pipeline for badge") + } pipeline = nil } @@ -110,7 +112,12 @@ func GetCC(c *gin.Context) { } pipelines, err := _store.GetPipelineList(repo, &model.ListOptions{Page: 1, PerPage: 1}) - if err != nil || len(pipelines) == 0 { + if err != nil && !errors.Is(err, types.RecordNotExist) { + log.Warn().Err(err).Msg("could not get pipeline list") + c.AbortWithStatus(http.StatusInternalServerError) + return + } + if len(pipelines) == 0 { c.AbortWithStatus(http.StatusNotFound) return }