From 6460b4c96d990c3105e15e47874bb5c07e867110 Mon Sep 17 00:00:00 2001 From: 6543 <6543@obermui.de> Date: Mon, 19 Sep 2022 00:18:24 +0200 Subject: [PATCH] On Repo update, keep old "Clone" if update would empty it (#1170) (#1195) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fixed #1169 after debugging, I found that: if `Clone` in database is empty, before https://github.com/woodpecker-ci/woodpecker/blob/master/server/api/hook.go#L128, the `repo.Clone` be always unset, so clone is failed. This PR makes the empty `Clone` can't overwrite the value in database. Co-authored-by: 想出网名啦 --- server/model/repo.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/server/model/repo.go b/server/model/repo.go index 0d15ccb9b..9af873eb4 100644 --- a/server/model/repo.go +++ b/server/model/repo.go @@ -76,7 +76,9 @@ func (r *Repo) Update(from *Repo) { r.Avatar = from.Avatar r.Link = from.Link r.SCMKind = from.SCMKind - r.Clone = from.Clone + if len(from.Clone) > 0 { + r.Clone = from.Clone + } r.Branch = from.Branch if from.IsSCMPrivate != r.IsSCMPrivate { if from.IsSCMPrivate {