From 4bf5116a5215227c77f41ad79d1edd88b7e50660 Mon Sep 17 00:00:00 2001 From: qwerty287 <80460567+qwerty287@users.noreply.github.com> Date: Wed, 26 Feb 2025 17:11:34 +0200 Subject: [PATCH] Fix approval requirement if PR is closed (#4902) --- server/pipeline/gated.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/pipeline/gated.go b/server/pipeline/gated.go index 8804b8c2b..9c46d35e7 100644 --- a/server/pipeline/gated.go +++ b/server/pipeline/gated.go @@ -48,13 +48,13 @@ func needsApproval(repo *model.Repo, pipeline *model.Pipeline) bool { // repository requires approval for pull requests from forks case model.RequireApprovalForks: - if pipeline.Event == model.EventPull && pipeline.FromFork { + if (pipeline.Event == model.EventPull || pipeline.Event == model.EventPullClosed) && pipeline.FromFork { return true } // repository requires approval for pull requests case model.RequireApprovalPullRequests: - if pipeline.Event == model.EventPull { + if pipeline.Event == model.EventPull || pipeline.Event == model.EventPullClosed { return true }