From 9852b0a2909affa70258ddf858e5a49a693f85bb Mon Sep 17 00:00:00 2001 From: Trong Huu Nguyen Date: Fri, 9 Jun 2023 12:19:09 +0200 Subject: [PATCH] fix(handler/logout): ignore session validation errors; attempt to delete regardless --- pkg/handler/handler.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/handler/handler.go b/pkg/handler/handler.go index c5b299a..cd962d5 100644 --- a/pkg/handler/handler.go +++ b/pkg/handler/handler.go @@ -239,11 +239,11 @@ func (s *Standalone) logout(w http.ResponseWriter, r *http.Request, globalLogout var idToken string - sess, err := s.SessionManager.Get(r) - if err == nil && sess != nil { + sess, _ := s.SessionManager.Get(r) + if sess != nil { idToken = sess.IDToken() - err = s.SessionManager.Delete(r.Context(), sess) + err := s.SessionManager.Delete(r.Context(), sess) if err != nil && !errors.Is(err, session.ErrNotFound) { s.InternalError(w, r, fmt.Errorf("logout: destroying session: %w", err)) return