From 69ebd9270fc112d0f51537a3ff3442a9070775b0 Mon Sep 17 00:00:00 2001 From: Trong Huu Nguyen Date: Fri, 9 Sep 2022 10:18:39 +0200 Subject: [PATCH] refactor(handler/reverseproxy): improve log messages --- pkg/handler/reverseproxy/reverseproxy.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/pkg/handler/reverseproxy/reverseproxy.go b/pkg/handler/reverseproxy/reverseproxy.go index 59794e4..d348da0 100644 --- a/pkg/handler/reverseproxy/reverseproxy.go +++ b/pkg/handler/reverseproxy/reverseproxy.go @@ -1,6 +1,7 @@ package reverseproxy import ( + "context" "errors" "log" "net/http" @@ -44,7 +45,13 @@ func New(upstreamHost string) *ReverseProxy { }, ErrorHandler: func(w http.ResponseWriter, r *http.Request, err error) { logger := mw.LogEntryFrom(r) - logger.Warnf("reverseproxy: proxy error: %+v", err) + + msg := "reverseproxy: proxy error: %+v" + if errors.Is(err, context.Canceled) { + msg += " (incoming client connection or request was closed/disconnected before we could respond)" + } + + logger.Warnf(msg, err) w.WriteHeader(http.StatusBadGateway) }, ErrorLog: log.New(logrusErrorWriter{}, "reverseproxy: ", 0),