github/wonderwall
1
0
Fork 0
mirror of https://github.com/nais/wonderwall.git synced 2026-05-22 00:02:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(url): only add redirect query parameter if non-empty

Browse Source
This commit is contained in:
Trong Huu Nguyen
2023-09-25 14:14:28 +02:00
parent 337723150b
commit 61a641c8d7
3 changed files with 18 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/handler/reverseproxy_test.go
View File

@@ -133,7 +133,7 @@ func TestReverseProxy(t *testing.T) {
location, err := resp.Location()
assert.NoError(t, err)
assert.Equal(t, idp.RelyingPartyServer.URL+"/oauth2/login?redirect=%2F", location.String())
assert.Equal(t, idp.RelyingPartyServer.URL+"/oauth2/login", location.String())
})
}
})
@@ -152,7 +152,7 @@ func TestReverseProxy(t *testing.T) {
resp := get(t, rpClient, target)
assert.Equal(t, http.StatusUnauthorized, resp.StatusCode)
assert.Equal(t, idp.RelyingPartyServer.URL+"/oauth2/login?redirect=%2F", resp.Location.String())
assert.Equal(t, idp.RelyingPartyServer.URL+"/oauth2/login", resp.Location.String())
})
t.Run("with auto-login for navigation request without fetch metadata", func(t *testing.T) {