From 43c39c89adb68eea01db418da50acc627a8039ae Mon Sep 17 00:00:00 2001 From: Trong Huu Nguyen Date: Mon, 12 Sep 2022 09:37:40 +0200 Subject: [PATCH] refactor(handler/reverseproxy): skip logging for client context cancellation --- pkg/handler/reverseproxy/reverseproxy.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/pkg/handler/reverseproxy/reverseproxy.go b/pkg/handler/reverseproxy/reverseproxy.go index c35bb85..d45982c 100644 --- a/pkg/handler/reverseproxy/reverseproxy.go +++ b/pkg/handler/reverseproxy/reverseproxy.go @@ -46,13 +46,12 @@ func New(upstreamHost string) *ReverseProxy { ErrorHandler: func(w http.ResponseWriter, r *http.Request, err error) { logger := mw.LogEntryFrom(r) - msg := "reverseproxy: proxy error: %+v" if errors.Is(err, context.Canceled) { - msg += " (incoming client connection or request was closed/disconnected before we could respond)" + w.WriteHeader(499) + } else { + logger.Warnf("reverseproxy: proxy error: %+v", err) + w.WriteHeader(http.StatusBadGateway) } - - logger.Warnf(msg, err) - w.WriteHeader(http.StatusBadGateway) }, ErrorLog: log.New(logrusErrorWriter{}, "reverseproxy: ", 0), }