From 2d7adb55b5c6467ddc3446e95cd80283d332d1ba Mon Sep 17 00:00:00 2001 From: Kim Tore Jensen Date: Mon, 23 Aug 2021 11:01:30 +0200 Subject: [PATCH] remove unused session id --- pkg/router/router.go | 8 -------- 1 file changed, 8 deletions(-) diff --git a/pkg/router/router.go b/pkg/router/router.go index f9766b1..75ef0ef 100644 --- a/pkg/router/router.go +++ b/pkg/router/router.go @@ -46,7 +46,6 @@ type Handler struct { } type loginParams struct { - session string state string codeVerifier string url string @@ -61,15 +60,9 @@ func (h *Handler) LoginURL() (*loginParams, error) { codeVerifier := make([]byte, 64) nonce := make([]byte, 32) state := make([]byte, 32) - session := make([]byte, 32) var err error - _, err = io.ReadFull(rand.Reader, session) - if err != nil { - return nil, fmt.Errorf("failed to create session id: %w", err) - } - _, err = io.ReadFull(rand.Reader, state) if err != nil { return nil, fmt.Errorf("failed to create state: %w", err) @@ -109,7 +102,6 @@ func (h *Handler) LoginURL() (*loginParams, error) { u.RawQuery = v.Encode() return &loginParams{ - session: base64.RawURLEncoding.EncodeToString(session), state: base64.RawURLEncoding.EncodeToString(state), nonce: base64.RawURLEncoding.EncodeToString(nonce), codeVerifier: string(codeVerifier),