From 05c5da6bf677e1ec3aa5ec1df2884fca1aaff735 Mon Sep 17 00:00:00 2001 From: Trong Huu Nguyen Date: Wed, 29 Jan 2025 09:24:21 +0100 Subject: [PATCH] fix(middleware/tracing): check attribute types before setting them Co-authored-by: sindrerh2 --- pkg/middleware/tracing.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pkg/middleware/tracing.go b/pkg/middleware/tracing.go index f4fd30f..50c96ca 100644 --- a/pkg/middleware/tracing.go +++ b/pkg/middleware/tracing.go @@ -19,7 +19,12 @@ func Tracing(next http.Handler) http.Handler { attrs := httpinternal.Attributes(r) for k, v := range attrs { attrKey := "wonderwall." + k - span.SetAttributes(attribute.String(attrKey, fmt.Sprint(v))) + switch v := v.(type) { + case bool: + span.SetAttributes(attribute.Bool(attrKey, v)) + default: + span.SetAttributes(attribute.String(attrKey, fmt.Sprint(v))) + } } // Override request ID with trace ID if available.