mirror of
https://github.com/weaveworks/scope.git
synced 2026-03-04 10:41:14 +00:00
NewNodeMetadata -> MakeNodeMetadata. It doesn't return a pointer, so Make is more idiomatic. Invoke MakeNodeMetadata when necessary. The zero value for a NodeMetadata is no longer valid. Split MakeNodeMetadata to two constructors. MakeNodeMetadata when you don't have anything to prepopulate; MakeNodeMetadataWith when you do. Also, a fix to the tests in app. We unmarshal a RenderableNode struct, which has a JSON-ignored NodeMetadata field. The zero value is invalid, so we need to fix that before performing comparisons.
Experimental Code
- Code in this directory must always compile (enforced by CircleCI)
- This directory is ignored for testing but should lint cleanly
- Changes to code in this directory does not need to be PR'd