mirror of
https://github.com/weaveworks/scope.git
synced 2026-03-02 17:50:39 +00:00
The fixup() method was modifying a copy of its input, so you could get duplicate keys in the output. Change it to return the new slice. Thankfully this is rare: in most cases WithLatests() is called with fields that are not duplicates of existing ones.
179 lines
4.4 KiB
Go
179 lines
4.4 KiB
Go
package report_test
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/weaveworks/common/mtime"
|
|
"github.com/weaveworks/common/test"
|
|
"github.com/weaveworks/scope/report"
|
|
"github.com/weaveworks/scope/test/reflect"
|
|
)
|
|
|
|
const (
|
|
PID = "pid"
|
|
Name = "name"
|
|
Domain = "domain"
|
|
)
|
|
|
|
func TestWithLatest(t *testing.T) {
|
|
mtime.NowForce(time.Now())
|
|
defer mtime.NowReset()
|
|
|
|
latests1 := map[string]string{Name: "x"}
|
|
latests2 := map[string]string{PID: "123"}
|
|
node1 := report.MakeNode("node1").WithLatests(latests1)
|
|
assert.Equal(t, 1, node1.Latest.Len())
|
|
node2 := node1.WithLatests(latests1)
|
|
assert.Equal(t, node1, node2)
|
|
node3 := node1.WithLatests(latests2)
|
|
assert.Equal(t, 2, node3.Latest.Len())
|
|
node4 := node1.WithLatests(latests2)
|
|
assert.Equal(t, node3, node4)
|
|
}
|
|
|
|
func TestMergeNodes(t *testing.T) {
|
|
mtime.NowForce(time.Now())
|
|
defer mtime.NowReset()
|
|
|
|
for name, c := range map[string]struct {
|
|
a, b, want report.Nodes
|
|
}{
|
|
"Empty a": {
|
|
a: report.Nodes{},
|
|
b: report.Nodes{
|
|
":192.168.1.1:12345": report.MakeNodeWith(":192.168.1.1:12345", map[string]string{
|
|
PID: "23128",
|
|
Name: "curl",
|
|
Domain: "node-a.local",
|
|
}),
|
|
},
|
|
want: report.Nodes{
|
|
":192.168.1.1:12345": report.MakeNodeWith(":192.168.1.1:12345", map[string]string{
|
|
PID: "23128",
|
|
Name: "curl",
|
|
Domain: "node-a.local",
|
|
}),
|
|
},
|
|
},
|
|
"Empty b": {
|
|
a: report.Nodes{
|
|
":192.168.1.1:12345": report.MakeNodeWith(":192.168.1.1:12345", map[string]string{
|
|
PID: "23128",
|
|
Name: "curl",
|
|
Domain: "node-a.local",
|
|
}),
|
|
},
|
|
b: report.Nodes{},
|
|
want: report.Nodes{
|
|
":192.168.1.1:12345": report.MakeNodeWith(":192.168.1.1:12345", map[string]string{
|
|
PID: "23128",
|
|
Name: "curl",
|
|
Domain: "node-a.local",
|
|
}),
|
|
},
|
|
},
|
|
"Simple merge": {
|
|
a: report.Nodes{
|
|
":192.168.1.1:12345": report.MakeNodeWith(":192.168.1.1:12345", map[string]string{
|
|
PID: "23128",
|
|
Name: "curl",
|
|
Domain: "node-a.local",
|
|
}),
|
|
},
|
|
b: report.Nodes{
|
|
":192.168.1.2:12345": report.MakeNodeWith(":192.168.1.2:12345", map[string]string{
|
|
PID: "42",
|
|
Name: "curl",
|
|
Domain: "node-a.local",
|
|
}),
|
|
},
|
|
want: report.Nodes{
|
|
":192.168.1.1:12345": report.MakeNodeWith(":192.168.1.1:12345", map[string]string{
|
|
PID: "23128",
|
|
Name: "curl",
|
|
Domain: "node-a.local",
|
|
}),
|
|
":192.168.1.2:12345": report.MakeNodeWith(":192.168.1.2:12345", map[string]string{
|
|
PID: "42",
|
|
Name: "curl",
|
|
Domain: "node-a.local",
|
|
}),
|
|
},
|
|
},
|
|
"Merge conflict with rank difference": {
|
|
a: report.Nodes{
|
|
":192.168.1.1:12345": report.MakeNodeWith(":192.168.1.1:12345", map[string]string{
|
|
PID: "23128",
|
|
Name: "curl",
|
|
Domain: "node-a.local",
|
|
}),
|
|
},
|
|
b: report.Nodes{
|
|
":192.168.1.1:12345": report.MakeNodeWith(":192.168.1.1:12345", map[string]string{ // <-- same ID
|
|
Name: "curl",
|
|
Domain: "node-a.local",
|
|
}).WithLatest(PID, time.Now().Add(-1*time.Minute), "0"),
|
|
},
|
|
want: report.Nodes{
|
|
":192.168.1.1:12345": report.MakeNodeWith(":192.168.1.1:12345", map[string]string{
|
|
PID: "23128",
|
|
Name: "curl",
|
|
Domain: "node-a.local",
|
|
}),
|
|
},
|
|
},
|
|
"Merge conflict with no rank difference": {
|
|
a: report.Nodes{
|
|
":192.168.1.1:12345": report.MakeNodeWith(":192.168.1.1:12345", map[string]string{
|
|
PID: "23128",
|
|
Name: "curl",
|
|
Domain: "node-a.local",
|
|
}),
|
|
},
|
|
b: report.Nodes{
|
|
":192.168.1.1:12345": report.MakeNodeWith(":192.168.1.1:12345", map[string]string{ // <-- same ID
|
|
Name: "curl",
|
|
Domain: "node-a.local",
|
|
}).WithLatest(PID, time.Now().Add(-1*time.Minute), "0"),
|
|
},
|
|
want: report.Nodes{
|
|
":192.168.1.1:12345": report.MakeNodeWith(":192.168.1.1:12345", map[string]string{
|
|
PID: "23128",
|
|
Name: "curl",
|
|
Domain: "node-a.local",
|
|
}),
|
|
},
|
|
},
|
|
"Counters": {
|
|
a: report.Nodes{
|
|
"1": report.MakeNode("1").WithCounters(map[string]int{
|
|
"a": 13,
|
|
"b": 57,
|
|
"c": 89,
|
|
}),
|
|
},
|
|
b: report.Nodes{
|
|
"1": report.MakeNode("1").WithCounters(map[string]int{
|
|
"a": 78,
|
|
"b": 3,
|
|
"d": 47,
|
|
}),
|
|
},
|
|
want: report.Nodes{
|
|
"1": report.MakeNode("1").WithCounters(map[string]int{
|
|
"a": 91,
|
|
"b": 60,
|
|
"c": 89,
|
|
"d": 47,
|
|
}),
|
|
},
|
|
},
|
|
} {
|
|
if have := c.a.Merge(c.b); !reflect.DeepEqual(c.want, have) {
|
|
t.Errorf("%s: %s", name, test.Diff(c.want, have))
|
|
}
|
|
}
|
|
}
|