mirror of
https://github.com/weaveworks/scope.git
synced 2026-03-03 18:20:27 +00:00
3d3aed2bb3
Squash of: * We have to keep all the container hostnames until the end so we can count how many we've filtered * Adding tests for ContainerHostnameRenderer and PodServiceRenderer with filters * Because we filter on image name we need the image name before filtering * Alternative approach to passing decorators. * Refactor out some of the decorator capture * Don't memoise decorated calls to Render * Fixing filtered counts on containers topology Tricky, because we need the filters to be silent sometimes (when they're in the middle), but not when they're at the top, so we take the "top" filter's stats. However, this means we have to compose all user-specified filters into a single Filter layer, so we can get all stats. There are no more Silent filters, as all filters are silent (unless they are at the top). Additionally, I clarified some of the filters as their usage/terminology was inconsistent and confused. Now Filter(IsFoo, ...) *keeps* only nodes where IsFoo is true.
61 lines
1.7 KiB
Go
61 lines
1.7 KiB
Go
package render_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/weaveworks/scope/render"
|
|
"github.com/weaveworks/scope/report"
|
|
"github.com/weaveworks/scope/test"
|
|
"github.com/weaveworks/scope/test/reflect"
|
|
)
|
|
|
|
type renderFunc func(r report.Report) report.Nodes
|
|
|
|
func (f renderFunc) Render(r report.Report, _ render.Decorator) report.Nodes { return f(r) }
|
|
func (f renderFunc) Stats(r report.Report, _ render.Decorator) render.Stats { return render.Stats{} }
|
|
|
|
func TestMemoise(t *testing.T) {
|
|
calls := 0
|
|
r := renderFunc(func(rpt report.Report) report.Nodes {
|
|
calls++
|
|
return report.Nodes{rpt.ID: report.MakeNode(rpt.ID)}
|
|
})
|
|
m := render.Memoise(r)
|
|
rpt1 := report.MakeReport()
|
|
|
|
result1 := m.Render(rpt1, nil)
|
|
// it should have rendered it.
|
|
if _, ok := result1[rpt1.ID]; !ok {
|
|
t.Errorf("Expected rendered report to contain a node, but got: %v", result1)
|
|
}
|
|
if calls != 1 {
|
|
t.Errorf("Expected renderer to have been called the first time")
|
|
}
|
|
|
|
result2 := m.Render(rpt1, nil)
|
|
if !reflect.DeepEqual(result1, result2) {
|
|
t.Errorf("Expected memoised result to be returned: %s", test.Diff(result1, result2))
|
|
}
|
|
if calls != 1 {
|
|
t.Errorf("Expected renderer to not have been called the second time")
|
|
}
|
|
|
|
rpt2 := report.MakeReport()
|
|
result3 := m.Render(rpt2, nil)
|
|
if reflect.DeepEqual(result1, result3) {
|
|
t.Errorf("Expected different result for different report, but were the same")
|
|
}
|
|
if calls != 2 {
|
|
t.Errorf("Expected renderer to have been called again for a different report")
|
|
}
|
|
|
|
render.ResetCache()
|
|
result4 := m.Render(rpt1, nil)
|
|
if !reflect.DeepEqual(result1, result4) {
|
|
t.Errorf("Expected original result to be returned: %s", test.Diff(result1, result4))
|
|
}
|
|
if calls != 3 {
|
|
t.Errorf("Expected renderer to have been called again after cache reset")
|
|
}
|
|
}
|