Matthias Radestock 15b605f804 make process-by-name topology show something (again) ...

...when 'Hide Unconnected' is selected, which is the default.

Here's the problem...

The connectedness filter looks for `is_connected` marks in the Latest
map of the nodes. The mark is added by ColorConnected, which is
invoked by ProcessRenderer. That in turn is the base renderer for
ProcessNameRenderer, which is what the process-by-name view
renders. However, the process2Names mapping does not propagate any
metadata, hence there are no `is_connected` marks on the result
nodes. Consequently they are all filtered out.

The problem was introduced in #3009, when I added the ability for
users to chose whether to show or hide unconnected
processes (previously unconnected processes were always hidden) -
looks like I failed to check that the process-by-name view was working
with the new filter. Oops.

The fix is to move the ColorConnected call from ProcessRenderer to the
higher-level renderers - ProcessWithContainerNameRenderer (which is
what the 'Processes' view renders) and ProcessNameRenderer.

This has the beneficial side effect of improving performance for other
renderers which invoke ProcessRenderer, none of which need
connectedness-coloring.

Fixes #3205

2018-06-03 07:01:40 +01:00

..

detailed

Sentence cased text everywhere (#3166)

2018-05-17 17:30:38 -07:00

expected

Use image name without version as id. (#1531)

2016-06-15 16:14:51 +01:00

benchmark_test.go

do not report allocations in benchmarks

2017-12-07 20:27:31 +00:00

container_test.go

MapFunc is now Node->Node

2018-04-09 13:16:40 +00:00

container.go

Addressed @LiliC's feedback.

2018-05-17 11:43:54 +02:00

ecs.go

memoise shared top-level renderers

2017-11-04 23:05:52 +00:00

endpoint.go

Move DNS name mapping from endpoint to report

2018-02-20 16:14:21 +00:00

filters_test.go

remove filtering of unconnected pseudo nodes from ordinary filters

2017-11-28 06:54:15 +00:00

filters.go

optimisation: no need to prune adjacencies in filterUnconnected

2018-01-02 06:41:19 +00:00

host_test.go

refactor: remove Decorator from render.Renderer.Render() signature

2017-11-18 18:04:52 +00:00

host.go

refactor: extract common code in endpoint mapping

2018-01-07 08:20:06 +00:00

id.go

Move DNS name mapping from endpoint to report

2018-02-20 16:14:21 +00:00

memoise_test.go

optimisation: make Memoise(Memoise(...)) only memoise once

2017-11-23 17:03:33 +00:00

memoise.go

optimisation: make Memoise(Memoise(...)) only memoise once

2017-11-23 17:03:33 +00:00

metrics_test.go

refactor: make PropagateSingleMetrics a renderer

2017-12-28 20:04:01 +00:00

metrics.go

fly-by optimisation

2017-12-28 20:04:01 +00:00

pod_test.go

remove filtering of unconnected pseudo nodes from ordinary filters

2017-11-28 06:54:15 +00:00

pod.go

Turn Map2Parent into a Renderer

2018-04-09 13:16:40 +00:00

process_test.go

refactor: remove Decorator from render.Renderer.Render() signature

2017-11-18 18:04:52 +00:00

process.go

make process-by-name topology show something (again)

2018-06-03 07:01:40 +01:00

render_test.go

MapFunc is now Node->Node

2018-04-09 13:16:40 +00:00

render.go

Comment inconsistency between calls in joinResults

2018-04-15 09:39:43 +00:00

report.json

Use ps.Map for Counters and Sets, remove Metadata in favour of Latest.

2016-01-22 15:10:32 -08:00

selectors.go

refactor: remove Decorator from render.Renderer.Render() signature

2017-11-18 18:04:52 +00:00

short_lived_connections_test.go

refactor: remove Decorator from render.Renderer.Render() signature

2017-11-18 18:04:52 +00:00

swarm.go

memoise shared top-level renderers

2017-11-04 23:05:52 +00:00

theinternet_test.go

refactor: rename report.NewNetworks to MakeNetworks

2017-07-03 01:26:22 +01:00

theinternet.go

Add (cloud.)weave.works to the list of known services

2018-02-22 17:19:55 +00:00

weave.go

MapFunc is now Node->Node

2018-04-09 13:16:40 +00:00