mirror of
https://github.com/weaveworks/scope.git
synced 2026-05-06 01:08:03 +00:00
a306867610
The rendering code checks whether endpoint IPs are part of cluster-local networks. Due to the prevalence of endpoints - medium sized reports can contain many thousands of endpoints - this is performance critical. Alas the existing code performs the check via a linear scan of a list of networks. That is slow when there are more than a few, which will be the case in the context of k8s, since there the probes register service IPs as local /32 networks. Here we change representation of the set of networks to a prefix tree (aka trie), which is well-suited for IP network membership checks since networks are in fact a bitstring prefixes. The specific representation is a crit-bit tree, but that choice was purely based on implementation convenience - the chosen library is the only one I could find that directly supports IP networks.
43 lines
1.1 KiB
Go
43 lines
1.1 KiB
Go
package render_test
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/weaveworks/common/test"
|
|
"github.com/weaveworks/scope/probe/host"
|
|
"github.com/weaveworks/scope/render"
|
|
"github.com/weaveworks/scope/report"
|
|
)
|
|
|
|
func TestReportLocalNetworks(t *testing.T) {
|
|
r := report.MakeReport().Merge(report.Report{
|
|
Host: report.Topology{
|
|
Nodes: report.Nodes{
|
|
"nonets": report.MakeNode("nonets"),
|
|
"foo": report.MakeNode("foo").WithSets(report.EmptySets.
|
|
Add(host.LocalNetworks, report.MakeStringSet(
|
|
"10.0.0.1/8", "192.168.1.1/24", "10.0.0.1/8", "badnet/33")),
|
|
),
|
|
},
|
|
},
|
|
Overlay: report.Topology{
|
|
Nodes: report.Nodes{
|
|
"router": report.MakeNode("router").WithSets(report.EmptySets.
|
|
Add(host.LocalNetworks, report.MakeStringSet("10.32.0.1/12")),
|
|
),
|
|
},
|
|
},
|
|
})
|
|
want := report.NewNetworks()
|
|
for _, cidr := range []string{"10.0.0.1/8", "192.168.1.1/24", "10.32.0.1/12"} {
|
|
if err := want.AddCIDR(cidr); err != nil {
|
|
panic(err)
|
|
}
|
|
}
|
|
have := render.LocalNetworks(r)
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Errorf("%s", test.Diff(want, have))
|
|
}
|
|
}
|