mirror of
https://github.com/weaveworks/scope.git
synced 2026-03-05 11:11:13 +00:00
d0b99969ea
- Change scrolling behaviour to lock headers in place
- Enable filtering (hitting enter in the search bar) in grid-mode
- Little more top-margin for k8s (can have 3 topos) + taller rows.
- Trying out rank-color + node.relatives in the grid-mode
- First pass at selecting rows.
- Needs a bit more a fiddle, colors + click areas
- Store grid sort direction (asc/desc) in url state
- Simplify node selection to one method. (over-ride existing card)
- Remove clicking on name directly (links) to overlay new cards for now.
- Playing w/ grid-mode-toggle icons and labels
- Improves rendering in ff, change of shortcut keys for grid-mode-toggle
- Playing w/ clearer selection colors for grid-mode
- Slight change to selection-ui
- Fixes showNodeInTopology button visibility on the details-panel
- Was using an old heuristic. Table-mode allows you to open child cards
before the parent.
- Make it clear what the default sort is in tables
- E.g. always show a sorting caret
- Sort grid-mode columns, first meta then metrics
- dancing-nodes rememdy #1: pause updates onRowHover
- Splits relatives out into their own columns
- Take into account scrollbar width for grid-mode col header position
- Tooltips on table column headers
- grid-mode: fixes first column headers (proc/container/c-by-image)
- Disable pause-on-hover, too aggresive
- reduce label column width a bit (33pc -> 25pc) for big tables
- Filter grid-mode onSearchChange
- Rather than previous behaviour of waiting for an <enter>
- Show label_minor on pseudo nodes, that might not have much other info
- grid-mode: further reduce width of id column.
- Fixes go tests, properly moves parents into node-summary
- Fixes sorting of string columns w/ missing fields.
- E.g. uptime. Where -1e-10 > '3days' doesn't work.
431 lines
12 KiB
Go
431 lines
12 KiB
Go
package detailed_test
|
|
|
|
import (
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/weaveworks/scope/probe/docker"
|
|
"github.com/weaveworks/scope/probe/host"
|
|
"github.com/weaveworks/scope/probe/kubernetes"
|
|
"github.com/weaveworks/scope/probe/process"
|
|
"github.com/weaveworks/scope/render"
|
|
"github.com/weaveworks/scope/render/detailed"
|
|
"github.com/weaveworks/scope/render/expected"
|
|
"github.com/weaveworks/scope/report"
|
|
"github.com/weaveworks/scope/test"
|
|
"github.com/weaveworks/scope/test/fixture"
|
|
"github.com/weaveworks/scope/test/reflect"
|
|
)
|
|
|
|
func child(t *testing.T, r render.Renderer, id string) detailed.NodeSummary {
|
|
s, ok := detailed.MakeNodeSummary(fixture.Report, r.Render(fixture.Report, nil)[id])
|
|
if !ok {
|
|
t.Fatalf("Expected node %s to be summarizable, but wasn't", id)
|
|
}
|
|
return s.SummarizeMetrics()
|
|
}
|
|
|
|
func TestMakeDetailedHostNode(t *testing.T) {
|
|
renderableNodes := render.HostRenderer.Render(fixture.Report, nil)
|
|
renderableNode := renderableNodes[fixture.ClientHostNodeID]
|
|
have := detailed.MakeNode("hosts", fixture.Report, renderableNodes, renderableNode)
|
|
|
|
containerImageNodeSummary := child(t, render.ContainerImageRenderer, expected.ClientContainerImageNodeID)
|
|
containerNodeSummary := child(t, render.ContainerRenderer, fixture.ClientContainerNodeID)
|
|
process1NodeSummary := child(t, render.ProcessRenderer, fixture.ClientProcess1NodeID)
|
|
process1NodeSummary.Linkable = true
|
|
process2NodeSummary := child(t, render.ProcessRenderer, fixture.ClientProcess2NodeID)
|
|
process2NodeSummary.Linkable = true
|
|
podNodeSummary := child(t, render.PodRenderer, fixture.ClientPodNodeID)
|
|
want := detailed.Node{
|
|
NodeSummary: detailed.NodeSummary{
|
|
ID: fixture.ClientHostNodeID,
|
|
Label: "client",
|
|
LabelMinor: "hostname.com",
|
|
Rank: "hostname.com",
|
|
Pseudo: false,
|
|
Shape: "circle",
|
|
Linkable: true,
|
|
Adjacency: report.MakeIDList(fixture.ServerHostNodeID),
|
|
Metadata: []report.MetadataRow{
|
|
{
|
|
ID: "host_name",
|
|
Label: "Hostname",
|
|
Value: "client.hostname.com",
|
|
Priority: 11,
|
|
},
|
|
{
|
|
ID: "os",
|
|
Label: "OS",
|
|
Value: "Linux",
|
|
Priority: 12,
|
|
},
|
|
{
|
|
ID: "local_networks",
|
|
Label: "Local Networks",
|
|
Value: "10.10.10.0/24",
|
|
Priority: 13,
|
|
},
|
|
},
|
|
Metrics: []report.MetricRow{
|
|
{
|
|
ID: host.CPUUsage,
|
|
Label: "CPU",
|
|
Format: "percent",
|
|
Value: 0.07,
|
|
Priority: 1,
|
|
Metric: &fixture.ClientHostCPUMetric,
|
|
},
|
|
{
|
|
ID: host.MemoryUsage,
|
|
Label: "Memory",
|
|
Format: "filesize",
|
|
Value: 0.08,
|
|
Priority: 2,
|
|
Metric: &fixture.ClientHostMemoryMetric,
|
|
},
|
|
{
|
|
ID: host.Load1,
|
|
Label: "Load (1m)",
|
|
Group: "load",
|
|
Value: 0.09,
|
|
Priority: 11,
|
|
Metric: &fixture.ClientHostLoad1Metric,
|
|
},
|
|
},
|
|
},
|
|
Controls: []detailed.ControlInstance{},
|
|
Children: []detailed.NodeSummaryGroup{
|
|
{
|
|
Label: "Pods",
|
|
TopologyID: "pods",
|
|
Columns: []detailed.Column{
|
|
{ID: kubernetes.State, Label: "State"},
|
|
{ID: report.Container, Label: "Containers"},
|
|
{ID: kubernetes.IP, Label: "IP"},
|
|
},
|
|
Nodes: []detailed.NodeSummary{podNodeSummary},
|
|
},
|
|
{
|
|
Label: "Containers",
|
|
TopologyID: "containers",
|
|
Columns: []detailed.Column{
|
|
{ID: docker.CPUTotalUsage, Label: "CPU"},
|
|
{ID: docker.MemoryUsage, Label: "Memory"},
|
|
},
|
|
Nodes: []detailed.NodeSummary{containerNodeSummary},
|
|
},
|
|
{
|
|
Label: "Processes",
|
|
TopologyID: "processes",
|
|
Columns: []detailed.Column{
|
|
{ID: process.PID, Label: "PID"},
|
|
{ID: process.CPUUsage, Label: "CPU"},
|
|
{ID: process.MemoryUsage, Label: "Memory"},
|
|
},
|
|
Nodes: []detailed.NodeSummary{process1NodeSummary, process2NodeSummary},
|
|
},
|
|
{
|
|
Label: "Container Images",
|
|
TopologyID: "containers-by-image",
|
|
Columns: []detailed.Column{
|
|
{ID: report.Container, Label: "# Containers", DefaultSort: true},
|
|
},
|
|
Nodes: []detailed.NodeSummary{containerImageNodeSummary},
|
|
},
|
|
},
|
|
Connections: []detailed.ConnectionsSummary{
|
|
{
|
|
ID: "incoming-connections",
|
|
TopologyID: "hosts",
|
|
Label: "Inbound",
|
|
Columns: detailed.NormalColumns,
|
|
Connections: []detailed.Connection{},
|
|
},
|
|
{
|
|
ID: "outgoing-connections",
|
|
TopologyID: "hosts",
|
|
Label: "Outbound",
|
|
Columns: detailed.NormalColumns,
|
|
Connections: []detailed.Connection{
|
|
{
|
|
ID: fmt.Sprintf("%s:%s-%s:%s-%d", fixture.ServerHostNodeID, "", fixture.ClientHostNodeID, "", 80),
|
|
NodeID: fixture.ServerHostNodeID,
|
|
Label: "server",
|
|
Linkable: true,
|
|
Metadata: []report.MetadataRow{
|
|
{
|
|
ID: "port",
|
|
Value: "80",
|
|
Datatype: "number",
|
|
},
|
|
{
|
|
ID: "count",
|
|
Value: "2",
|
|
Datatype: "number",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
}
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Errorf("%s", test.Diff(want, have))
|
|
}
|
|
}
|
|
|
|
func TestMakeDetailedContainerNode(t *testing.T) {
|
|
id := fixture.ServerContainerNodeID
|
|
renderableNodes := render.ContainerWithImageNameRenderer.Render(fixture.Report, nil)
|
|
renderableNode, ok := renderableNodes[id]
|
|
if !ok {
|
|
t.Fatalf("Node not found: %s", id)
|
|
}
|
|
have := detailed.MakeNode("containers", fixture.Report, renderableNodes, renderableNode)
|
|
|
|
serverProcessNodeSummary := child(t, render.ProcessRenderer, fixture.ServerProcessNodeID)
|
|
serverProcessNodeSummary.Linkable = true
|
|
want := detailed.Node{
|
|
NodeSummary: detailed.NodeSummary{
|
|
ID: id,
|
|
Label: "server",
|
|
LabelMinor: "server.hostname.com",
|
|
Rank: fixture.ServerContainerImageName,
|
|
Shape: "hexagon",
|
|
Linkable: true,
|
|
Pseudo: false,
|
|
Metadata: []report.MetadataRow{
|
|
{ID: "docker_container_id", Label: "ID", Value: fixture.ServerContainerID, Priority: 1},
|
|
{ID: "docker_container_state_human", Label: "State", Value: "running", Priority: 2},
|
|
{ID: "docker_image_id", Label: "Image ID", Value: fixture.ServerContainerImageID, Priority: 11},
|
|
},
|
|
Metrics: []report.MetricRow{
|
|
{
|
|
ID: docker.CPUTotalUsage,
|
|
Label: "CPU",
|
|
Format: "percent",
|
|
Value: 0.05,
|
|
Priority: 1,
|
|
Metric: &fixture.ServerContainerCPUMetric,
|
|
},
|
|
{
|
|
ID: docker.MemoryUsage,
|
|
Label: "Memory",
|
|
Format: "filesize",
|
|
Value: 0.06,
|
|
Priority: 2,
|
|
Metric: &fixture.ServerContainerMemoryMetric,
|
|
},
|
|
},
|
|
Parents: []detailed.Parent{
|
|
{
|
|
ID: expected.ServerContainerImageNodeID,
|
|
Label: fixture.ServerContainerImageName,
|
|
TopologyID: "containers-by-image",
|
|
},
|
|
{
|
|
ID: fixture.ServerHostNodeID,
|
|
Label: fixture.ServerHostName,
|
|
TopologyID: "hosts",
|
|
},
|
|
{
|
|
ID: fixture.ServerPodNodeID,
|
|
Label: "pong-b",
|
|
TopologyID: "pods",
|
|
},
|
|
},
|
|
},
|
|
Controls: []detailed.ControlInstance{},
|
|
Children: []detailed.NodeSummaryGroup{
|
|
{
|
|
Label: "Processes",
|
|
TopologyID: "processes",
|
|
Columns: []detailed.Column{
|
|
{ID: process.PID, Label: "PID"},
|
|
{ID: process.CPUUsage, Label: "CPU"},
|
|
{ID: process.MemoryUsage, Label: "Memory"},
|
|
},
|
|
Nodes: []detailed.NodeSummary{serverProcessNodeSummary},
|
|
},
|
|
},
|
|
Connections: []detailed.ConnectionsSummary{
|
|
{
|
|
ID: "incoming-connections",
|
|
TopologyID: "containers",
|
|
Label: "Inbound",
|
|
Columns: detailed.NormalColumns,
|
|
Connections: []detailed.Connection{
|
|
{
|
|
ID: fmt.Sprintf("%s:%s-%s:%s-%d", fixture.ClientContainerNodeID, "", fixture.ServerContainerNodeID, "", 80),
|
|
NodeID: fixture.ClientContainerNodeID,
|
|
Label: "client",
|
|
Linkable: true,
|
|
Metadata: []report.MetadataRow{
|
|
{
|
|
ID: "port",
|
|
Value: "80",
|
|
Datatype: "number",
|
|
},
|
|
{
|
|
ID: "count",
|
|
Value: "2",
|
|
Datatype: "number",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
ID: fmt.Sprintf("%s:%s-%s:%s-%d", render.IncomingInternetID, "", fixture.ServerContainerNodeID, "", 80),
|
|
NodeID: render.IncomingInternetID,
|
|
Label: render.InboundMajor,
|
|
Linkable: true,
|
|
Metadata: []report.MetadataRow{
|
|
{
|
|
ID: "port",
|
|
Value: "80",
|
|
Datatype: "number",
|
|
},
|
|
{
|
|
ID: "count",
|
|
Value: "1",
|
|
Datatype: "number",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
ID: "outgoing-connections",
|
|
TopologyID: "containers",
|
|
Label: "Outbound",
|
|
Columns: detailed.NormalColumns,
|
|
Connections: []detailed.Connection{},
|
|
},
|
|
},
|
|
}
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Errorf("%s", test.Diff(want, have))
|
|
}
|
|
}
|
|
|
|
func TestMakeDetailedPodNode(t *testing.T) {
|
|
id := fixture.ServerPodNodeID
|
|
renderableNodes := render.PodRenderer.Render(fixture.Report, nil)
|
|
renderableNode, ok := renderableNodes[id]
|
|
if !ok {
|
|
t.Fatalf("Node not found: %s", id)
|
|
}
|
|
have := detailed.MakeNode("pods", fixture.Report, renderableNodes, renderableNode)
|
|
|
|
containerNodeSummary := child(t, render.ContainerWithImageNameRenderer, fixture.ServerContainerNodeID)
|
|
serverProcessNodeSummary := child(t, render.ProcessRenderer, fixture.ServerProcessNodeID)
|
|
serverProcessNodeSummary.Linkable = true // Temporary workaround for: https://github.com/weaveworks/scope/issues/1295
|
|
want := detailed.Node{
|
|
NodeSummary: detailed.NodeSummary{
|
|
ID: id,
|
|
Label: "pong-b",
|
|
LabelMinor: "1 container",
|
|
Rank: "ping/pong-b",
|
|
Shape: "heptagon",
|
|
Linkable: true,
|
|
Pseudo: false,
|
|
Metadata: []report.MetadataRow{
|
|
{ID: "kubernetes_id", Label: "ID", Value: "ping/pong-b", Priority: 1},
|
|
{ID: "kubernetes_state", Label: "State", Value: "running", Priority: 2},
|
|
{ID: "container", Label: "# Containers", Value: "1", Priority: 4, Datatype: "number"},
|
|
{ID: "kubernetes_namespace", Label: "Namespace", Value: "ping", Priority: 5},
|
|
},
|
|
Parents: []detailed.Parent{
|
|
{
|
|
ID: fixture.ServerHostNodeID,
|
|
Label: fixture.ServerHostName,
|
|
TopologyID: "hosts",
|
|
},
|
|
{
|
|
ID: fixture.ServiceNodeID,
|
|
Label: fixture.ServiceName,
|
|
TopologyID: "services",
|
|
},
|
|
},
|
|
},
|
|
Controls: []detailed.ControlInstance{},
|
|
Children: []detailed.NodeSummaryGroup{
|
|
{
|
|
Label: "Containers",
|
|
TopologyID: "containers",
|
|
Columns: []detailed.Column{
|
|
{ID: docker.CPUTotalUsage, Label: "CPU"},
|
|
{ID: docker.MemoryUsage, Label: "Memory"},
|
|
},
|
|
Nodes: []detailed.NodeSummary{containerNodeSummary},
|
|
},
|
|
{
|
|
Label: "Processes",
|
|
TopologyID: "processes",
|
|
Columns: []detailed.Column{
|
|
{ID: process.PID, Label: "PID"},
|
|
{ID: process.CPUUsage, Label: "CPU"},
|
|
{ID: process.MemoryUsage, Label: "Memory"},
|
|
},
|
|
Nodes: []detailed.NodeSummary{serverProcessNodeSummary},
|
|
},
|
|
},
|
|
Connections: []detailed.ConnectionsSummary{
|
|
{
|
|
ID: "incoming-connections",
|
|
TopologyID: "pods",
|
|
Label: "Inbound",
|
|
Columns: detailed.NormalColumns,
|
|
Connections: []detailed.Connection{
|
|
{
|
|
ID: fmt.Sprintf("%s:%s-%s:%s-%d", fixture.ClientPodNodeID, "", fixture.ServerPodNodeID, "", 80),
|
|
NodeID: fixture.ClientPodNodeID,
|
|
Label: "pong-a",
|
|
Linkable: true,
|
|
Metadata: []report.MetadataRow{
|
|
{
|
|
ID: "port",
|
|
Value: "80",
|
|
Datatype: "number",
|
|
},
|
|
{
|
|
ID: "count",
|
|
Value: "2",
|
|
Datatype: "number",
|
|
},
|
|
},
|
|
},
|
|
{
|
|
ID: fmt.Sprintf("%s:%s-%s:%s-%d", render.IncomingInternetID, "", fixture.ServerPodNodeID, "", 80),
|
|
NodeID: render.IncomingInternetID,
|
|
Label: render.InboundMajor,
|
|
Linkable: true,
|
|
Metadata: []report.MetadataRow{
|
|
{
|
|
ID: "port",
|
|
Value: "80",
|
|
Datatype: "number",
|
|
},
|
|
{
|
|
ID: "count",
|
|
Value: "1",
|
|
Datatype: "number",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
{
|
|
ID: "outgoing-connections",
|
|
TopologyID: "pods",
|
|
Label: "Outbound",
|
|
Columns: detailed.NormalColumns,
|
|
Connections: []detailed.Connection{},
|
|
},
|
|
},
|
|
}
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Errorf("%s", test.Diff(want, have))
|
|
}
|
|
}
|