mirror of
https://github.com/weaveworks/scope.git
synced 2026-03-03 10:11:03 +00:00
Squash of: * We have to keep all the container hostnames until the end so we can count how many we've filtered * Adding tests for ContainerHostnameRenderer and PodServiceRenderer with filters * Because we filter on image name we need the image name before filtering * Alternative approach to passing decorators. * Refactor out some of the decorator capture * Don't memoise decorated calls to Render * Fixing filtered counts on containers topology Tricky, because we need the filters to be silent sometimes (when they're in the middle), but not when they're at the top, so we take the "top" filter's stats. However, this means we have to compose all user-specified filters into a single Filter layer, so we can get all stats. There are no more Silent filters, as all filters are silent (unless they are at the top). Additionally, I clarified some of the filters as their usage/terminology was inconsistent and confused. Now Filter(IsFoo, ...) *keeps* only nodes where IsFoo is true.
163 lines
5.5 KiB
Go
163 lines
5.5 KiB
Go
package render_test
|
|
|
|
import (
|
|
"fmt"
|
|
"net"
|
|
"testing"
|
|
|
|
"github.com/weaveworks/scope/probe/docker"
|
|
"github.com/weaveworks/scope/probe/process"
|
|
"github.com/weaveworks/scope/render"
|
|
"github.com/weaveworks/scope/render/expected"
|
|
"github.com/weaveworks/scope/report"
|
|
"github.com/weaveworks/scope/test"
|
|
"github.com/weaveworks/scope/test/fixture"
|
|
"github.com/weaveworks/scope/test/reflect"
|
|
)
|
|
|
|
func TestMapProcess2Container(t *testing.T) {
|
|
for _, input := range []testcase{
|
|
{"empty", report.MakeNode("empty"), true},
|
|
{"basic process", report.MakeNodeWith("basic", map[string]string{process.PID: "201", docker.ContainerID: "a1b2c3"}), true},
|
|
{"uncontained", report.MakeNodeWith("uncontained", map[string]string{process.PID: "201", report.HostNodeID: report.MakeHostNodeID("foo")}), true},
|
|
} {
|
|
testMap(t, render.MapProcess2Container, input)
|
|
}
|
|
}
|
|
|
|
type testcase struct {
|
|
name string
|
|
n report.Node
|
|
ok bool
|
|
}
|
|
|
|
func testMap(t *testing.T, f render.MapFunc, input testcase) {
|
|
_, ipNet, err := net.ParseCIDR("1.2.3.0/16")
|
|
if err != nil {
|
|
t.Fatalf(err.Error())
|
|
}
|
|
localNetworks := report.Networks([]*net.IPNet{ipNet})
|
|
if have := f(input.n, localNetworks); input.ok != (len(have) > 0) {
|
|
name := input.name
|
|
if name == "" {
|
|
name = fmt.Sprintf("%v", input.n)
|
|
}
|
|
t.Errorf("%s: want %v, have %v", name, input.ok, have)
|
|
}
|
|
}
|
|
|
|
func TestContainerRenderer(t *testing.T) {
|
|
have := Prune(render.ContainerWithImageNameRenderer.Render(fixture.Report, render.FilterNoop))
|
|
want := Prune(expected.RenderedContainers)
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Error(test.Diff(want, have))
|
|
}
|
|
}
|
|
|
|
func TestContainerFilterRenderer(t *testing.T) {
|
|
// tag on of the containers in the topology and ensure
|
|
// it is filtered out correctly.
|
|
input := fixture.Report.Copy()
|
|
input.Container.Nodes[fixture.ClientContainerNodeID] = input.Container.Nodes[fixture.ClientContainerNodeID].WithLatests(map[string]string{
|
|
docker.LabelPrefix + "works.weave.role": "system",
|
|
})
|
|
have := Prune(render.ContainerWithImageNameRenderer.Render(input, render.FilterApplication))
|
|
want := Prune(expected.RenderedContainers.Copy())
|
|
delete(want, fixture.ClientContainerNodeID)
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Error(test.Diff(want, have))
|
|
}
|
|
}
|
|
|
|
func TestContainerWithHostIPsRenderer(t *testing.T) {
|
|
input := fixture.Report.Copy()
|
|
input.Container.Nodes[fixture.ClientContainerNodeID] = input.Container.Nodes[fixture.ClientContainerNodeID].WithLatests(map[string]string{
|
|
docker.ContainerNetworkMode: "host",
|
|
})
|
|
nodes := render.ContainerWithHostIPsRenderer.Render(input, render.FilterNoop)
|
|
|
|
// Test host network nodes get the host IPs added.
|
|
haveNode, ok := nodes[fixture.ClientContainerNodeID]
|
|
if !ok {
|
|
t.Fatal("Expected output to have the client container node")
|
|
}
|
|
have, ok := haveNode.Sets.Lookup(docker.ContainerIPs)
|
|
if !ok {
|
|
t.Fatal("Container had no IPs set.")
|
|
}
|
|
want := report.MakeStringSet("10.10.10.0")
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Error(test.Diff(want, have))
|
|
}
|
|
}
|
|
|
|
func TestContainerHostnameRenderer(t *testing.T) {
|
|
have := Prune(render.ContainerHostnameRenderer.Render(fixture.Report, render.FilterNoop))
|
|
want := Prune(expected.RenderedContainerHostnames)
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Error(test.Diff(want, have))
|
|
}
|
|
}
|
|
|
|
func TestContainerHostnameFilterRenderer(t *testing.T) {
|
|
// add a system container into the topology and ensure
|
|
// it is filtered out correctly.
|
|
input := fixture.Report.Copy()
|
|
|
|
clientContainer2ID := "f6g7h8i9j1"
|
|
clientContainer2NodeID := report.MakeContainerNodeID(clientContainer2ID)
|
|
input.Container.AddNode(report.MakeNodeWith(clientContainer2NodeID, map[string]string{
|
|
docker.LabelPrefix + "works.weave.role": "system",
|
|
docker.ContainerHostname: fixture.ClientContainerHostname,
|
|
report.HostNodeID: fixture.ClientHostNodeID,
|
|
}).
|
|
WithParents(report.EmptySets.
|
|
Add("host", report.MakeStringSet(fixture.ClientHostNodeID)),
|
|
).WithTopology(report.Container))
|
|
|
|
have := Prune(render.ContainerHostnameRenderer.Render(input, render.FilterApplication))
|
|
want := Prune(expected.RenderedContainerHostnames)
|
|
// Test works by virtue of the RenderedContainerHostname only having a container
|
|
// counter == 1
|
|
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Error(test.Diff(want, have))
|
|
}
|
|
}
|
|
|
|
func TestContainerImageRenderer(t *testing.T) {
|
|
have := Prune(render.ContainerImageRenderer.Render(fixture.Report, render.FilterNoop))
|
|
want := Prune(expected.RenderedContainerImages)
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Error(test.Diff(want, have))
|
|
}
|
|
}
|
|
|
|
func TestContainerImageFilterRenderer(t *testing.T) {
|
|
// add a system container into the topology and ensure
|
|
// it is filtered out correctly.
|
|
input := fixture.Report.Copy()
|
|
|
|
clientContainer2ID := "f6g7h8i9j1"
|
|
clientContainer2NodeID := report.MakeContainerNodeID(clientContainer2ID)
|
|
input.Container.AddNode(report.MakeNodeWith(clientContainer2NodeID, map[string]string{
|
|
docker.LabelPrefix + "works.weave.role": "system",
|
|
|
|
docker.ImageID: fixture.ClientContainerImageID,
|
|
docker.ImageName: fixture.ClientContainerImageName,
|
|
report.HostNodeID: fixture.ClientHostNodeID,
|
|
}).
|
|
WithParents(report.EmptySets.
|
|
Add("host", report.MakeStringSet(fixture.ClientHostNodeID)),
|
|
).WithTopology(report.ContainerImage))
|
|
|
|
have := Prune(render.ContainerImageRenderer.Render(input, render.FilterApplication))
|
|
want := Prune(expected.RenderedContainerImages.Copy())
|
|
// Test works by virtue of the RenderedContainerImage only having a container
|
|
// counter == 1
|
|
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Error(test.Diff(want, have))
|
|
}
|
|
}
|