mirror of
https://github.com/weaveworks/scope.git
synced 2026-03-03 18:20:27 +00:00
Another implicit invariant in the data model is that edges are always of the form (local -> remote). That is, the source of an edge must always be a node that originates from within Scope's domain of visibility. This was evident by the presence of ingress and egress fields in edge/aggregate metadata. When building the sniffer, I accidentally and incorrectly violated this invariant, by constructing distinct edges for (local -> remote) and (remote -> local), and collapsing ingress and egress byte counts to a single scalar. I experienced a variety of subtle undefined behavior as a result. See #339. This change reverts to the old, correct methodology. Consequently the sniffer needs to be able to find out which side of the sniffed packet is local v. remote, and to do that it needs access to local networks. I moved the discovery from the probe/host package into probe/main.go. As part of that work I discovered that package report also maintains its own, independent "cache" of local networks. Except it contains only the (optional) Docker bridge network, if it's been populated by the probe, and it's only used by the report.Make{Endpoint,Address}NodeID constructors to scope local addresses. Normally, scoping happens during rendering, and only for pseudo nodes -- see current LeafMap Render localNetworks. This is pretty convoluted and should be either be made consistent or heavily commented.
169 lines
5.0 KiB
Go
169 lines
5.0 KiB
Go
package render_test
|
|
|
|
import (
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/weaveworks/scope/render"
|
|
"github.com/weaveworks/scope/report"
|
|
)
|
|
|
|
type mockRenderer struct {
|
|
render.RenderableNodes
|
|
edgeMetadata report.EdgeMetadata
|
|
}
|
|
|
|
func (m mockRenderer) Render(rpt report.Report) render.RenderableNodes {
|
|
return m.RenderableNodes
|
|
}
|
|
func (m mockRenderer) EdgeMetadata(rpt report.Report, localID, remoteID string) report.EdgeMetadata {
|
|
return m.edgeMetadata
|
|
}
|
|
|
|
func TestReduceRender(t *testing.T) {
|
|
renderer := render.Reduce([]render.Renderer{
|
|
mockRenderer{RenderableNodes: render.RenderableNodes{"foo": {ID: "foo"}}},
|
|
mockRenderer{RenderableNodes: render.RenderableNodes{"bar": {ID: "bar"}}},
|
|
})
|
|
|
|
want := render.RenderableNodes{"foo": {ID: "foo"}, "bar": {ID: "bar"}}
|
|
have := renderer.Render(report.MakeReport())
|
|
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Errorf("want %+v, have %+v", want, have)
|
|
}
|
|
}
|
|
|
|
func TestReduceEdge(t *testing.T) {
|
|
renderer := render.Reduce([]render.Renderer{
|
|
mockRenderer{edgeMetadata: report.EdgeMetadata{PacketCount: newu64(1)}},
|
|
mockRenderer{edgeMetadata: report.EdgeMetadata{PacketCount: newu64(2)}},
|
|
})
|
|
|
|
want := report.EdgeMetadata{PacketCount: newu64(3)}
|
|
have := renderer.EdgeMetadata(report.MakeReport(), "", "")
|
|
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Errorf("want %+v, have %+v", want, have)
|
|
}
|
|
}
|
|
|
|
func TestMapRender1(t *testing.T) {
|
|
// 1. Check when we return false, the node gets filtered out
|
|
mapper := render.Map{
|
|
MapFunc: func(nodes render.RenderableNode) (render.RenderableNode, bool) {
|
|
return render.RenderableNode{}, false
|
|
},
|
|
Renderer: mockRenderer{RenderableNodes: render.RenderableNodes{
|
|
"foo": {ID: "foo"},
|
|
}},
|
|
}
|
|
want := render.RenderableNodes{}
|
|
have := mapper.Render(report.MakeReport())
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Errorf("want %+v, have %+v", want, have)
|
|
}
|
|
}
|
|
|
|
func TestMapRender2(t *testing.T) {
|
|
// 2. Check we can remap two nodes into one
|
|
mapper := render.Map{
|
|
MapFunc: func(nodes render.RenderableNode) (render.RenderableNode, bool) {
|
|
return render.RenderableNode{ID: "bar"}, true
|
|
},
|
|
Renderer: mockRenderer{RenderableNodes: render.RenderableNodes{
|
|
"foo": {ID: "foo"},
|
|
"baz": {ID: "baz"},
|
|
}},
|
|
}
|
|
want := render.RenderableNodes{
|
|
"bar": render.RenderableNode{ID: "bar"},
|
|
}
|
|
have := mapper.Render(report.MakeReport())
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Errorf("want %+v, have %+v", want, have)
|
|
}
|
|
}
|
|
|
|
func TestMapRender3(t *testing.T) {
|
|
// 3. Check we can remap adjacencies
|
|
mapper := render.Map{
|
|
MapFunc: func(nodes render.RenderableNode) (render.RenderableNode, bool) {
|
|
return render.RenderableNode{ID: "_" + nodes.ID}, true
|
|
},
|
|
Renderer: mockRenderer{RenderableNodes: render.RenderableNodes{
|
|
"foo": {ID: "foo", Adjacency: report.MakeIDList("baz")},
|
|
"baz": {ID: "baz", Adjacency: report.MakeIDList("foo")},
|
|
}},
|
|
}
|
|
want := render.RenderableNodes{
|
|
"_foo": {ID: "_foo", Adjacency: report.MakeIDList("_baz")},
|
|
"_baz": {ID: "_baz", Adjacency: report.MakeIDList("_foo")},
|
|
}
|
|
have := mapper.Render(report.MakeReport())
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Errorf("want %+v, have %+v", want, have)
|
|
}
|
|
}
|
|
|
|
func TestMapEdge(t *testing.T) {
|
|
selector := func(_ report.Report) report.Topology {
|
|
return report.Topology{
|
|
NodeMetadatas: report.NodeMetadatas{
|
|
"foo": report.MakeNodeMetadataWith(map[string]string{"id": "foo"}),
|
|
"bar": report.MakeNodeMetadataWith(map[string]string{"id": "bar"}),
|
|
},
|
|
Adjacency: report.Adjacency{
|
|
">foo": report.MakeIDList("bar"),
|
|
">bar": report.MakeIDList("foo"),
|
|
},
|
|
EdgeMetadatas: report.EdgeMetadatas{
|
|
"foo|bar": report.EdgeMetadata{PacketCount: newu64(1), EgressByteCount: newu64(2)},
|
|
"bar|foo": report.EdgeMetadata{PacketCount: newu64(3), EgressByteCount: newu64(4)},
|
|
},
|
|
}
|
|
}
|
|
|
|
identity := func(nmd report.NodeMetadata) (render.RenderableNode, bool) {
|
|
return render.NewRenderableNode(nmd.Metadata["id"], "", "", "", nmd), true
|
|
}
|
|
|
|
mapper := render.Map{
|
|
MapFunc: func(nodes render.RenderableNode) (render.RenderableNode, bool) {
|
|
return render.RenderableNode{ID: "_" + nodes.ID}, true
|
|
},
|
|
Renderer: render.LeafMap{
|
|
Selector: selector,
|
|
Mapper: identity,
|
|
Pseudo: nil,
|
|
},
|
|
}
|
|
|
|
if want, have := (report.EdgeMetadata{
|
|
PacketCount: newu64(1),
|
|
EgressByteCount: newu64(2),
|
|
}), mapper.EdgeMetadata(report.MakeReport(), "_foo", "_bar"); !reflect.DeepEqual(want, have) {
|
|
t.Errorf("want %+v, have %+v", want, have)
|
|
}
|
|
}
|
|
|
|
func TestFilterRender(t *testing.T) {
|
|
renderer := render.FilterUnconnected{
|
|
Renderer: mockRenderer{RenderableNodes: render.RenderableNodes{
|
|
"foo": {ID: "foo", Adjacency: report.MakeIDList("bar")},
|
|
"bar": {ID: "bar", Adjacency: report.MakeIDList("foo")},
|
|
"baz": {ID: "baz", Adjacency: report.MakeIDList()},
|
|
}},
|
|
}
|
|
want := render.RenderableNodes{
|
|
"foo": {ID: "foo", Adjacency: report.MakeIDList("bar")},
|
|
"bar": {ID: "bar", Adjacency: report.MakeIDList("foo")},
|
|
}
|
|
have := renderer.Render(report.MakeReport())
|
|
if !reflect.DeepEqual(want, have) {
|
|
t.Errorf("want %+v, have %+v", want, have)
|
|
}
|
|
}
|
|
|
|
func newu64(value uint64) *uint64 { return &value }
|