Bryan Boreham
fb9c9e0140
Subtract page cache from container memory usage
...
So that Scope numbers match Docker numbers.
2018-11-21 16:07:57 +00:00
Bryan Boreham
53c406f7e0
Check container is running before trying to open its namespace
...
Otherwise we get pointless errors.
2018-07-23 21:37:22 +00:00
Marc Carré
d46c2266ce
Change Sirupsen/logrus to sirupsen/logrus
...
```
$ git grep -l Sirupsen | grep -v vendor | xargs sed -i '' 's:github.com/Sirupsen/logrus:github.com/sirupsen/logrus:g'
$ gofmt -s -w app
$ gofmt -s -w common
$ gofmt -s -w probe
$ gofmt -s -w prog
$ gofmt -s -w tools
```
2018-07-23 20:10:14 +02:00
Bryan Boreham
5edc85822b
AddParent() function to optimise the case where there is only one parent
...
Avoids creating and discarding a StringSet just to carry the
parameters, and makes the code more readable too.
2018-07-17 13:51:46 +00:00
Bryan Boreham
20ce708db9
Don't bother deduplicating IPs; they end up in a set
2018-06-04 16:41:24 +00:00
Bryan Boreham
ff5b2affe0
probe: fetch container IP addresses from inside its namespace
...
So that we can pick up addresses added via CNI or other mechanisms
that Docker is not aware of.
2018-06-02 21:49:30 +00:00
Filip Barl
bfb20a8f40
Addressed @LiliC's feedback.
2018-05-17 11:43:54 +02:00
Matthias Radestock
805572d70e
refactor: inline single-use constant
2018-04-02 13:50:22 +01:00
Matthias Radestock
e852b18e42
refactor: remove unused constant
2018-04-02 13:48:29 +01:00
Bryan Boreham
3941424794
Don't add null entries to container nodes for networks
...
or the "none" network, which is a special case meaning none.
2018-02-23 18:09:18 +00:00
Matthias Radestock
1f2247a8c4
move node metadata keys into report package
...
Both the probe and the app (for rendering) need to know about them.
2017-12-11 20:26:08 +00:00
Filip Barl
f5bfa506d6
Verified the TODO comments and make durations be in seconds.
2017-11-03 10:43:41 +01:00
Filip Barl
6c0194b832
Show uptime durations in a more human format.
2017-11-03 10:43:41 +01:00
Matthias Radestock
9dc50b5202
refactor: hide "empty set" constants
...
They are an implementation detail.
2017-07-03 01:26:22 +01:00
Alfonso Acosta
8bf753a51b
Revert "Revert "Add options to hide args and env vars ( #2306 )"" ( #2311 )
...
* Revert "Revert "Add options to hide args and env vars (#2306 )""
* Make linter happy
2017-03-08 02:16:42 -08:00
Alfonso Acosta
dcc7389127
Revert "Add options to hide args and env vars ( #2306 )"
...
This reverts commit 764afb6301 .
2017-03-07 17:51:27 +01:00
Mike Bryant
764afb6301
Add options to hide args and env vars ( #2306 )
...
* Add options to hide args and env vars
To allow for use of weave-scope in an unauthenticated environment,
add options to the probe to hide comand line arguments and
environment variables, which might contain secret data.
Fixes #2222
* Change docker.NewRegistry arguments to be a struct
* Remove redundant declarations of default values
* Move registry options outside to improve readability
2017-03-07 08:51:18 -08:00
Filip Barl
d3466b5454
Refactored the table component/model and wrote the tests
...
Backward-compatibility fix
2017-01-16 17:05:36 +01:00
Filip Barl
31be525bd2
Created generic table model on backend
...
Replaced MetadataRow with generic Row in Table model
Sending through multicolumn tables from the backend
2017-01-16 12:22:10 +01:00
Jonathan Lange
e8085b01b6
Use 'common' library
2016-12-07 11:22:38 +00:00
Alfonso Acosta
9367d95cb0
Allow providing fixed entries in tables
2016-11-02 13:00:15 +00:00
Alfonso Acosta
bd3ececb11
Increase timestamp precision
2016-10-18 15:24:37 +00:00
Matthias Radestock
a5b491dd46
Merge pull request #1833 from weaveworks/simplify-container-stats
...
use go-dockerclient's Client.Stats
Fixes #1799
2016-08-26 13:07:16 +01:00
Matthias Radestock
3c4833fe97
use go-dockerclient's Client.Stats
...
...instead of rolling our own.
This also fixes #1799 - a race condition that could result in multiple
stats gatherers for a container.
2016-08-26 12:43:30 +01:00
Matthias Radestock
b209d22e08
normalise container CPU metrics to 100%
...
The container CPU metric was reported in units of 100% = 1 CPU. So the
the ratio was correct, but since we don't show limits in most places it
is hard to interpret that figure. It also makes sorting by CPU usage
highly misleading. So now we normalise everything to 100%. That too can
be misleading, depending on what you are looking for, but it's generally
less surprising.
2016-08-25 16:13:36 +01:00
Alfonso Acosta
b3b160ceb0
Merge pull request #1791 from weaveworks/release-0.17
...
Release 0.17.0
2016-08-16 15:04:29 +01:00
Alfonso Acosta
8b97f12ab1
Make stats gathering idempotent
2016-08-16 12:50:22 +00:00
Krzesimir Nowak
9e092f1a4a
Switch to LatestMap-style node controls
...
This allows plugins to add controls to nodes that already have some
controls set by other plugin. Previously only the last plugin that
sets the controls in the node would have its controls visible. That
was because of NodeControls' Merge function that actually weren't
merging data from two inputs, but rather returning data that was newer
and discarding the older one.
2016-08-12 17:15:43 +02:00
Alfonso Acosta
8a950a59d6
Remove Metric Add() method
...
* Helps reduce garbage (MakeMetric() now takes a slice and there's a shorter version MakeSingletonMetric())
* Fixes bug computing Max (Min) in samples since using MakeMetric()
was causing a default Max/Min of zero.
* Simplifies code a bit
2016-08-01 16:58:11 +00:00
Matthias Radestock
b3874e6e6f
show names of stopped containers
...
This got broken in b78c503
Fixes #1691
2016-07-21 11:01:53 +01:00
Matthias Radestock
34cb6d5a84
reduce container stats log noise
...
Don't complain about net.errClosing, which we typically get instead of
io.EOF when the container stops.
2016-07-16 20:33:15 +01:00
Matthias Radestock
30a5a9e64b
reduce container stats log noise
...
reduce log level
2016-07-16 20:32:36 +01:00
Matthias Radestock
b38913e5c9
tiny improvement: log container id in stats collection loop
2016-07-16 20:12:19 +01:00
Tom Wilkie
d888509865
Ignore IPv6 addresses in Docker reporter ( #1552 )
2016-06-15 16:05:12 +01:00
Alfonso Acosta
0fd2754b58
Gather IPs from all the container networks
2016-06-10 17:45:54 +00:00
Peter Bourgon
10ced2d09d
First cut of network data
2016-06-06 16:24:02 +02:00
Alban Crequy
42ad3aa12b
Scope slow: improve error messages for debugging ( #1534 )
...
* alpine: dl-4.alpinelinux.org is dead, use another server
* increase buffer for docker stats
Attempt to avoid the following message:
docker container: dropping stats.
* probe: better timeout error messages
The logs contains the following messages:
Process reporter took longer than 1s
K8s reporter took longer than 1s
Docker reporter took longer than 1s
Endpoint reporter took longer than 1s
This patch prints how long it takes.
2016-05-22 18:21:55 +01:00
Alfonso Acosta
b78c503004
Review feedback
2016-05-10 08:03:46 +00:00
Alfonso Acosta
e83f985ea6
Precompute base of the container nodes
2016-05-10 06:25:06 +00:00
Alfonso Acosta
4140d288a8
Don't scope docker IPs in Kubernetes
2016-05-04 14:50:22 +00:00
Tom Wilkie
02554b1dcd
Propagate network info for containers sharing network namespaces ( #1401 )
...
- Add armon/go-radix library, use this to find containers by prefix
- Deal with host net namespace in the same way
2016-04-29 18:13:55 +01:00
Paul Bellamy
1539e668e7
Merge pull request #1290 from weaveworks/remove-container-control
...
Add control for removing stopped docker containers.
2016-04-22 14:13:40 +01:00
Tom Wilkie
65dbca997c
Add control for removing stopped docker containers.
2016-04-21 16:24:41 +01:00
Tom Wilkie
cec750049f
Immediately remove deleted containers from the UI.
2016-04-21 12:26:51 +01:00
Tom Wilkie
9eda27822c
Show k8s labels and container env vars in the details panel. ( #1342 )
...
* Show k8s labels and container env vars in the details panel.
* Add show more bar to the env vars and labels
* React key was in the wrong place; empty tables render section labels.
2016-04-20 08:18:03 +01:00
Paul Bellamy
1edeb8d190
Removing report.Node.WithID ( #1315 )
...
* removing usage of report.Node.WithID
* report.Topology.AddNode can use the node's ID field
2016-04-19 16:48:03 +01:00
Ilya Dmitrichenko
a49c3893de
More sensible container names for Mesos/Marathon ( #1316 )
...
* Collect container environment variales (close #1314 )
* Containers managed by Marathon can have meaningful names (close #1309 )
* Make linter happy and fix tests
2016-04-18 12:10:18 +01:00
Paul Bellamy
bfb65cb4af
Merge pull request #1225 from weaveworks/1149-more-meaningful-metrics-max-mmmmmmm
...
Set the memory and open files maximums based on the host
2016-04-07 10:36:30 +01:00
Paul Bellamy
f3adefa454
Update docker client, to get better state strings in the UI
2016-04-06 16:39:45 +01:00
Paul Bellamy
b970b0561b
Set the memory and open files maximums
...
process memory limit is not cgroup-aware
2016-04-06 13:07:55 +01:00