40 Commits

Author SHA1 Message Date
Alfonso Acosta
a559a23dba Distinguish between reporting probes and controlling probes 2016-02-26 01:46:18 +00:00
Alfonso Acosta
ddf5fff5c2 Inline encoding of previously embedded fields
To avoid impacting the client's code with implementation details.
2016-02-18 12:49:31 +00:00
Alfonso Acosta
6ac176a492 Remove github.com/2opremio/go-1/codec
* Bump github.com/ugorji/go/codec, to get fixes which make
  github.com/2opremio/go-1/codec unnecessary

* Remove github.com/2opremio/go-1/codec

* Remove type embeddings to avoid the problem explained at
  https://github.com/ugorji/go/issues/141#issuecomment-185450157
2016-02-18 12:47:06 +00:00
Alfonso Acosta
a2710ecfd5 Merge pull request #916 from weaveworks/854-reports-codec
Improve codec performance
2016-02-17 14:07:31 +00:00
Alfonso Acosta
bdc97d6e06 Circumvent https://github.com/ugorji/go/issues/142 2016-02-16 23:52:36 +00:00
Alfonso Acosta
9c368c4e84 Implement Selfers for all render types
To workaround https://github.com/ugorji/go/issues/141
2016-02-16 23:52:32 +00:00
Paul Bellamy
44dada25f2 Review Feedback 2016-02-16 10:37:25 +00:00
Alfonso Acosta
0d917b2d8b Use github.com/ugorji/go/codec/ for wiring messages
* New encoding format:
  * Msgpack reports between probe<->app (smaller representation, faster to
    encode/decode).
  * Still use JSON between app<->UI (try to avoid making javascript deal with
    mspack).

  The app still suports publishing reports in both gob and JSON, not braking
  backwards compatibility.

* Use compile-time generated marshallers/unmarshallers for higher performance. In
  order to be able to skip code-generation for certain types, I included
  https://github.com/2opremio/go-1/tree/master/codec/codecgen instead of
  upstream until https://github.com/ugorji/go/pull/139 is merged.

* Encode/decode intermediate types using github.com/ugorji/go/codec.Selfer
  for higher performance and reducing garbage collection (no temporary buffers).
2016-02-16 06:31:31 +00:00
Paul Bellamy
5bb3d49297 gather file descriptors as process metric 2016-02-12 17:13:27 +00:00
Paul Bellamy
05d4ce05a3 Merge pull request #946 from weaveworks/929-show-more-metadata
Only show key metadata by default. Hide rest in a drawer.
2016-02-11 11:08:39 +00:00
Paul Bellamy
d5a2b5bb9d show all process and pod metadata, as there's only 4, and 3 rows respectively. 2016-02-11 09:39:25 +00:00
Paul Bellamy
89d7ebe977 show nice column labels when no children have metrics 2016-02-10 11:42:03 +00:00
Paul Bellamy
78d7e29437 Merge pull request #941 from weaveworks/reorder-children-tables
Reorder the children tables in the details panel
2016-02-10 11:40:25 +00:00
Paul Bellamy
1b554baa91 Reorder the children tables in the details panel
The Container images was first on hosts, but is probably the least
useful, so this moves it to the bottom.

In general, it needs more thought put into the detail panel contents,
but this is a quick fix to re-prioritize the data.
2016-02-09 15:35:54 +00:00
Paul Bellamy
dfb0f8036c Only show key metadata by default. Hide rest in a drawer.
To make the interface cleaner, we can hide some non-key metadata by
default.

This needs styling, js testing, and probably a js refactor.
2016-02-08 17:14:16 +00:00
Tom Wilkie
107d3068d5 Shorten docker container and image IDs in the details panel. 2016-02-08 15:52:56 +00:00
Paul Bellamy
30dd97bab5 Merge pull request #920 from weaveworks/refactor-detailed-metadata
minor refactor of backend metadata and metric rendering
2016-02-08 15:37:12 +00:00
Paul Bellamy
e33838f1e6 minor refactor of backend metadata and metric rendering 2016-02-08 14:01:00 +00:00
Paul Bellamy
7fbf86aa8f shorten some labels which were truncated 2016-02-08 11:07:41 +00:00
Paul Bellamy
a403917875 Add "# Containers" column to container images as children
Side effect is that it also adds it to the container image details panel
2016-02-05 11:13:37 +00:00
Paul Bellamy
55ee62d343 add test for render/detailed/parents and fixed bug 2016-02-04 17:55:06 +00:00
Paul Bellamy
9876140bfe moving render/detailed/parents to it's own file 2016-02-04 14:46:13 +00:00
Paul Bellamy
0a292f530c move docker labels into their own table of the details panel 2016-02-03 10:29:28 +00:00
Paul Bellamy
154c996d08 couple labels were added while waiting to merge 2016-02-02 16:19:40 +00:00
Paul Bellamy
b21eeb7bcf key of process.CPUUsage changed, while waiting to merge 2016-02-02 16:17:58 +00:00
Paul Bellamy
cae6ac58a8 Merge commit 'e31520d' 2016-02-02 15:54:39 +00:00
Tom Wilkie
6f9fdaa27e Rename applications -> processes in experimental and render/detailed. 2016-02-01 06:54:19 -08:00
Tom Wilkie
638c5676cb Add container uptime and restart count to details panel. 2016-01-29 14:31:40 -08:00
Paul Bellamy
66790f4436 use immutability for the NodeSet 2016-01-27 11:10:51 +00:00
Paul Bellamy
599bade33f Merge branch 'master' of github.com:weaveworks/scope 2016-01-26 10:03:55 +00:00
Tom Wilkie
6b56475766 Use ps.Map for Counters and Sets, remove Metadata in favour of Latest.
Also
- Add more complicated report.json for benchmark
- Break up report/topology.go
- Implement our own DeepEqual for ps.Map
2016-01-22 15:10:32 -08:00
Paul Bellamy
21ae0aa253 Merge commit '77949db' 2016-01-22 09:41:40 +00:00
Paul Bellamy
e31520dddd refactor detailed key label rendering into a single dictionary 2016-01-21 11:55:45 +00:00
Paul Bellamy
77949db711 use constants for topology names (missed a few) 2016-01-20 16:16:58 +00:00
Paul Bellamy
bf57aeb8d9 Rename the various metric keys so they don't accidentally overlap 2016-01-20 16:14:32 +00:00
Paul Bellamy
0190c15145 Making fixture report metrics more specific 2016-01-20 16:13:56 +00:00
Paul Bellamy
cb9d558665 Review feedback refactoring 2016-01-19 16:47:48 +01:00
Paul Bellamy
54d0db0441 templatize metric rendering and shorten column names 2016-01-19 16:47:48 +01:00
Paul Bellamy
e30c9dc264 use constants for the topology names in Parents/metadata/metrics 2016-01-19 16:47:48 +01:00
Paul Bellamy
56122dd0cc Details panel backend redesign
Megasquish:
  [app] remove unused edge endpoint
  [WIP] refactoring node details api endpoint
  [WIP] plumbing the children through the rendering process
  adding IDList.Remove and StringSet.Remove
  [WIP] working on adding parents to detailed node renderings
  WIP UI components with mock backend data for new details
  grouping children by type
  UI components for node details health and info
  metric formatters for details panel
  Column headers and links for details table
  [WIP] started on rendering node metadata and metrics in the detail view
  DetailedNode.LabelMajor -> DetailedNode.Label
  rendering decent labels for parents of detailed nodes
  render metrics onto the top-level detailed node
  removing dead code
  Links to relatives
  metrics have a Format not Unit
  Show more/less actions for tables and relatives
  adjusted metric formatter
  TopologyTagger should tag k8s topology nodes
  make renderablenode ids more consistent, e.g. container:abcd1234
  working on rendering correct summaries for each node
  adding report.Node.Rank, so that merging is independent of order
  rendering children and parents correctly
  output child renderableNode ids, so we can link to them
  add group field to metrics, so they can be grouped
  Refactored details health items to prepare for grouping
  add metrics to processNodeSummaries
  hide summary section if there is no data for it
  fixing up tests
  moving detailed node rendering into a separate package
  Node ID/Topology are fields not metadata
    - This way I think we don't have to care about Metadata being non-commutative.
    - ID and topology are still non-commutative, as I'm not sure how to sanely
  merge them, but it's possible we don't care.
  host memory usage is a filesize, not a percent
  working on fixing some tests
  adding children to hosts detail panel
    - Had to redo how parents are calculated, so that children wouldn't interfere with it
    - have to have the host at the end because it is non-commutative
  only render links for linkable children (i.e. not unconnected processes)
  resolving TODOs
  fixing up lint errors
  make nil a valid value for render.Children so tests are cleaner
  working on backend tests
  make client handle missing metrics property
  Stop rendering container image nodes with process summaries/parents
  fix parent link to container images
  Calculate parents as a set on report.Node (except k8s)
  refactoring detailed.NodeSummary stuff
  removing RenderableNode.Summary*, we already track it on report.Node
  working on tests
  add Columns field to NodeSummaryGroup
  fixing up render/topologies_test
  fix children links to container images
  get children of hosts rendering right
  working on host renderer tests
  Change container report.Node.ID to a1b2c3;<container>
  The id should be globally unique, so we don't need the host id.
    This lets the kubernetes probe return a container node with the pod id,
    which will get merged into the real containers with other reports. The
    catch is that the kubernetes api doesn't tell us which hostname the
    container is running on, so we can't populate the old-style node ids.
  change terminology of system pods and services
  Fix kubernetes services with no selector
  Fixes handling of kubernetes service, which has no pods
  fix parent links for pods/services
  refactor detailed metadata to include sets and latest data
  fixing up host rendering tests
  fleshing out tests for node metadata and metrics
  don't render container pseudo-nodes as processes
  Update test for id format change.
2016-01-19 16:39:37 +01:00