Mike Lang
21431bb4b0
scope launch script: Fix shellcheck linter warnings
...
By far the majority of these were variables which were not quoted.
While, yes, right now we can guarentee most of these variables will never contain spaces,
this could someday change and applying quoting as a universal rule prevents future mistakes.
The ARGS="$@" -> "$*" change is purely stylistic and mainly is used to indicate the intent that
we actually wanted to concatenate all the args by spaces, not keep them seperated as "$@" would
in many situations, but not this one.
Several warnings remain, in places where we intentionally want to split a variable on whitespace,
or otherwise do what shellcheck is warning us against.
Of note is shellcheck warning SC2166, which says to prefer [ foo ] || [ bar ] over [ foo -o bar ]
as the -a and -o flags have differing behaviour on some systems.
I've opted to keep these for now, since the version check test command would need to be replaced by
a LOT of subshells to achieve the same effect, which feels dirtier.
2016-12-12 11:26:00 -08:00
Jordan Pellizzari
670d52f191
Merge pull request #2078 from weaveworks/2072-sparkline-errors
...
Fix sparkline crashing on stopped nodes
2016-12-12 10:19:58 -08:00
Jonathan Lange
a8ba7b2c86
Log whether it's a websocket request
2016-12-12 17:57:48 +00:00
Jonathan Lange
256e480acc
Vendor new weaveworks/common
2016-12-12 17:40:46 +00:00
Jonathan Lange
626e8a3e9f
Neater way of doing it
2016-12-12 17:40:15 +00:00
Jonathan Lange
4fcf9a1e36
Add flag for logging headers
2016-12-12 17:12:28 +00:00
Paul Bellamy
6b54cd28b2
Merge pull request #2081 from weaveworks/remove-wcloud
...
Remove wcloud
2016-12-12 15:24:09 +00:00
David
d8f16c9a32
Merge pull request #2084 from weaveworks/revert-2058-update-eslint
...
Revert "Upgraded eslint & eslint-config-airbnb"
2016-12-12 16:06:58 +01:00
David
99bfab89b7
Revert "Upgraded eslint & eslint-config-airbnb"
2016-12-12 16:06:13 +01:00
Filip Barl
0921af04d5
Merge pull request #2058 from weaveworks/update-eslint
...
Upgraded eslint & eslint-config-airbnb
2016-12-12 14:01:53 +01:00
Filip Barl
be9b640130
Addressed @davkal's and @jpellizzari's comments
2016-12-12 11:36:43 +01:00
Filip Barl
a1d1b49aeb
Addressed @jpellizzari's comment
2016-12-12 11:23:09 +01:00
Paul Bellamy
2caa2b6770
Remove wcloud
2016-12-12 10:07:09 +00:00
Filip Barl
1b5f3ae4bf
Using individual D3 modules
2016-12-12 11:04:49 +01:00
Filip Barl
71f44e8b70
Got rid of findDOMNode helper
2016-12-12 11:04:49 +01:00
Filip Barl
90685c89f1
Applied 'jsx-no-target-blank' lint rule
2016-12-12 11:04:15 +01:00
Filip Barl
86d61cf0d6
Extracted 'static' methods outside of classes for the 'class-methods-use-this' lint rule
2016-12-12 11:04:15 +01:00
Filip Barl
8dce4e8f36
Fixed the failing test
2016-12-12 11:03:16 +01:00
Filip Barl
776b4d72eb
Applied no-mixed-operators linting rule
2016-12-12 11:03:16 +01:00
Filip Barl
e60418a986
Applied label-has-for linting rule
2016-12-12 11:03:16 +01:00
Filip Barl
b9241b377a
Applied no-underscore-dangle linting rule
2016-12-12 11:03:16 +01:00
Filip Barl
3fdcd9b5e7
Applied arrow-parens linting rule
2016-12-12 11:02:18 +01:00
Filip Barl
f5ae864fa2
Made all lines less than 100 characters
2016-12-12 10:58:29 +01:00
fbarl
e47c3e0973
Applied a couple of simpler rules
2016-12-12 10:56:56 +01:00
fbarl
0cb48f6d71
Upgraded eslint, airbnb linting rules, and made trivial fixes
2016-12-12 10:55:45 +01:00
jpellizzari
850e675273
Fixed sparkline crashing on stopped nodes
2016-12-09 11:19:38 -08:00
jpellizzari
70960cc67a
Fixed client linting errors
2016-12-09 10:11:58 -08:00
Jordan Pellizzari
b5a720e17c
Merge pull request #2076 from weaveworks/2075-client-linting
...
Add client linting to CI config
2016-12-09 08:04:01 -08:00
Filip Barl
244bba2d26
Merge pull request #2053 from weaveworks/lodash-partial-imports
...
Importing lodash util functions explicitly
2016-12-09 14:36:33 +01:00
Filip Barl
4142474e46
Added babel-plugin-lodash library for automatic cherry-picking of the Lodash modules
2016-12-09 14:07:22 +01:00
fbarl
524e2e2e9a
Importing lodash util functions explicitly.
2016-12-09 14:03:31 +01:00
Jordan Pellizzari
856a5a0388
Merge pull request #2071 from weaveworks/2056-graph-table-buttons
...
Fix grid-mode-selector styling
2016-12-08 14:47:10 -08:00
jpellizzari
7fba78c7b3
Liniting fixes
2016-12-08 11:08:48 -08:00
jpellizzari
38344a2a48
Added client linting to circle.yml
2016-12-08 11:08:25 -08:00
Jonathan Lange
e387f8c5d8
Merge pull request #2074 from weaveworks/correct-ws-handshake
...
Correctly instrument websocket handshakes
2016-12-08 18:01:35 +00:00
Jonathan Lange
813e6468bc
Correctly instrument websocket handshakes
...
Part of weaveworks/monitoring#82
2016-12-08 17:36:45 +00:00
David Kaltschmidt
5687054126
Allow relative paths for assets in local webpack config
2016-12-08 16:30:07 +01:00
jpellizzari
431be4cf25
Fixed grid-mode-selector styling
2016-12-07 16:32:19 -08:00
Peter Bourgon
90c29f249d
Merge pull request #2067 from weaveworks/k8s-curl-redirections
...
Follow redirections in curl when getting k8s resources
2016-12-07 17:08:48 +01:00
Alfonso Acosta
78dd2f0c76
Follow redirections in curl when getting k8s resources
2016-12-07 16:35:55 +01:00
Alfonso Acosta
07aee0ed97
Merge pull request #2020 from kinvolk/alban/fix-getWalkedProcPid
...
procspy: use a Reader to copy the background reader buffer
2016-12-07 12:53:53 +01:00
Jonathan Lange
9a92961a5f
Merge pull request #2061 from weaveworks/use-common-lib
...
Use newly-created 'common' repo
2016-12-07 11:51:35 +00:00
Jonathan Lange
1020fc5f85
Use test.Diff from common
2016-12-07 11:22:40 +00:00
Jonathan Lange
496afb9a42
Vendor in weaveworks/common
2016-12-07 11:22:39 +00:00
Jonathan Lange
b5c750ddea
Move test & fs
2016-12-07 11:22:39 +00:00
Jonathan Lange
e8085b01b6
Use 'common' library
2016-12-07 11:22:38 +00:00
fbarl
6344358c6b
Fix all the npm library versions ( resolve #2052 )
2016-12-07 11:22:38 +00:00
Mike Lang
fb12df6036
ecs reporter: Fix some log lines that were passing *string instead of string
2016-12-05 15:43:36 -08:00
Alban Crequy
543f3d5bdc
procspy: use a Reader to copy the background reader buffer
...
getWalkedProcPid() reads latestBuf every 3 seconds (for each report).
But performWalk() writes latestBuf every 10 seconds or so. So we need to
be able to read the same buffer several times.
2016-12-05 18:12:11 +01:00
Filip Barl
9d5d431a59
Merge pull request #2057 from weaveworks/fix-npm-versions
...
Fix all the npm library versions
2016-12-05 16:15:35 +01:00
