Commit Graph

221 Commits

Author SHA1 Message Date
Paul Bellamy
6cef1b10ca adding direction to connections from conntrack
* Remove report.EdgeMetadata.MaxConnCountTCP, as we don't display it anywhere
* Remove hostname metadata from local end of connection. We should be using the hostnodeid
2016-02-23 14:17:45 +00:00
Simon Howe
dca7408ec1 Rollback aggNode.nodeCount which was used for the stack shape.
We're not using greyed out lower stacks for now.
2016-02-22 12:42:37 +01:00
Simon Howe
2c626776a1 Grey out bottom of stack when there aren't 3 nodes in the stack
E.g. greying out the bottom 2/3 visual nodes if the stack actually only
has a single node.

- Server returns "node_count" for agg nodes.
2016-02-22 12:42:37 +01:00
Tom Wilkie
3f7f55e87e Backend for node shapes 2016-02-22 12:42:36 +01:00
Paul Bellamy
d2bf204181 Merge pull request #960 from weaveworks/no-ips-for-no-network
Don't show blank IPs metadata row for containers with no IP
2016-02-19 17:39:01 +00:00
Paul Bellamy
5535f5e738 Review Feedback 2016-02-19 17:04:00 +00:00
Tom Wilkie
0402f6d8f3 Merge pull request #962 from weaveworks/no-pointer-math
Remove pointer math (comparison) from render caching, as it is unreliable
2016-02-19 12:43:43 +00:00
Alfonso Acosta
ddf5fff5c2 Inline encoding of previously embedded fields
To avoid impacting the client's code with implementation details.
2016-02-18 12:49:31 +00:00
Alfonso Acosta
6ac176a492 Remove github.com/2opremio/go-1/codec
* Bump github.com/ugorji/go/codec, to get fixes which make
  github.com/2opremio/go-1/codec unnecessary

* Remove github.com/2opremio/go-1/codec

* Remove type embeddings to avoid the problem explained at
  https://github.com/ugorji/go/issues/141#issuecomment-185450157
2016-02-18 12:47:06 +00:00
Paul Bellamy
0379fc4cf3 generate an ID for each memoiser so they can share cache
Makes cache clearing easier, and then we don't need to add
`ResetCache()` to the Renderer interface.
2016-02-17 17:10:14 +00:00
Paul Bellamy
df856d78dc set container IPs to host IPs for containers with --net=host 2016-02-17 16:42:52 +00:00
Paul Bellamy
a0a60ca079 Remove pointer math (comparison) from render caching, as it is unreliable 2016-02-17 15:41:16 +00:00
Alfonso Acosta
a2710ecfd5 Merge pull request #916 from weaveworks/854-reports-codec
Improve codec performance
2016-02-17 14:07:31 +00:00
Alfonso Acosta
bdc97d6e06 Circumvent https://github.com/ugorji/go/issues/142 2016-02-16 23:52:36 +00:00
Alfonso Acosta
9c368c4e84 Implement Selfers for all render types
To workaround https://github.com/ugorji/go/issues/141
2016-02-16 23:52:32 +00:00
Paul Bellamy
44dada25f2 Review Feedback 2016-02-16 10:37:25 +00:00
Alfonso Acosta
0d917b2d8b Use github.com/ugorji/go/codec/ for wiring messages
* New encoding format:
  * Msgpack reports between probe<->app (smaller representation, faster to
    encode/decode).
  * Still use JSON between app<->UI (try to avoid making javascript deal with
    mspack).

  The app still suports publishing reports in both gob and JSON, not braking
  backwards compatibility.

* Use compile-time generated marshallers/unmarshallers for higher performance. In
  order to be able to skip code-generation for certain types, I included
  https://github.com/2opremio/go-1/tree/master/codec/codecgen instead of
  upstream until https://github.com/ugorji/go/pull/139 is merged.

* Encode/decode intermediate types using github.com/ugorji/go/codec.Selfer
  for higher performance and reducing garbage collection (no temporary buffers).
2016-02-16 06:31:31 +00:00
Paul Bellamy
5bb3d49297 gather file descriptors as process metric 2016-02-12 17:13:27 +00:00
Paul Bellamy
8c4f025bf5 don't render any metrics/metadata for uncontained node 2016-02-11 16:01:04 +00:00
Paul Bellamy
05d4ce05a3 Merge pull request #946 from weaveworks/929-show-more-metadata
Only show key metadata by default. Hide rest in a drawer.
2016-02-11 11:08:39 +00:00
Paul Bellamy
d5a2b5bb9d show all process and pod metadata, as there's only 4, and 3 rows respectively. 2016-02-11 09:39:25 +00:00
Paul Bellamy
89d7ebe977 show nice column labels when no children have metrics 2016-02-10 11:42:03 +00:00
Paul Bellamy
78d7e29437 Merge pull request #941 from weaveworks/reorder-children-tables
Reorder the children tables in the details panel
2016-02-10 11:40:25 +00:00
Paul Bellamy
1b554baa91 Reorder the children tables in the details panel
The Container images was first on hosts, but is probably the least
useful, so this moves it to the bottom.

In general, it needs more thought put into the detail panel contents,
but this is a quick fix to re-prioritize the data.
2016-02-09 15:35:54 +00:00
Paul Bellamy
dfb0f8036c Only show key metadata by default. Hide rest in a drawer.
To make the interface cleaner, we can hide some non-key metadata by
default.

This needs styling, js testing, and probably a js refactor.
2016-02-08 17:14:16 +00:00
Tom Wilkie
107d3068d5 Shorten docker container and image IDs in the details panel. 2016-02-08 15:52:56 +00:00
Paul Bellamy
30dd97bab5 Merge pull request #920 from weaveworks/refactor-detailed-metadata
minor refactor of backend metadata and metric rendering
2016-02-08 15:37:12 +00:00
Paul Bellamy
e33838f1e6 minor refactor of backend metadata and metric rendering 2016-02-08 14:01:00 +00:00
Paul Bellamy
7fbf86aa8f shorten some labels which were truncated 2016-02-08 11:07:41 +00:00
Paul Bellamy
a403917875 Add "# Containers" column to container images as children
Side effect is that it also adds it to the container image details panel
2016-02-05 11:13:37 +00:00
Paul Bellamy
55ee62d343 add test for render/detailed/parents and fixed bug 2016-02-04 17:55:06 +00:00
Paul Bellamy
9876140bfe moving render/detailed/parents to it's own file 2016-02-04 14:46:13 +00:00
Paul Bellamy
51be599ca5 Merge pull request #904 from weaveworks/docker-labels
move docker labels into their own table of the details panel
2016-02-03 12:23:39 +00:00
Paul Bellamy
0a292f530c move docker labels into their own table of the details panel 2016-02-03 10:29:28 +00:00
Tom Wilkie
f89018efb7 Merge pull request #903 from weaveworks/immutable-renderablenodes
Add some tests, and a zero-value for report.Sets
2016-02-02 08:50:42 -08:00
Paul Bellamy
154c996d08 couple labels were added while waiting to merge 2016-02-02 16:19:40 +00:00
Paul Bellamy
b21eeb7bcf key of process.CPUUsage changed, while waiting to merge 2016-02-02 16:17:58 +00:00
Paul Bellamy
cae6ac58a8 Merge commit 'e31520d' 2016-02-02 15:54:39 +00:00
Paul Bellamy
d5d06197ed TestMakeRenderableNodes 2016-02-02 15:40:36 +00:00
Tom Wilkie
6f9fdaa27e Rename applications -> processes in experimental and render/detailed. 2016-02-01 06:54:19 -08:00
Tom Wilkie
638c5676cb Add container uptime and restart count to details panel. 2016-01-29 14:31:40 -08:00
Tom Wilkie
d0d6cac448 Use different key to count IPs, so we don't clash with containers.
Fixes #870
2016-01-28 14:48:56 -08:00
Tom Wilkie
fdd252a2e2 Merge pull request #858 from weaveworks/immutable-nodeset
use immutability for the NodeSet
2016-01-27 13:56:14 -08:00
Paul Bellamy
94d52f02a7 Refactored render/memoise and added a basic test for it 2016-01-27 16:29:55 +00:00
Paul Bellamy
66790f4436 use immutability for the NodeSet 2016-01-27 11:10:51 +00:00
Paul Bellamy
1943ad440a Merge pull request #851 from weaveworks/memoise-and-cache
Memoise & cache the result of renderers, so we don't recalculate views multiple times.
2016-01-27 11:10:21 +00:00
Paul Bellamy
b5037f511c fix bug in containers being filtered by image name 2016-01-26 14:45:10 +00:00
Paul Bellamy
599bade33f Merge branch 'master' of github.com:weaveworks/scope 2016-01-26 10:03:55 +00:00
Tom Wilkie
0e3e3b74f8 Add benchmark for list topologies API. 2016-01-25 21:48:18 -08:00
Tom Wilkie
b1a3a15ac0 A more debugging 2016-01-25 14:23:39 -08:00