Commit Graph

436 Commits

Author SHA1 Message Date
Alfonso Acosta
8a950a59d6 Remove Metric Add() method
* Helps reduce garbage (MakeMetric() now takes a slice and there's a shorter version MakeSingletonMetric())
* Fixes bug computing Max (Min) in samples since using MakeMetric()
  was causing a default Max/Min of zero.
* Simplifies code a bit
2016-08-01 16:58:11 +00:00
Alfonso Acosta
3e000662f4 Restore custom encoders/decoders for backwards compatibility 2016-08-01 11:07:03 +00:00
Alfonso Acosta
b8bf60c6f1 Use slices instead of linked lists for Metric
Also:

* Remove Gob encoder/decoder
* Stop using custom encoders/decoders for Timestamps (both ugorji and the Golang JSON codecs use nanosecond precision).
* Use idiomatic way to check for existence in metric.LastSample()
2016-08-01 10:21:57 +00:00
Matthias Radestock
b3874e6e6f show names of stopped containers
This got broken in b78c503

Fixes #1691
2016-07-21 11:01:53 +01:00
Matthias Radestock
34cb6d5a84 reduce container stats log noise
Don't complain about net.errClosing, which we typically get instead of
io.EOF when the container stops.
2016-07-16 20:33:15 +01:00
Matthias Radestock
30a5a9e64b reduce container stats log noise
reduce log level
2016-07-16 20:32:36 +01:00
Matthias Radestock
b38913e5c9 tiny improvement: log container id in stats collection loop 2016-07-16 20:12:19 +01:00
Jonathan Lange
2bfd6d7eb7 Parametrize compression level 2016-07-15 11:24:36 +01:00
Alfonso Acosta
26c6249516 Review comments 2016-07-07 16:18:18 +00:00
Alfonso Acosta
c843d24f6f Do not infer short-lived connections for host-networking containers 2016-07-07 15:44:13 +00:00
Alfonso Acosta
6175880725 Review feedback 2016-07-05 10:47:57 +00:00
Alfonso Acosta
c0a672c02a Review feedback 2016-07-01 16:51:57 +00:00
Alfonso Acosta
6f1e52cd0d Allow disabling controls in probes 2016-07-01 15:06:06 +00:00
Julius Volz
4fa40e22b2 Rework Scope metrics according to Prometheus conventions. (#1615)
* Rework Scope metrics according to Prometheus conventions.

- counters should end with _total
- elaborated and added units to help strings
- recommended for cache hit/miss metrics: track only the total and the
  hits and in separate metrics, since the most common query will be
  "hits / total"
- track all times in seconds (base units), which has become the standard
  recommendation
- other small changes

There could be more changes that would require more thinking (what
dimensions to use, summaries vs. histograms, etc.), but this is probably
enough controversial material already :)

* Use timeRequestStatus() in sqs_control_router.go.
2016-06-30 09:12:25 +01:00
Alfonso Acosta
05e6193e63 Merge pull request #1607 from weaveworks/1577-print-dns-errors
Print DNS errors
2016-06-28 01:58:54 +02:00
Alfonso Acosta
d33358ec63 Review feedback 2016-06-27 16:59:42 +00:00
Tom Wilkie
ab3d34be01 Make it easier to disable weave integrations (#1610)
* Make it easier to disable weave integrations

* Review feedback

* Make test pass
2016-06-27 16:11:57 +01:00
Alfonso Acosta
cab948887d Print DNS errors 2016-06-23 10:44:43 +00:00
Jonathan Lange
13269e8110 Helper for reading & writing from binary 2016-06-17 15:24:33 +01:00
Alfonso Acosta
e1afe22a22 Add all docker subnets to overlay topology 2016-06-15 21:22:29 +00:00
Alfonso Acosta
0587c6a967 Fix master after merging conflicting PRs #1531 and #1584
They both passed tests separately and were no source-line conflicts ... but shit happens.
2016-06-15 20:23:13 +00:00
Alfonso Acosta
5d07b99e69 Merge pull request #1584 from weaveworks/1563-read-docker-networks
Add docker networks to the Overlay Topology
2016-06-15 19:08:30 +01:00
Tom Wilkie
fba555c985 Use image name without version as id. (#1531)
* Use image name without version as id.

* Review feedback
2016-06-15 16:14:51 +01:00
Tom Wilkie
d888509865 Ignore IPv6 addresses in Docker reporter (#1552) 2016-06-15 16:05:12 +01:00
Alfonso Acosta
7fb40c802a Review feedback 2016-06-14 16:53:23 +00:00
Alfonso Acosta
6f0a31d1cd Add docker networks to the Overlay Topology 2016-06-14 14:58:43 +00:00
Alfonso Acosta
e01b88b7d9 Review feedback 2016-06-13 15:54:40 +00:00
Alfonso Acosta
3542c6b2f8 probe: add timeout to publisher and cancel requests on Stop() 2016-06-13 15:18:44 +00:00
Alfonso Acosta
47c5754923 Add test 2016-06-13 11:47:19 +00:00
Alfonso Acosta
0fd2754b58 Gather IPs from all the container networks 2016-06-10 17:45:54 +00:00
Alfonso Acosta
a6f8b0a0c6 Add probe version header to probe requests 2016-06-08 13:49:21 +00:00
Simon Howe
05ce661c19 Gets go-tests passing! 2016-06-06 16:24:18 +02:00
Peter Bourgon
e0fab36351 Re-sync container on network dis/connect 2016-06-06 16:24:03 +02:00
Peter Bourgon
10ced2d09d First cut of network data 2016-06-06 16:24:02 +02:00
Paul Bellamy
85aee27ef6 If k8s objects only have one container, show that container's metrics on them (#1473) 2016-06-04 08:03:51 +01:00
Tom Wilkie
277bd70491 Don't every store NEW conntrack flows (only every store updates). (#1541)
This closes a small window where we might produce reports which contain flows that are NEW but have never seen an UPDATE, which can potentially be invalid.
2016-05-27 11:25:42 +01:00
Alban Crequy
42ad3aa12b Scope slow: improve error messages for debugging (#1534)
* alpine: dl-4.alpinelinux.org is dead, use another server

* increase buffer for docker stats

Attempt to avoid the following message:
docker container: dropping stats.

* probe: better timeout error messages

The logs contains the following messages:

Process reporter took longer than 1s
K8s reporter took longer than 1s
Docker reporter took longer than 1s
Endpoint reporter took longer than 1s

This patch prints how long it takes.
2016-05-22 18:21:55 +01:00
Tom Wilkie
8f772a696d Add flag to disable reporting of processes (and procspied endpoints) 2016-05-17 17:29:09 +01:00
Tom Wilkie
310adc0d09 Fast start the dns resolution ticker to improve first report latency. 2016-05-16 11:19:57 +01:00
Alfonso Acosta
1e63d7a23d Add local networks for each k8s service (#1490) 2016-05-12 17:05:22 +01:00
Tom Wilkie
23c5e9f820 Ignore conntracked connections on which we never saw an update; don't nat map conntracked connections. (#1466) 2016-05-11 15:30:45 +02:00
Paul Bellamy
743cf80f92 Disable deployments and replica sets if k8s is 1.1 2016-05-11 11:19:15 +01:00
Paul Bellamy
291c9afe58 Add scale up/down controls on deployments, replica sets, and replication controllers (#1451) 2016-05-10 12:43:52 +02:00
Alfonso Acosta
b78c503004 Review feedback 2016-05-10 08:03:46 +00:00
Alfonso Acosta
e83f985ea6 Precompute base of the container nodes 2016-05-10 06:25:06 +00:00
Paul Bellamy
541699d193 Review Feedback 2016-05-09 09:19:11 +01:00
Paul Bellamy
16a5c738d9 Deployment and ReplicaSet views for k8s 2016-05-09 09:03:57 +01:00
Paul Bellamy
0178babb0e Index services by UID, and refactor out common k8s metadata handling 2016-05-09 09:03:56 +01:00
Alfonso Acosta
f34fc2a4df Merge pull request #1410 from weaveworks/1408-dnat-shortlived-connections
Correctly attribute DNAT-ed short-lived connections
2016-05-05 19:37:35 +01:00
Tom Wilkie
fc60b9308e Merge pull request #1433 from weaveworks/1373-kube-dns
Have probe query kube dns to find the app.
2016-05-05 16:02:40 +01:00