Commit Graph

248 Commits

Author SHA1 Message Date
Tom Wilkie
d237f52a90 Ensure connection rows have unique IDs. (#1245)
* Ensure connection rows have unique IDs.

This adds new types for connections tables.

* UI support for new connection table rows

* Parameterized node Id key for connections table

* also s/node_id/nodeId, and s/topology_id/topologyId in connections
* table

* Added comment about nodeIdKey

* Review feedback:
2016-04-11 14:40:50 +01:00
Paul Bellamy
ba83927db0 better detection of endpoint children, to avoid including MapX2IP results 2016-04-07 16:06:35 +01:00
Tom Wilkie
ee1b4def95 Make the initial procspy filter silent 2016-04-07 13:19:42 +01:00
Tom Wilkie
ca94368420 Don't report nodes filtered out through the short-lived-connections join 2016-04-07 13:14:57 +01:00
Tom Wilkie
674cb24f2a Review feedback 2016-04-07 12:23:06 +01:00
Tom Wilkie
22402c34f7 Ensure k8s views are correctly hidden.
- Filter unconnected psuedo nodes from the Pods view
- Don't report these filtered nodes in stats
- Fix typo in logic for hiding views
2016-04-07 12:01:23 +01:00
Paul Bellamy
f3adefa454 Update docker client, to get better state strings in the UI 2016-04-06 16:39:45 +01:00
Paul Bellamy
fe6203fd3f Review Feedback
Squash of:
- including children in topologies_test.go
- report.Node.Prune should prune children also
- rewrote ShortLivedInternetConnections test to express its intent
- adding tests for detail Summary rendering
2016-03-29 14:13:20 +01:00
Paul Bellamy
2c6b6e6707 Refactoring rendering to remove RenderableNode
Squash of:
- use detailed.Summaries to render topology nodes
- ban merging nodes of different topologies (they should be mapped)
- need to prune parents when mapping node types
- render container images by id if they have no name
- remove separate render ids and prune parents in NewDerived*
- don't render metrics/metadata for groups of nodes
- fixing up tests
- removing pending unit tests (for mapping.go, for now)
- updating experimental dir for RenderableNode removal
2016-03-29 14:13:03 +01:00
Paul Bellamy
80dc714c1e rename LabelMajor to Label 2016-03-29 14:00:11 +01:00
Paul Bellamy
430130c03a backend changes for new option rendering 2016-03-29 13:26:49 +02:00
Paul Bellamy
ecab765b07 Merge pull request #1179 from weaveworks/1155-single-pseudo-nodes
Don't show multiple pseudo nodes in the host view for the same IP
2016-03-23 12:37:49 +00:00
Tom Wilkie
7e2e4c9c45 Fix spelling mistakes in the codebase. 2016-03-23 10:51:27 +00:00
Alfonso Acosta
13ec8d97c9 Stop mutating nodes in ColorConnected filter 2016-03-22 14:23:34 +00:00
Tom Wilkie
5cfc9d2a29 Don't show multiple pseudo nodes in the host view for the same IP 2016-03-17 15:00:04 +00:00
Tom Wilkie
e7c5fc7016 Remove address topology 2016-03-08 13:23:30 +00:00
Tom Wilkie
60f5a5e36f Treat pid as numeric and sort by #containers 2016-03-04 17:10:24 +00:00
Tom Wilkie
51fa8d8ce0 Review feedback II 2016-03-04 14:07:56 +00:00
Tom Wilkie
09de883bc6 Review feedback 2016-03-03 17:46:35 +00:00
Tom Wilkie
f154e7a483 Add connection tables to details panel 2016-03-03 16:17:55 +00:00
Tom Wilkie
19411b9f76 Review feedback 2016-03-02 10:35:11 +00:00
Tom Wilkie
d874266cf6 Stop mutating nodes in the rendering pipeline 2016-03-01 17:16:48 +00:00
Tom Wilkie
bc48a48133 Split the internet node for incoming vs outgoing connections. 2016-03-01 14:11:47 +00:00
Tom Wilkie
28a0dd9d76 Fix for new go1.6 lint rules. 2016-03-01 13:01:19 +00:00
Tom Wilkie
ef1fc2a60a Merge pull request #1043 from weaveworks/1040-docker-exec-crash
Distinguish between reporting probes and controlling probes
2016-02-26 15:23:47 +00:00
Alfonso Acosta
a559a23dba Distinguish between reporting probes and controlling probes 2016-02-26 01:46:18 +00:00
Simon Howe
569ca9d3d9 Pentagon -> Heptagon! 2016-02-25 16:27:13 +01:00
Paul Bellamy
6cef1b10ca adding direction to connections from conntrack
* Remove report.EdgeMetadata.MaxConnCountTCP, as we don't display it anywhere
* Remove hostname metadata from local end of connection. We should be using the hostnodeid
2016-02-23 14:17:45 +00:00
Simon Howe
dca7408ec1 Rollback aggNode.nodeCount which was used for the stack shape.
We're not using greyed out lower stacks for now.
2016-02-22 12:42:37 +01:00
Simon Howe
2c626776a1 Grey out bottom of stack when there aren't 3 nodes in the stack
E.g. greying out the bottom 2/3 visual nodes if the stack actually only
has a single node.

- Server returns "node_count" for agg nodes.
2016-02-22 12:42:37 +01:00
Tom Wilkie
3f7f55e87e Backend for node shapes 2016-02-22 12:42:36 +01:00
Paul Bellamy
d2bf204181 Merge pull request #960 from weaveworks/no-ips-for-no-network
Don't show blank IPs metadata row for containers with no IP
2016-02-19 17:39:01 +00:00
Paul Bellamy
5535f5e738 Review Feedback 2016-02-19 17:04:00 +00:00
Tom Wilkie
0402f6d8f3 Merge pull request #962 from weaveworks/no-pointer-math
Remove pointer math (comparison) from render caching, as it is unreliable
2016-02-19 12:43:43 +00:00
Alfonso Acosta
ddf5fff5c2 Inline encoding of previously embedded fields
To avoid impacting the client's code with implementation details.
2016-02-18 12:49:31 +00:00
Alfonso Acosta
6ac176a492 Remove github.com/2opremio/go-1/codec
* Bump github.com/ugorji/go/codec, to get fixes which make
  github.com/2opremio/go-1/codec unnecessary

* Remove github.com/2opremio/go-1/codec

* Remove type embeddings to avoid the problem explained at
  https://github.com/ugorji/go/issues/141#issuecomment-185450157
2016-02-18 12:47:06 +00:00
Paul Bellamy
0379fc4cf3 generate an ID for each memoiser so they can share cache
Makes cache clearing easier, and then we don't need to add
`ResetCache()` to the Renderer interface.
2016-02-17 17:10:14 +00:00
Paul Bellamy
df856d78dc set container IPs to host IPs for containers with --net=host 2016-02-17 16:42:52 +00:00
Paul Bellamy
a0a60ca079 Remove pointer math (comparison) from render caching, as it is unreliable 2016-02-17 15:41:16 +00:00
Alfonso Acosta
a2710ecfd5 Merge pull request #916 from weaveworks/854-reports-codec
Improve codec performance
2016-02-17 14:07:31 +00:00
Alfonso Acosta
bdc97d6e06 Circumvent https://github.com/ugorji/go/issues/142 2016-02-16 23:52:36 +00:00
Alfonso Acosta
9c368c4e84 Implement Selfers for all render types
To workaround https://github.com/ugorji/go/issues/141
2016-02-16 23:52:32 +00:00
Paul Bellamy
44dada25f2 Review Feedback 2016-02-16 10:37:25 +00:00
Alfonso Acosta
0d917b2d8b Use github.com/ugorji/go/codec/ for wiring messages
* New encoding format:
  * Msgpack reports between probe<->app (smaller representation, faster to
    encode/decode).
  * Still use JSON between app<->UI (try to avoid making javascript deal with
    mspack).

  The app still suports publishing reports in both gob and JSON, not braking
  backwards compatibility.

* Use compile-time generated marshallers/unmarshallers for higher performance. In
  order to be able to skip code-generation for certain types, I included
  https://github.com/2opremio/go-1/tree/master/codec/codecgen instead of
  upstream until https://github.com/ugorji/go/pull/139 is merged.

* Encode/decode intermediate types using github.com/ugorji/go/codec.Selfer
  for higher performance and reducing garbage collection (no temporary buffers).
2016-02-16 06:31:31 +00:00
Paul Bellamy
5bb3d49297 gather file descriptors as process metric 2016-02-12 17:13:27 +00:00
Paul Bellamy
8c4f025bf5 don't render any metrics/metadata for uncontained node 2016-02-11 16:01:04 +00:00
Paul Bellamy
05d4ce05a3 Merge pull request #946 from weaveworks/929-show-more-metadata
Only show key metadata by default. Hide rest in a drawer.
2016-02-11 11:08:39 +00:00
Paul Bellamy
d5a2b5bb9d show all process and pod metadata, as there's only 4, and 3 rows respectively. 2016-02-11 09:39:25 +00:00
Paul Bellamy
89d7ebe977 show nice column labels when no children have metrics 2016-02-10 11:42:03 +00:00
Paul Bellamy
78d7e29437 Merge pull request #941 from weaveworks/reorder-children-tables
Reorder the children tables in the details panel
2016-02-10 11:40:25 +00:00